Jump to content
Secrets

Release: Soul Link Modification - Script-based

Recommended Posts

Soul Link Modification - Script-based


Information

This source allows you to "script" additional bonuses on soul link buffs like an item script.
See db/soul_link.yml for example.

Q: Why this and not OnPCStatCalcEvent?
A: PCStatCalc is known to be buggy.

Alternate diff link: https://github.com/secretdataz/rathena/commit/6b91c4d18cc537e25a64f371ee3faf468b9dcc99.diff

THIS RELEASE IS SUBJECT TO GPLv3 LICENSE

Copyright © - Secrets <[email protected]> 2018 - All Rights Reserved

Take a look at my premade script list if you like my works or want one of my premade scripts. or

kofi2.png


 

  • Love 2
  • MVP 2

Share this post


Link to post
Share on other sites

Nice released @Secrets will this override the old soul link bonuses or its an additional bonus.?

while compiling my files, warning in that part.

status.cpp:14748:44: warning: ISO C++ forbids converting a string constant to char*’ [-Wwrite-strings]
  status_read_soullink_db("db/soul_link.yml");

Im using Ubuntu.

Edited by Radian

Share this post


Link to post
Share on other sites
6 hours ago, Radian said:

Nice released @Secrets will this override the old soul link bonuses or its an additional bonus.?

while compiling my files, warning in that part.

status.cpp:14748:44: warning: ISO C++ forbids converting a string constant to char*’ [-Wwrite-strings]
  status_read_soullink_db("db/soul_link.yml");

Im using Ubuntu.

This will add, not override the old bonuses.

Share this post


Link to post
Share on other sites
8 hours ago, Secrets said:

This will add, not override the old bonuses.

Thats cool.. thanks!

Share this post


Link to post
Share on other sites

@Secrets

There's a warning when, I use reloadstatus command
 

[Warning]: status_read_soullink_db: Expected a constant with SL_ prefix, got Header.
[Info]: status_read_soullink_db: Done reading 15 custom soul links.

 

Share this post


Link to post
Share on other sites

so can u use @reloaditemdb command to reload the scripts for this soul link mod? 

Share this post


Link to post
Share on other sites

Is it possible to add soul links for ninja and gunslingers using this? (of course they'll be buffed using an item since Ninja/Gunslinger Spirit skills are not available)

ex:

SL_NINJA: |
    {
        bonus bStr,1;
    }

 

Share this post


Link to post
Share on other sites
On 4/2/2018 at 7:22 PM, Quesooo said:

@Secrets any way to fix this? or this is normal?

image.png.619f0818f35179a0b466acfc72e6c1f9.png

@Secrets how to solve this please ^_^

Share this post


Link to post
Share on other sites
On 4/2/2018 at 7:22 PM, Quesooo said:

@Secrets any way to fix this? or this is normal?

image.png.619f0818f35179a0b466acfc72e6c1f9.png

@Secrets how to remove this warning in my server? tjanks

Share this post


Link to post
Share on other sites
3 hours ago, iamkevin said:

@Secrets how to remove this warning in my server? tjanks

Try In status.cpp

find:

void status_read_soullink_db(char* file_name) {

change to:

void status_read_soullink_db(const char* file_name) {

 

  • Upvote 2

Share this post


Link to post
Share on other sites
3 hours ago, Haikenz said:

Try In status.cpp

find:

void status_read_soullink_db(char* file_name) {

change to:

void status_read_soullink_db(const char* file_name) {

 

thanks sir, i was able to removed the warning sign with your help but i got this warning:
 

[Warning]: status_read_soullink_db: Expected a constant with SL_ prefix, got Header.
[Info]: status_read_soullink_db: Done reading 15 custom soul links.
 

Share this post


Link to post
Share on other sites

hi,

 

tried and it doesnt work on my latest downloaded rathena file?

what else i am missing no error on recompile

Share this post


Link to post
Share on other sites
On 9/20/2018 at 10:13 AM, dantemustdie said:

hi,

 

tried and it doesnt work on my latest downloaded rathena file?

what else i am missing no error on recompile

did you patch it to your server?

Share this post


Link to post
Share on other sites

Very nice update and it is working! Is this possible to reload when the server is  currently up?

Share this post


Link to post
Share on other sites

I dont get what was the meaning of those directories.. I was doing manual source update.. how to embed these source scripts?

On 6/15/2019 at 9:27 PM, DrKraken said:

follow the instruction. but there's a error in the code 

got it working now

On 6/16/2019 at 9:55 PM, DrKraken said:

how? can you teach me?

just follow the instructions

On 6/17/2019 at 3:18 PM, DrKraken said:

can you help me to solve the problem?

what error you got?

Share this post


Link to post
Share on other sites

i try this and got no error while re compiling

 

but when i'm trying to put the effect and use the Soul link skill on character

 

id does not apply the bonuses

Share this post


Link to post
Share on other sites

@secrets how to remove bonuses when you die and revive at the same place, the bonus effects retain unless you get buff with another status.

solved. solution lies in status.cpp and pc.cpp

Share this post


Link to post
Share on other sites

[Warning]: status_read_soullink_db: Expected a constant with SL_ prefix, got Header.
[Info]: status_read_soullink_db: Done reading 15 custom soul links.

 

Anyone manage to get rid of this warning? it's giving me Memory leaks.

Share this post


Link to post
Share on other sites

To get rid of the warning, just comment the header in db/soul_link.yml

#Header: # Metadata for future use
#  Type: MOD_SECRET_SOUL_LINK
#  Version: 1

 

  • Love 1
  • Like 1

Share this post


Link to post
Share on other sites

Any update about this? 

 

getting error on latest rev.

image.thumb.png.5d9e5c63ed0c0204a91faf9940e1f417.png

Share this post


Link to post
Share on other sites
20 hours ago, Takuyakii said:

Any update about this? 

 

getting error on latest rev.

image.thumb.png.5d9e5c63ed0c0204a91faf9940e1f417.png

SAME ERROR HERE. ANY UPDATES?

Share this post


Link to post
Share on other sites

 

On 2/21/2020 at 5:20 PM, Takuyakii said:

Any update about this? 

 

getting error on latest rev.

image.thumb.png.5d9e5c63ed0c0204a91faf9940e1f417.png

Solved ❤️

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use and Privacy Policy.