Extended Vending System [1.9] cleanup & fix

[AinsLord]

is this working fine??

[Lelouch vi Britannia]

I noticed this...

Well it seem working fine until i restarted the server server 2x and this is the result

 

But after 2x server restart the currency returned into its normal vending currency which is Zeny also the Extended Vend message that the sale is carried out is gone.

Finally i think i found a solution to my problem . I did was...

Changing this

	sd->vend_loot = nameid;
	sd->state.prevend = 1;

to this

	sd->state.prevend = 1;
	sd->vend_loot = nameid;

also disabling this

				// Extended Vending system [Lilith]
				if(!battle_config.extended_vending)
					at->vend_loot = 0;

and adding this

				// initialize player
				CREATE(at->sd, struct map_session_data, 1);
				pc_setnewpc(at->sd, at->account_id, at->char_id, 0, gettick(), at->sex, 0);
				at->sd->state.autotrade = 1|2;
+				at->sd->vend_loot = at->vend_loot;	// Extended Vending system [Lilith]
				at->sd->state.monster_ignore = (battle_config.autotrade_monsterignore);
				chrif_authreq(at->sd, true);
				uidb_put(vending_autotrader_db, at->char_id, at);

then recompile. I also did some test if the shop currency will vanished and return to 0 but after 5 restarts the currency didnt vanished or return into 0.

[Note]: I think the issue was on

				// Extended Vending system [Lilith]
				if(!battle_config.extended_vending)
					at->vend_loot = 0;

because the vend currency keeps returning to 0 if you dont disable it and add this

				// initialize player
				CREATE(at->sd, struct map_session_data, 1);
				pc_setnewpc(at->sd, at->account_id, at->char_id, 0, gettick(), at->sex, 0);
				at->sd->state.autotrade = 1|2;
+				at->sd->vend_loot = at->vend_loot;	// Extended Vending system [Lilith]
				at->sd->state.monster_ignore = (battle_config.autotrade_monsterignore);
				chrif_authreq(at->sd, true);
				uidb_put(vending_autotrader_db, at->char_id, at);

but its my wild guess .

Edited June 29, 2016 by Lelouch vi Britannia

[AinsLord]

does this work on SVN r218?

[Stolao]

Why are you using r218 just use latest from github

[AinsLord]

Why are you using r218 just use latest from github

link for the latest in github thnx in advance

[Stolao]

here

[alternate]

Guys, im using latest rev and i got no errors compiling the changes but when i run my servers it show this msg:

 

: DB error - Unkown column 'extended_vending_item' in 'field list'

[Debug] at ..\src\vending.c:654 - SELECT 'id', 'account_id', 'char_id', 'sex', 'title', 'body_direction', 'head_direction', 'sit', 'extended_vending_item'FROM 'vendings' WHERE 'autotrade' =1 AND (SELECT COUNT('vending_id') FROM 'vending_items' WHERE 'vending_id' = 'id') > 0 ORDER BY 'id' ;

 

any lights on this issue?

 

@edit

Also i tried to open a shop and i my hexed stopped working when i was about to open it.

Edited July 6, 2016 by alternate

[Yonko]

Guys, im using latest rev and i got no errors compiling the changes but when i run my servers it show this msg:

 

: DB error - Unkown column 'extended_vending_item' in 'field list'

[Debug] at ..\src\vending.c:654 - SELECT 'id', 'account_id', 'char_id', 'sex', 'title', 'body_direction', 'head_direction', 'sit', 'extended_vending_item'FROM 'vendings' WHERE 'autotrade' =1 AND (SELECT COUNT('vending_id') FROM 'vending_items' WHERE 'vending_id' = 'id') > 0 ORDER BY 'id' ;

 

any lights on this issue?

 

@edit

Also i tried to open a shop and i my hexed stopped working when i was about to open it.

did you add the sql file on your database?

[alternate]

 

Guys, im using latest rev and i got no errors compiling the changes but when i run my servers it show this msg:

 

: DB error - Unkown column 'extended_vending_item' in 'field list'

[Debug] at ..\src\vending.c:654 - SELECT 'id', 'account_id', 'char_id', 'sex', 'title', 'body_direction', 'head_direction', 'sit', 'extended_vending_item'FROM 'vendings' WHERE 'autotrade' =1 AND (SELECT COUNT('vending_id') FROM 'vending_items' WHERE 'vending_id' = 'id') > 0 ORDER BY 'id' ;

 

any lights on this issue?

 

@edit

Also i tried to open a shop and i my hexed stopped working when i was about to open it.

did you add the sql file on your database?

 

 

@Yonko

Ops, forgot to do that! already done and the message from map server is gone BUT

when i try do create any shop my hexed quits and stop working

with no error within the servers 

[Expectra]

Help got this error on my rathena...

Skill.c: In fuction 'skill_castend_nodamage_id':

Skill.c:7310: warning: implict declaración of fuction 'clif_vend'

I am using the extend vending 1.9.4 r15149

Edited July 11, 2016 by Expectra

[Ares]

Is there a stable release on this? xD

[wOni]

i did try this, no error will compiling but suddenly when i try it vend and click the zeny or coin or any i get this
 

[Error]: Server received crash signal! Attempting to save all online characters!

Help!

 

Napster , are you still active?

 

Im test this with current GIT, open vending choose TCG Card ID:7227 and...

Packet Ver: '45', IP: '127.0.0.0', Group '99').
[Error]: Server received crash signal! Attempting to save all online characters!

Any solution about here?, idid manually patch  ExtendedVendingSystem_1.9.4_r15149.diff 

same problem

[Technoken]

Any solution with this?

After I updated to Git Hash: 9b1b7b1 , i'm having these compile error and warnings.

1>..\src\map\skill.c(7433): error C2065: 'TABLE_CART_' : undeclared identifier
1>..\src\map\skill.c(7433): warning C4047: 'function' : 's_storage *' differs in levels of indirection from 'int'
1>..\src\map\skill.c(7433): warning C4024: 'intif_storage_save' : different types for formal and actual parameter 2

I think it's because of the updates on Git Hash: ade1b17

Any help? thank you!

[DevLong]

I tried to apply the system in my emulator and I came across this error when compiling

http://ap.imagensbrasil.org/image/E4H2tH

1>..\src\map\itemdb.c(1686): error C2065: 'itemdb_read_vending' : undeclared identifier
1>..\src\map\itemdb.c(1686): warning C4047: 'function' : 'bool (__cdecl *)(char **,int,int)' differs in levels of indirection from 'int *'
1>..\src\map\itemdb.c(1686): warning C4024: 'sv_readdb' : different types for formal and actual parameter 7
1>..\src\map\vending.c(186): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(187): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(267): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(270): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(313): error C2039: 'cart' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(313): error C2198: 'itemdb_search' : too few arguments for call
========== Build: 0 succeeded, 1 failed, 3 up-to-date, 0 skipped ==========
 

I tried several ways to correct the error but I did not find a solution

[Chaos92]

 

On 1/5/2017 at 4:34 AM, DevLong said:

I tried to apply the system in my emulator and I came across this error when compiling

http://ap.imagensbrasil.org/image/E4H2tH

1>..\src\map\itemdb.c(1686): error C2065: 'itemdb_read_vending' : undeclared identifier
1>..\src\map\itemdb.c(1686): warning C4047: 'function' : 'bool (__cdecl *)(char **,int,int)' differs in levels of indirection from 'int *'
1>..\src\map\itemdb.c(1686): warning C4024: 'sv_readdb' : different types for formal and actual parameter 7
1>..\src\map\vending.c(186): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(187): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(267): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(270): error C2039: 'inventory' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(313): error C2039: 'cart' : is not a member of 'mmo_charstatus'
1>          c:\users\iraaid\documents\teste novo server\rathena-master\rathena-master\src\map\../common/mmo.h(426) : see declaration of 'mmo_charstatus'
1>..\src\map\vending.c(313): error C2198: 'itemdb_search' : too few arguments for call
========== Build: 0 succeeded, 1 failed, 3 up-to-date, 0 skipped ==========
 

I tried several ways to correct the error but I did not find a solution

yup occur to me too 

[AinsLord]

will this be working for the r25773???

[GameLord14]

Any update?

[AinsLord]

any update for this im using the latest rev on github

[iamkevin]

Having problem

 

[AinsLord]

any update on this??

will this work now on latest rev from github??

[AinsLord]

any update on this one??

[Akkarin]

I don't know why you keep asking if there's "any updates" for this release - the older a release becomes, the less likely it will work with the current revisions of rAthena.

[simplexjay2]

up

On 3/28/2017 at 3:16 PM, bbestkanatip said:

I have this problem how can i solve it

same Error Latest Git

[simplexjay2]

Can Someone Update this

[Akkarin]

On 2017-6-21 at 10:41 AM, almer said:

is this working on 17704 SVN?>>

We don't use svn.