Extended Vending System [1.9] cleanup & fix

[Akkarin]

On 2017-6-21 at 10:41 AM, almer said:

is this working on 17704 SVN?>>

We don't use svn.

[Deleted User]

On 6/21/2017 at 4:41 AM, almer said:

is this working on 17704 SVN?>>

For godsake, please stop using SVN. and i would say "NO" it does not work on "SVN"

[mhielo12]

Can this be updated for latest git? would be really appreciated thanks..

will be usefull for highrate server.

[solid2005]

i made some update code from rathena maybe this should be help. i didn't test it cause i don't have time =P

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

 

version 1.9.5.diff

[M4karov]

On 28/07/2017 at 5:42 AM, solid2005 said:

Eu fiz um código de atualização da Rathena talvez isso venha a ser de ajuda. Eu não testei porque eu não tenho tempo = P

AVISO Faça o backup primeiro e use um servidor de teste se estável,

Nota: Atualize para GIT NO mais recente  (correção de bugs e add on).

 

Versão 1.9.5.diff

The system worked perfectly, but I noticed these errors on my map-server.

Error: http://prntscr.com/g8toc7

[Technoken]

4 minutes ago, M4karov said:

The system worked perfectly, but I noticed these errors on my map-server.

Error: http://prntscr.com/g8toc7

Have you tried to import the sql?

[M4karov]

2 minutes ago, Technoken said:

Você tentou importar o sql?

I minded this one:

ALTER TABLE `vendings` ADD COLUMN `extended_vending_item` smallint(5) unsigned NOT NULL DEFAULT '0' AFTER `sit`;

 

[Technoken]

6 minutes ago, M4karov said:

I minded this one:

ALTER TABLE `vendings` ADD COLUMN `extended_vending_item` smallint(5) unsigned NOT NULL DEFAULT '0' AFTER `sit`;

 

On vending.c 
find

"VALUES( %d, %d, %d, '%c', '%s', %d, %d, '%s', %d, '%d', '%d', '%d' );",

replace

"VALUES( %d, %d, %d, '%c', '%s', %d, %d, '%s', %d, '%d', '%d', '%d', '%hu' );",

solid2005 might have forgotten to update his part on his diff.

[M4karov]

4 minutes ago, Technoken said:

On vending.c 
find

"VALUES( %d, %d, %d, '%c', '%s', %d, %d, '%s', %d, '%d', '%d', '%d' );",

replace

"VALUES( %d, %d, %d, '%c', '%s', %d, %d, '%s', %d, '%d', '%d', '%d', '%hu' );",

solid2005 might have forgotten to update his part on his diff.

Perfect! Thank you for your help.

[Haikenz]

With me it is giving this error: I use SQL item_db_re

[mhielo12]

Hi i successfully patch the diff but my problem when i try to buy the vended item it always says " you dont have enough PODS" even tho i have all the requirment 

[M4karov]

@Technoken After applying the last commits of github changing my script.c to script.cpp I have these errors in the compilation, could give me a direction of how to solve?

[Technoken]

4 hours ago, M4karov said:

@Technoken After applying the last commits of github changing my script.c to script.cpp I have these errors in the compilation, could give me a direction of how to solve?

Can you try this one if it would work. I can't test it right now.
On itemdb.h
find

struct s_item_vend item_vend[MAX_INVENTORY];

replace with

extern struct s_item_vend item_vend[MAX_INVENTORY];

 

[M4karov]

1 minute ago, Technoken said:

Você pode tentar isso se ele funcionasse. Não posso testá-lo agora mesmo.
No itemdb.h
encontrar

substituir com

 

I had tried it that way, but it did not work.

[Technoken]

on itemdb.c apply this
 

	static DBMap *itemdb_randomopt_group; /// Random option group DB

	struct item_data *dummy_item; /// This is the default dummy item used for non-existant items. [Skotlex]

	struct s_roulette_db rd;

+	struct s_item_vend item_vend[MAX_INVENTORY];

	/**
	* Check if combo exists

If it still doesn't work. I'll just update here whenever I got mine working. Can't do it right now since im not at home.

[Pixel]

On 28/07/2017 at 5:42 AM, solid2005 said:

i made some update code from rathena maybe this should be help. i didn't test it cause i don't have time =P

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

 

version 1.9.5.diff

Thx @solid2005 and @Technoken thanks you guys to make it work.

<3

[Elysium]

Can anyone provide a working diff? =) that would be appreciated.

[Pixel]

8 hours ago, Elysium said:

Can anyone provide a working diff? =) that would be appreciated.

Update your emulator for the latest version of Git.

version 1.9.5 [08-09-2017].diff

[mhielo12]

seems no to be working.. Pixel

undefined reference to "item_vend" rathena

=====================================

I successfully patch the one that provided by solid2005

but problem is i cant buy the item that is on vend..

" You dont have enought Items" even tho i have all the requirement like pods..

 

[Technoken]

9 hours ago, mhielo12 said:

undefined reference to "item_vend" rathena

On itemdb.h
find: struct s_item_vend item_vend[MAX_INVENTORY];
replace: extern struct s_item_vend item_vend[MAX_INVENTORY];

On itemdb.c
find: struct s_roulette_db rd;
add below: struct s_item_vend item_vend[MAX_INVENTORY];

[Haikenz]

2 hours ago, Technoken said:

On itemdb.h
find: struct s_item_vend item_vend[MAX_INVENTORY];
replace: extern struct s_item_vend item_vend[MAX_INVENTORY];

On itemdb.c
find: struct s_roulette_db rd;
add below: struct s_item_vend item_vend[MAX_INVENTORY];

100% work! thanks

[mhielo12]

6 hours ago, Technoken said:

On itemdb.h
find: struct s_item_vend item_vend[MAX_INVENTORY];
replace: extern struct s_item_vend item_vend[MAX_INVENTORY];

On itemdb.c
find: struct s_roulette_db rd;
add below: struct s_item_vend item_vend[MAX_INVENTORY];

Hi manage to make it work but my problem regarding "you dont have enough items" still there

cant buy the item on the vend.. although i have all requirement..

[Technoken]

9 minutes ago, mhielo12 said:

Hi manage to make it work but my problem regarding "you dont have enough items" still there

cant buy the item on the vend.. although i have all requirement..

Try to double check the codes that you applied. It's working fine on me.

[mhielo12]

4 hours ago, Technoken said:

Try to double check the codes that you applied. It's working fine on me.

No error on map server  im really lost.. 

you have a working sql for this? ill try to delete my sql..

EDIT:

Hi Technoken

I check the previous version and compare to the new version

in the old diff there is this line in item_vending.txt

Index: db/item_vending.txt
===================================================================
--- db/item_vending.txt    (nonexistent)
+++ db/item_vending.txt    (working copy)
@@ -0,0 +1,12 @@
+// Specific items for Vending System
+// Format: ItemID
+// Max items is equal MAX_INVENTORY ( 100 by default )
+
+// TCG Card
+7227
+// Mithril Coin
+674
+// Silver Coin
+675
+// Bronze Coin
+673

Should I remove this on the new patch?

Edited September 9, 2017 by mhielo12

[mhielo12]

1 hour ago, mhielo12 said:

No error on map server  im really lost.. 

you have a working sql for this? ill try to delete my sql..

EDIT:

Hi Technoken

I check the previous version and compare to the new version

in the old diff there is this line in item_vending.txt

Index: db/item_vending.txt
===================================================================
--- db/item_vending.txt    (nonexistent)
+++ db/item_vending.txt    (working copy)
@@ -0,0 +1,12 @@
+// Specific items for Vending System
+// Format: ItemID
+// Max items is equal MAX_INVENTORY ( 100 by default )
+
+// TCG Card
+7227
+// Mithril Coin
+674
+// Silver Coin
+675
+// Bronze Coin
+673

Should I remove this on the new patch?

I removed this in the new patch still not work..  help im lost..  is it zeny cash only working?