Release: Extended Vending 2.0

[AinsLord]

On 4/11/2019 at 11:24 AM, BugsLIFE said:

update pls.... i also experience this

i think restarting the server won't fix it

try to re-compile your server since it was a src configuration its actually working fine

my only problem is everytime i reset my server items can be bought using zeny

coz mainly @at command leaves the character online even reset of the server

Edited April 14, 2019 by AinsLord

[nomade]

I need help!!!!

I added the system correctly with no errors at the time of compiling the emulator.

It works everything normal in the game. My problem is when I buy the item from a store, the map-server restarts.

When I'm entered the game again, the sale was not made.

 

[Bringer]

sprintf(message + strlen(message), "Total profit: %s x %d", "Zeny", (mailprofit -= mailprofit * (battle_config.vending_tax / 10000.)));

rathena\src\map\vending.cpp(395): warning C4244: '-=': conversion from 'double' to 'int', possible loss of data
 

[CyberDevil]

Installed yesterday on the last rAthena version (a548f20) and all work...혻there is only a small error in the message that appears to the merchant after selling an item and closing the store remaining online (without @autotrade), which displays the gain minus the taxes even if the tax feature has not been activated... I have however solved by modifying the text of the message with a simple "With active tax, the gain was of XYZ", but in any case immediately after this text appears in the line below the real total gain without taxes... a minimum problem!

 

@Easycore혻I had an "unhealthy" idea... in the future could we implement this exchange method also for the Buying Store System (https://irowiki.org/wiki/Buying_Store)?혻
It would be interesting to be able to have items searched for and exchange them for other currencies than Zeny

Edited June 11, 2019 by CyberDevil

[Dissidia]

Help the item I buy is not bounded but it shows like this.

 

[Loke]

On 6/17/2019 at 5:47 PM, Dissidia said:

Help the item I buy is not bounded but it shows like this.

 

I got this error also did you fix it?

[Dissidia]

8 hours ago, Loke said:

I got this error also did you fix it?

//if (sd->inventory.u.items_inventory[k].bound) {
                    //    clif_displaymessage(sd->fd, "Cannot buy with Bound Items.");
                    //    return;
                    //}

[Loke]

1 hour ago, Dissidia said:

//if (sd->inventory.u.items_inventory[k].bound) {
                    //    clif_displaymessage(sd->fd, "Cannot buy with Bound Items.");
                    //    return;
                    //}

Thank you! I'll try this later.

[Dissidia]

11 minutes ago, Loke said:

Thank you! I'll try this later.

It will work. Don't know why they add that. In the previous version there is no code like that.

[il3ol2ed]

Thank

[3TAJIOH]

Bug. After server restart, auotrade shops will be for zeny.

[Feilor]

On 7/18/2019 at 9:04 AM, 3TAJIOH said:

Bug. After server restart, auotrade shops will be for zeny.

Functor or sbk sent a fix for it in one page of this thread, search and you can find it.

[PsyOps]

On 6/11/2019 at 11:33 AM, Bringer said:

sprintf(message + strlen(message), "Total profit: %s x %d", "Zeny", (mailprofit -= mailprofit * (battle_config.vending_tax / 10000.)));

 rathena\src\map\vending.cpp(395): warning C4244: '-=': conversion from 'double' to 'int', possible loss of data
  

The extended vending does work for me but i still get this error on my VS. Anyone know how to fix this?

Tried:

 

sprintf(message + strlen(message), "Total profit: %s x %d", "Zeny" ,(mailprofit -= mailprofit * (int)(battle_config.vending_tax / 10000.)));

Edited July 26, 2019 by Dev G Inc

[SkyDragon]

Does it work for old rA versions? (2016, 2017).

[PsyOps]

On 8/4/2019 at 9:04 AM, SkyDragon said:

Does it work for old rA versions? (2016, 2017).

It should work with 2017 version. there are older versions of this diff as well.

 

[dantoki]

Having bunch of errors on the latest git.

[CyberDevil]

On 11/22/2018 at 9:49 AM, SBK_ said:

You need to make a fix on the system so that the @autotrade system after rebooting the server returns with the item that was selected for trading, quite simple.

In the do_init_vending_autotrade function, find:

at-> sd-> state.monster_ignore = (battle_config.autotrade_monsterignore);

add after:

// Extended Vending System Fix Bug [CreativeSD]
at-> sd-> vend_loot = at-> vend_loot;

 

I have the same problem after server restart, precisely after the restart the items that can be purchased by merchants in autotrades with different zeny currencies, can also be purchased with zeny and no longer with the currency also shown in the merchant's autotrade trade window. But despite several attempts and tests I was unable to solve the problem... my code is also different and shows these lines in the file /src/map/vending.cpp

				// initialize player
				CREATE(at->sd, struct map_session_data, 1);
				pc_setnewpc(at->sd, at->account_id, at->char_id, 0, gettick(), at->sex, 0);
				at->sd->state.autotrade = 1|2;
				if (battle_config.autotrade_monsterignore)
					at->sd->state.block_action |= PCBLOCK_IMMUNE;
				else
					at->sd->state.block_action &= ~PCBLOCK_IMMUNE;
				chrif_authreq(at->sd, true);
				uidb_put(vending_autotrader_db, at->char_id, at);
			}
			Sql_FreeResult(mmysql_handle);

Anyone can help me to fix it?

vending.cpp

[SBK_]

9 hours ago, CyberDevil said:

I have the same problem after server restart, precisely after the restart the items that can be purchased by merchants in autotrades with different zeny currencies, can also be purchased with zeny and no longer with the currency also shown in the merchant's autotrade trade window. But despite several attempts and tests I was unable to solve the problem... my code is also different and shows these lines in the file /src/map/vending.cpp

				// initialize player
				CREATE(at->sd, struct map_session_data, 1);
				pc_setnewpc(at->sd, at->account_id, at->char_id, 0, gettick(), at->sex, 0);
				at->sd->state.autotrade = 1|2;
				if (battle_config.autotrade_monsterignore)
					at->sd->state.block_action |= PCBLOCK_IMMUNE;
				else
					at->sd->state.block_action &= ~PCBLOCK_IMMUNE;
				chrif_authreq(at->sd, true);
				uidb_put(vending_autotrader_db, at->char_id, at);
			}
			Sql_FreeResult(mmysql_handle);

Anyone can help me to fix it?

vending.cpp 29.31 kB · 0 downloads

Add after:

at->sd->state.block_action &= ~PCBLOCK_IMMUNE;

[CyberDevil]

thank you a lot @SBK_ it's work!  +1

[KillerBEEs1984]

on latest rA git,

the src - patch works manually without error after compiling

and while using 2015-11-04 client

after pressing vend skill it freeze? anyone can help me regarding this matter

[Easycore]

On 6/27/2019 at 5:24 AM, Dissidia said:

It will work. Don't know why they add that. In the previous version there is no code like that.

I decided to limit extended vending only to unbound items.
You can see why I did this:

 

[Easycore]

New update for Extended Vending 2.0 (still pending approval):
   - Updated to GitHash: df6385
   - Fixed character stuck at cancel skill.
   - Fixed wrong skill failure.
   - Currency is saved properly when server is restarted.
   - Fixed compiling warning.

[dantoki]

On latest Git.

[Easycore]

4 hours ago, mharkeke said:

On latest Git.

Apply again the patch, you are missing lines in battle.hpp.

[dantoki]

i got this error when i apply the patch BGeAmod before Vending 2.0.