Easycore

Release: Extended Vending 2.0

Recommended Posts

4 hours ago, mharkeke said:

On latest Git.

Apply again the patch, you are missing lines in battle.hpp.

Share this post


Link to post
Share on other sites

i got this error when i apply the patch BGeAmod before Vending 2.0.

Share this post


Link to post
Share on other sites
3 hours ago, mharkeke said:

i got this error when i apply the patch BGeAmod before Vending 2.0.

Apply the patch manually, you are missing lines in battle.hpp.

Share this post


Link to post
Share on other sites

@Easycore how to change the color White Color and only appear on chat box and remove the msg on top

Share this post


Link to post
Share on other sites

I applied the patch manually without error but all my custom items cant be sold in the NPC. Its saying "Bound Items cannot be sold" even if the items is not bounded.

Share this post


Link to post
Share on other sites

+rep

Thank you for this release, I have the same spam warning as Bringer.

Share this post


Link to post
Share on other sites

I think its just an information for debug. If vend_loot / item is 0, it shouldnt open.
otherwise, you just can comment that part out?

@@ -7153,6 +7153,13 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
 
 	nullpo_retv(sd);
 
+	// Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+	// ShowWarning("vend loot = %d\n", sd->vend_loot);
+	if (battle_config.extended_vending && sd->vend_loot == 0) {
+		sd->state.prevend = 0;
+		return;
+	}

Not sure tho. Just wait for easycore to reply.

Edited by Mabuhay

Share this post


Link to post
Share on other sites
46 minutes ago, Mabuhay said:

I think its just an information for debug. If vend_loot / item is 0, it shouldnt open.
otherwise, you just can comment that part out?

@@ -7153,6 +7153,13 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
 
 	nullpo_retv(sd);
 
+	// Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+	// ShowWarning("vend loot = %d\n", sd->vend_loot);
+	if (battle_config.extended_vending && sd->vend_loot == 0) {
+		sd->state.prevend = 0;
+		return;
+	}

Not sure tho. Just wait for easycore to reply.

i check that part but on my offline server i cant get that debug msg but on my online server i get that

  • Love 1

Share this post


Link to post
Share on other sites
23 minutes ago, Bringer said:

i check that part but on my offline server i cant get that debug msg but on my online server i get that

Based on how I understand, its just a warning tho. And reading that part doesnt seem to harm the server in any ways.. May be used for debugging.. But for whatever reason that it is not working consistently on both of your servers, it is best answered by Easycore.

Share this post


Link to post
Share on other sites

 

Thanks for sharing Easycore, it was awesome! /no1

 

I have a problem, maybe I did something wrong

When the seller has 2kkk or 2kkk (Cash), the sale is made and completed! Shouldn't the buying player receive a message saying that the store owner has a maximum of Zeny or Cash? And so he could not buy.

I made a video to better exemplify. It is attached.

 

NOTE: Sorry English, I have no practice.

Spoiler

Obrigado por compartilhar Easycore, ficou incrível! /no1

estou com um problema, talvez eu tenha feito algo errado 

quando o vendedor está com 2kkk ou 2kkk (Cash), a venda é feita e concluída!  O jogador que está comprando não deveria receber uma mensagem, dizendo que o proprietário da loja está com o máximo de Zeny ou Cash? E assim ele não conseguiria comprar.

fiz um vídeo para exemplificar melhor.

 

OBS: Desculpe o ingles, eu não tenho prática.

 

Share this post


Link to post
Share on other sites

Hello rAthena,

I use the latest version of rAthena. Got this error when i Compile. How to fix it.

Thank you for your help.

vending_error.jpg

Share this post


Link to post
Share on other sites
On 11/26/2019 at 5:41 AM, Amauri Melo said:

When the seller has 2kkk or 2kkk (Cash), the sale is made and completed! Shouldn't the buying player receive a message saying that the store owner has a maximum of Zeny or Cash? And so he could not buy.

conf/battle/item.conf
vending_over_max: yes (set to no)

@Easycore Fix vend_requirements

+				for (k = 0; k < MAX_INVENTORY; k++) {
+					if (sd->inventory.u.items_inventory[k].bound) {
+						clif_displaymessage(sd->fd, "Cannot buy with Bound Items.");
+						return;
+					}
+					if (sd->inventory.u.items_inventory[k].nameid == vsd->vend_loot)
+						loot_count += sd->inventory.u.items_inventory[k].amount;
+				}

Current : it checks the whole inventory for bound items. but there's no condition if that item is the vsd->vend_loot. so if it found anything that is bound. it will return;

for (k = 0; k < MAX_INVENTORY; k++){
	if (sd->inventory.u.items_inventory[k].nameid == vsd->vend_loot)
		if ( sd->inventory.u.items_inventory[k].bound ){
			clif_displaymessage(sd->fd, "Cannot buy with Bound Items.");
			return;
		} else
			loot_count += sd->inventory.u.items_inventory[k].amount;
}

fix : maybe checking the vend_loot first and throw a second if condition bound would be good.

Edited by Haruka Mayumi
  • Upvote 1

Share this post


Link to post
Share on other sites
On 6/27/2019 at 3:27 PM, Dissidia said:

//if (sd->inventory.u.items_inventory[k].bound) {
                    //    clif_displaymessage(sd->fd, "Cannot buy with Bound Items.");
                    //    return;
                    //}

this will giving you exploit in bound items. better to change the Clip Display Message

 clif_displaymessage(sd->fd, "Cannot buy with Bound Items.");
To
 clif_displaymessage(sd->fd, "Please put your bound items on your storage and try again..");

or its up to you.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.