Release: Extended Vending 2.0

[Mister Noob]

On 8/23/2023 at 8:49 PM, Forshaken said:

can you please elaborate your problem?

I have attached screenshots. When clicking on cancel button (encircled in red) while in the currency tab, the vending will push through instead of getting canceled, resulting to Unknown Item as currency.

[Chaoszinho]

11 minutes ago, micosanityyy said:

I have attached screenshots. When clicking on cancel button (encircled in red) while in the currency tab, the vending will push through instead of getting canceled, resulting to Unknown Item as currency.

 Use this diff 

Extend Vending 1.7.0 (1).diff

[Forshaken]

6 hours ago, Chaoszinho said:

 Use this diff 

Extend Vending 1.7.0 (1).diff 38.5 kB · 0 downloads

I iuse the same mod on latest rev and after i click that cencel button, vend will not push thru and  it has a message mo "Skill faiked..

[JinYuichi]

5 hours ago, Forshaken said:

Utilizo el mismo mod en la última revolución y después de hacer clic en ese botón de cencel, vend no presionará y tiene un mensaje mo "Skill faiked..

it's obvious that the ability will fail if you give it cancel ._.

[AinsLord]

On 7/6/2023 at 8:06 PM, rongrong said:

Thx! i have fixed it.

int skill_vending(struct map_session_data *sd, t_itemid nameid) {
    std::shared_ptr<item_data> item;
    char output[1024];
    nullpo_ret(sd);

    if (!pc_can_give_items(sd) || (item = item_db.find(nameid)) == NULL) {  // it return -1 here but shows 4294967295

    if (!pc_can_give_items(sd) || !nameid || !item_db.exists(nameid)) {  // i fixed like this and it works well now

 

@Forshaken try this method

1.7.0 diff should fix ur problem try to get fresh src files then manually add those lines in diff file

[Forshaken]

On 8/25/2023 at 6:03 AM, JinYuichi said:

it's obvious that the ability will fail if you give it cancel ._.

yeah that is my point mine is working well.

[Forshaken]

On 8/25/2023 at 12:19 PM, AinsLord said:

@Forshaken try this method

1.7.0 diff should fix ur problem try to get fresh src files then manually add those lines in diff file

no problem with that mod thx @AinsLord for responding

[Pavianne]

updated rathena src

 

map crash when buying items on vending.

 

any fix?

[Harvin]

6 hours ago, marky1114 said:

updated rathena src

 

map crash when buying items on vending.

 

any fix?

try this patch. I has updated the code in some line

0001-Extended-Vending.patch

Edited September 9, 2023 by Harvin

[Ph34r]

Everything is working fine, only issue is when we cancel vending after using skill, it continues to open shop and opens it with [Unknown item] currency which doesnt work. Any Resolution to this problem?

 

- Fixed it using Extended Vending 1.7.0 (1) diff. Thanks!

 

 

Edited September 19, 2023 by Ph34r

[UncleBobby]

On 2/25/2019 at 6:38 PM, Kuroe said:

1 More problem.
When I sell an item using mithril coin it sells the item even the player doesn't have mithril coins and the seller doesn't even get anything

Edit:
Got it working. I just had to re-do from the top.

you did it fresh again to make it work? same issue as mine

 

[normansalimi90]

hello, is extended vending still working?
Im using latest rathena and ExtendedVending_[Rev9]

Can anyone help fix this error?

[dantoki]

On 7/6/2023 at 8:06 PM, rongrong said:

Thx! i have fixed it.

int skill_vending(struct map_session_data *sd, t_itemid nameid) {
    std::shared_ptr<item_data> item;
    char output[1024];
    nullpo_ret(sd);

    if (!pc_can_give_items(sd) || (item = item_db.find(nameid)) == NULL) {  // it return -1 here but shows 4294967295

    if (!pc_can_give_items(sd) || !nameid || !item_db.exists(nameid)) {  // i fixed like this and it works well now

 

Is there an update code for this? I test this on latest rA it cancels the vending when u press cancel but when u try to ok the map disconnects.

[Ruhn]

 

I got this error after compiling. Any fix for this?

[JinYuichi]

On 4/17/2024 at 6:50 PM, Ruhn said:

 

Recibí este error después de compilar. ¿Alguna solución para esto?

 

This diff works for the latest version of rathena | 19-04-2024

[ Extend Vending 3.0 ] Rev16.8 JinYuichi.diff

[hendra814]

On 9/9/2023 at 10:50 PM, Harvin said:

try this patch. I has updated the code in some line

0001-Extended-Vending.patch 30.79 kB · 91 downloads

not working using lastest rathena

 

On 4/19/2024 at 9:03 PM, JinYuichi said:

 

This diff works for the latest version of rathena | 19-04-2024

[ Extend Vending 3.0 ] Rev16.8 JinYuichi.diff 38.66 kB · 41 downloads

and this one too

[JinYuichi]

1 hour ago, hendra814 said:

not working using lastest rathena

 

and this one too

as the post says it works for the date I said, you will have to fix it by yourself for the current date 

[noblesse]

anyone has the working version for latest rathena?

[nobodyelse]

any update on this for latest rathena?

[solid2005]

I try my best to convert this one. I didn't test this yet. use at your own risk.

 

Extend Vending 10072024.diff

Edited October 6, 2024 by solid2005

[bellacalleb]

On 27/09/2024 at 13:43, solid2005 said:

Eu tento o meu melhor para converter este. Eu não testei isso ainda. use por sua conta e risco.

 

Estender Vending 10072024.diff 28,17 KB de dados · 6 downloads

I can apply this diff but for some reason when I try to open the store my char stays still and cannot use anything else or move, requiring me to disconnect and connect to the char again

neither an error nor a warning appears in mapserv

Could the problem be in my patch?

I don't think so since without applying diff the skill works normally

 

[AinsLord]

warnings regarding clif.cpp

conversion from 'size_t' to 'int16'

when use the skill cant move but can do @go @warp commands

Edited December 17, 2024 by AinsLord

[SpOOn]

On 10/11/2024 at 8:54 AM, bellacalleb said:

I can apply this diff but for some reason when I try to open the store my char stays still and cannot use anything else or move, requiring me to disconnect and connect to the char again

neither an error nor a warning appears in mapserv

Could the problem be in my patch?

I don't think so since without applying diff the skill works normally

 

I'm having the same problem here. 
Could someone help us?

[Dev KhayZia AZ]

@@ -7511,6 +7511,12 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
     int fd;
 
     nullpo_retv(sd);
+    
+    // Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+    if (battle_config.extended_vending && sd->vend_loot == 0) {
+        sd->state.prevend = 0;
+        return;
+    }
 
-->>  fd = sd->fd;
 ->>    WFIFOHEAD(fd,packet_len(0x12d));

 

who have the latest extend vending

[AinsLord]

On 1/10/2025 at 4:18 PM, Dev KhayZia AZ said:

@@ -7511,6 +7511,12 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
     int fd;
 
     nullpo_retv(sd);
+    
+    // Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+    if (battle_config.extended_vending && sd->vend_loot == 0) {
+        sd->state.prevend = 0;
+        return;
+    }
 
-->>  fd = sd->fd;
 ->>    WFIFOHEAD(fd,packet_len(0x12d));

 

who have the latest extend vending

is this a fix or anything please tell