Release: Extended Vending 2.0

[Easycore]

3 hours ago, mharkeke said:

i got this error when i apply the patch BGeAmod before Vending 2.0.

Apply the patch manually, you are missing lines in battle.hpp.

[Bringer]

@Easycore how to change the color White Color and only appear on chat box and remove the msg on top

[Art1x]

I applied the patch manually without error but all my custom items cant be sold in the NPC. Its saying "Bound Items cannot be sold" even if the items is not bounded.

[Bringer]

@Easycore how to fix this problem

[Sleezer]

+rep

Thank you for this release, I have the same spam warning as Bringer.

[Mabuhay]

I think its just an information for debug. If vend_loot / item is 0, it shouldnt open.
otherwise, you just can comment that part out?

@@ -7153,6 +7153,13 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
 
 	nullpo_retv(sd);
 
+	// Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+	// ShowWarning("vend loot = %d\n", sd->vend_loot);
+	if (battle_config.extended_vending && sd->vend_loot == 0) {
+		sd->state.prevend = 0;
+		return;
+	}

Not sure tho. Just wait for easycore to reply.

Edited November 25, 2019 by Mabuhay

[Bringer]

46 minutes ago, Mabuhay said:

I think its just an information for debug. If vend_loot / item is 0, it shouldnt open.
otherwise, you just can comment that part out?

@@ -7153,6 +7153,13 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
 
 	nullpo_retv(sd);
 
+	// Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+	// ShowWarning("vend loot = %d\n", sd->vend_loot);
+	if (battle_config.extended_vending && sd->vend_loot == 0) {
+		sd->state.prevend = 0;
+		return;
+	}

Not sure tho. Just wait for easycore to reply.

i check that part but on my offline server i cant get that debug msg but on my online server i get that

[Mabuhay]

23 minutes ago, Bringer said:

i check that part but on my offline server i cant get that debug msg but on my online server i get that

Based on how I understand, its just a warning tho. And reading that part doesnt seem to harm the server in any ways.. May be used for debugging.. But for whatever reason that it is not working consistently on both of your servers, it is best answered by Easycore.

[Amauri Melo]

 

Thanks for sharing Easycore, it was awesome!

 

I have a problem, maybe I did something wrong

When the seller has 2kkk or 2kkk (Cash), the sale is made and completed! Shouldn't the buying player receive a message saying that the store owner has a maximum of Zeny or Cash? And so he could not buy.

I made a video to better exemplify. It is attached.

 

NOTE: Sorry English, I have no practice.

Spoiler

Obrigado por compartilhar Easycore, ficou incrível!

estou com um problema, talvez eu tenha feito algo errado 

quando o vendedor está com 2kkk ou 2kkk (Cash), a venda é feita e concluída!  O jogador que está comprando não deveria receber uma mensagem, dizendo que o proprietário da loja está com o máximo de Zeny ou Cash? E assim ele não conseguiria comprar.

fiz um vídeo para exemplificar melhor.

 

OBS: Desculpe o ingles, eu não tenho prática.

 

[klitidej]

Hello rAthena,

I use the latest version of rAthena. Got this error when i Compile. How to fix it.

Thank you for your help.

[Haruka Mayumi]

On 11/26/2019 at 5:41 AM, Amauri Melo said:

When the seller has 2kkk or 2kkk (Cash), the sale is made and completed! Shouldn't the buying player receive a message saying that the store owner has a maximum of Zeny or Cash? And so he could not buy.

conf/battle/item.conf
vending_over_max: yes (set to no)

Edited March 18, 2021 by Haruka Mayumi

[Amauri Melo]

Thanks @Haruka Mayumi it worked!

 

[strikone33]

@edit resolvido

vending.cpp

Edited March 21, 2020 by strikone33

[Sanchita]

Hi guys, I'd like to know if someone could help me with the installation, I'm new here and I didn't learn how to use .diff files yet.

 

Thanks

[AinsLord]

will this still works on latest git of rathena??

[Gidz Cross]

1 hour ago, AinsLord said:

will this still works on latest git of rathena??

You are still here. Ive been back tracking from page 1 to here. And its a YES for your question. I have applied the patch manually.

I just want to ask whats this
 

 

On 11/25/2019 at 9:36 AM, Bringer said:

@Easycore how to fix this problem

Have you solved yours?


@Easycore hey bud. Thanks!

Edited April 21, 2020 by gidzdlcrz
typos

[Bringer]

12 hours ago, gidzdlcrz said:

You are still here. Ive been back tracking from page 1 to here. And its a YES for your question. I have applied the patch manually.

I just want to ask whats this
 

 

Have you solved yours?


@Easycore hey bud. Thanks!

just warning just ignore it

[Gidz Cross]

8 hours ago, Bringer said:

just warning just ignore it

I follow mabuhay's advice. to comment this part out. No more warning. 

 

On 11/25/2019 at 12:21 PM, Mabuhay said:

I think its just an information for debug. If vend_loot / item is 0, it shouldnt open.
otherwise, you just can comment that part out?

@@ -7153,6 +7153,13 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
 
 	nullpo_retv(sd);
 
+	// Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+	// ShowWarning("vend loot = %d\n", sd->vend_loot);
+	if (battle_config.extended_vending && sd->vend_loot == 0) {
+		sd->state.prevend = 0;
+		return;
+	}

Not sure tho. Just wait for easycore to reply.

This is the solution i guess.

[kenanjosss]

Hey guys,
I have a problem, I manually installed the diff and managed to compile without errors, however when I make the store and try to buy with another account it is simply not carried out.
I'm trying to put an option for zenny and cash.

obs: forgive the english, i'm using google translator

[Amauri Melo]

On 11/25/2019 at 1:21 AM, Mabuhay said:

I think its just an information for debug. If vend_loot / item is 0, it shouldnt open.
otherwise, you just can comment that part out?

@@ -7153,6 +7153,13 @@ void clif_openvendingreq(struct map_session_data* sd, int num)
 
 	nullpo_retv(sd);
 
+	// Vending shouldn't open if vend_loot is 0 and extended vending is enabled [Easycore]
+	// ShowWarning("vend loot = %d\n", sd->vend_loot);
+	if (battle_config.extended_vending && sd->vend_loot == 0) {
+		sd->state.prevend = 0;
+		return;
+	}

Not sure tho. Just wait for easycore to reply.

it worked for me!
Thanks

[NakedWolf]

am using the latest rAthena when using @reload battleconf i get this warning

[Haruka Mayumi]

On 5/12/2020 at 1:38 PM, NakedWolf said:

am using the latest rAthena when using @reload battleconf i get this warning

you probably forgot to add something from battle.cpp
item_cash is not declared.

[M a p l e]

Are you having a problem with this mod when using the client 2020 diff? https://github.com/rathena/rathena/pull/4944
Like, compiles here without errors. but when I click on the "Vending" skill, instead of Zeny or Cash, only 1 Apple appears.

Has anyone managed to fix the problem for new packets 2020?

 

[Akkarin]

Why didn't you just post in that thread instead of making a new one?

[M a p l e]

9 minutes ago, Akkarin said:

Why didn't you just post in that thread instead of making a new one?

Pardon. I didn't want to double post on the topic, because I thought it was against the rules, so I preferred to create a topic to ask for support for this.