Jump to content
Easycore

Release: Extended Vending 2.0

By Easycore, in Source Releases

Recommended Posts

M a p l e Santa Poring

M a p l e

Posted
Posted

Are you having a problem with this mod when using the client 2020 diff? https://github.com/rathena/rathena/pull/4944
Like, compiles here without errors. but when I click on the "Vending" skill, instead of Zeny or Cash, only 1 Apple appears.

Has anyone managed to fix the problem for new packets 2020?

 

Link to comment
Share on other sites
M a p l e Santa Poring

M a p l e

Posted
Posted
9 minutes ago, Akkarin said:

Why didn't you just post in that thread instead of making a new one?

Pardon. I didn't want to double post on the topic, because I thought it was against the rules, so I preferred to create a topic to ask for support for this.

Link to comment
Share on other sites
lzm Poring

lzm

Posted
Posted
On 5/24/2020 at 12:04 AM, M a p l e said:

Are you having a problem with this mod when using the client 2020 diff? https://github.com/rathena/rathena/pull/4944
Like, compiles here without errors. but when I click on the "Vending" skill, instead of Zeny or Cash, only 1 Apple appears.

Has anyone managed to fix the problem for new packets 2020?

 

Oh no.. I having this problem too.. The vending still working, but only can use 2 items as currency and shown as apple in 2020 client.

Link to comment
Share on other sites
juncker Poring

juncker

Posted
Posted
On 4/21/2020 at 3:04 PM, gidzdlcrz said:

You are still here. Ive been back tracking from page 1 to here. And its a YES for your question. I have applied the patch manually.

I just want to ask whats thisimage.png.dcbb5f0fbb9b0706f52962ef91a8f064.png
 

 

Have you solved yours?


@Easycore hey bud. Thanks! 🙂

It is not a error or problem, this is just a message to you know whats happening ... ( Debug message )
But if it really bother you, you just change the warning code message to status message like this
this: -> ShowWarning("vend loot = %d\n", sd->vend_loot);
to
this -> ShowStatus("vend loot = %d\n", sd->vend_loot);

Link to comment
Share on other sites
lzm Poring

lzm

Posted
Posted
On 5/24/2020 at 12:04 AM, M a p l e said:

Are you having a problem with this mod when using the client 2020 diff? https://github.com/rathena/rathena/pull/4944
Like, compiles here without errors. but when I click on the "Vending" skill, instead of Zeny or Cash, only 1 Apple appears.

Has anyone managed to fix the problem for new packets 2020?

Update.. I can confirm this after I update my rAthena.
Error at clif.cpp when compiling, something about 

skill_vending(sd,nameid);

Change (sd,nameid) to p->itemId will let the compiling finish but in game, only shows 1 apple when try to vending.

Link to comment
Share on other sites
M a p l e Santa Poring

M a p l e

Posted
Posted
10 hours ago, lzm said:

Update.. I can confirm this after I update my rAthena.
Error at clif.cpp when compiling, something about 

skill_vending(sd,nameid);

Change (sd,nameid) to p->itemId will let the compiling finish but in game, only shows 1 apple when try to vending.

Not work 

		case MC_VENDING:
			skill_vending(sd,p->itemId);
			break;

image.png.fe4f947cff645d6ea191596476c24eba.png

Link to comment
Share on other sites
lzm Poring

lzm

Posted
Posted
10 minutes ago, M a p l e said:

Not work

I just confirm what you report earlier after I update my rAthena, I got the same problem as you. Compiling with no error but in game, only shows 1 apple when try to vending.

Link to comment
Share on other sites
Boss Robs Poring

Boss Robs

Posted
Posted

YtCKI1o.png

Hi i would like to ask if someone have the solution to this ? after using the Vending Skill the list of currencies is just Unknown Item.. thanks in advance.

Link to comment
Share on other sites
M a p l e Santa Poring

M a p l e

Posted
Posted (edited)
42 minutes ago, BeWan said:

yes its working 100%.

it doesn't work, because when choosing the way to sell, Apple appears instead of the coins or item you added.

YtCKI1o.png

Edited by M a p l e
Link to comment
Share on other sites
BeWan Metaling

BeWan

Posted
Posted (edited)
15 hours ago, M a p l e said:

it doesn't work, because when choosing the way to sell, Apple appears instead of the coins or item you added.

YtCKI1o.png

i apply this diff yesterday to latest git file and its working 100%. dm me and send your error ill help you.

Edited by BeWan
Link to comment
Share on other sites
M a p l e Santa Poring

M a p l e

Posted
Posted
8 hours ago, BeWan said:

i apply this diff yesterday to latest git file and its working 100%. dm me and send your error ill help you. 

7> ------ Compilation started: Project: login-server, Configuration: Debug Win32 ------
8> ------ Compilation started: Project: char-server, Configuration: Debug Win32 ------
9> ------ Compilation started: Project: map-server, Configuration: Debug Win32 ------
8> char.cpp
7> account.cpp
9> achievement.cpp
9> atcommand.cpp
9> battle.cpp
9> battleground.cpp
9> buyingstore.cpp
9> cashshop.cpp
7> ipban.cpp
7> login.cpp
8> char_clif.cpp
7> loginchrif.cpp
7> loginclif.cpp
9> channel.cpp
8> char_cnslif.cpp
9> D: \ Ragnarok - Emulators \ rAthena \ src \ custom \ battle_config_init.inc (22,62): error C2065: 'MAX_ITEMID': undeclared identifier (compiling battle.cpp source file)
9> D: \ Ragnarok - Emulators \ rAthena \ src \ custom \ battle_config_init.inc (23,62): error C2065: 'MAX_ITEMID': undeclared identifier (compiling battle.cpp source file)
7> logincnslif.cpp
9> chat.cpp
9> chrif.cpp
9> clan.cpp
8> char_logif.cpp
7> loginlog.cpp
9> clif.cpp
7> Generating Code ...
8> char_mapif.cpp
9> date.cpp
9> duel.cpp
9> elemental.cpp
8> inter.cpp
9> guild.cpp
9> homunculus.cpp
9> instance.cpp
9> D: \ Ragnarok - Emulators \ rAthena \ src \ map \ clif.cpp (13057,22): error C2065: 'nameid': undeclared identifier
9> intif.cpp
8> int_achievement.cpp
9> itemdb.cpp
9> log.cpp
9> mail.cpp
8> int_auction.cpp
9> map.cpp
7> login-server.vcxproj -> D: \ Ragnarok - Emulators \ rAthena \ login-server.exe
9> mapreg.cpp
8> int_clan.cpp
9> mercenary.cpp
9> mob.cpp
9> npc.cpp
9> npc_chat.cpp
9> party.cpp
8> int_elemental.cpp
9> path.cpp
9> pc.cpp
9> pc_groups.cpp
8> int_guild.cpp
9> pet.cpp
9> quest.cpp
9> script.cpp
9> searchstore.cpp
8> int_homun.cpp
8> int_mail.cpp
9> skill.cpp
9> status.cpp
9> storage.cpp
9> trade.cpp
8> int_mercenary.cpp
9> unit.cpp
8> int_party.cpp
9> D: \ Ragnarok - Emulators \ rAthena \ src \ map \ skill.cpp (17622,32): error C2065: 'MAX_ITEMID': undeclared identifier
9> vending.cpp
8> int_pet.cpp
8> int_quest.cpp
9> Ready compilation project "map-server.vcxproj" - FAIL.
8> int_storage.cpp
8> Generating Code ...
8> char-server.vcxproj -> D: \ Ragnarok - Emulators \ rAthena \ char-server.exe
========== Compile: 8 successful, 1 failed, 0 updated, 0 ignored ==========

 

Link to comment
Share on other sites
BeWan Metaling

BeWan

Posted
Posted (edited)
47 minutes ago, M a p l e said: 
7> ------ Compilation started: Project: login-server, Configuration: Debug Win32 ------
8> ------ Compilation started: Project: char-server, Configuration: Debug Win32 ------
9> ------ Compilation started: Project: map-server, Configuration: Debug Win32 ------
8> char.cpp
7> account.cpp
9> achievement.cpp
9> atcommand.cpp
9> battle.cpp
9> battleground.cpp
9> buyingstore.cpp
9> cashshop.cpp
7> ipban.cpp
7> login.cpp
8> char_clif.cpp
7> loginchrif.cpp
7> loginclif.cpp
9> channel.cpp
8> char_cnslif.cpp
9> D: \ Ragnarok - Emulators \ rAthena \ src \ custom \ battle_config_init.inc (22,62): error C2065: 'MAX_ITEMID': undeclared identifier (compiling battle.cpp source file)
9> D: \ Ragnarok - Emulators \ rAthena \ src \ custom \ battle_config_init.inc (23,62): error C2065: 'MAX_ITEMID': undeclared identifier (compiling battle.cpp source file)
7> logincnslif.cpp
9> chat.cpp
9> chrif.cpp
9> clan.cpp
8> char_logif.cpp
7> loginlog.cpp
9> clif.cpp
7> Generating Code ...
8> char_mapif.cpp
9> date.cpp
9> duel.cpp
9> elemental.cpp
8> inter.cpp
9> guild.cpp
9> homunculus.cpp
9> instance.cpp
9> D: \ Ragnarok - Emulators \ rAthena \ src \ map \ clif.cpp (13057,22): error C2065: 'nameid': undeclared identifier
9> intif.cpp
8> int_achievement.cpp
9> itemdb.cpp
9> log.cpp
9> mail.cpp
8> int_auction.cpp
9> map.cpp
7> login-server.vcxproj -> D: \ Ragnarok - Emulators \ rAthena \ login-server.exe
9> mapreg.cpp
8> int_clan.cpp
9> mercenary.cpp
9> mob.cpp
9> npc.cpp
9> npc_chat.cpp
9> party.cpp
8> int_elemental.cpp
9> path.cpp
9> pc.cpp
9> pc_groups.cpp
8> int_guild.cpp
9> pet.cpp
9> quest.cpp
9> script.cpp
9> searchstore.cpp
8> int_homun.cpp
8> int_mail.cpp
9> skill.cpp
9> status.cpp
9> storage.cpp
9> trade.cpp
8> int_mercenary.cpp
9> unit.cpp
8> int_party.cpp
9> D: \ Ragnarok - Emulators \ rAthena \ src \ map \ skill.cpp (17622,32): error C2065: 'MAX_ITEMID': undeclared identifier
9> vending.cpp
8> int_pet.cpp
8> int_quest.cpp
9> Ready compilation project "map-server.vcxproj" - FAIL.
8> int_storage.cpp
8> Generating Code ...
8> char-server.vcxproj -> D: \ Ragnarok - Emulators \ rAthena \ char-server.exe
========== Compile: 8 successful, 1 failed, 0 updated, 0 ignored ==========

 

dont forget to declare max_itemid in battle.cpp or make it sure you follow all the instruction in b/conf/battle/feature.conf

Edited by BeWan
Link to comment
Share on other sites
M a p l e Santa Poring

M a p l e

Posted
Posted
5 minutes ago, BeWan said:

try MAX_ITEMID -> TBL_ITEM
and 
dont forget to declare max_itemid in battle.cpp

and clif.cpp?
9> 😧 \ Ragnarok - Emulators \ rAthena \ src \ map \ clif.cpp (13057,22): error C2065: 'nameid': undeclared identifier 

		case MC_VENDING:
			skill_vending(sd, nameid);
			break;

 

Link to comment
Share on other sites
BeWan Metaling

BeWan

Posted
Posted
18 minutes ago, M a p l e said:

and clif.cpp?
9> 😧 \ Ragnarok - Emulators \ rAthena \ src \ map \ clif.cpp (13057,22): error C2065: 'nameid': undeclared identifier 

		case MC_VENDING:
			skill_vending(sd, nameid);
			break;

 

try this.

case MC_VENDING:
            skill_vending(sd,p->itemId);
            break;

  • Upvote 1
Link to comment
Share on other sites
lzm Poring

lzm

Posted
Posted
4 hours ago, Chywoner said:

How do I add the item icons? Since I don't take cash or zeny

Did yours working? Mine still unknown item.

Link to comment
Share on other sites
BeWan Metaling

BeWan

Posted
Posted
9 hours ago, Chywoner said:

How do I add the item icons? Since I don't take cash or zeny

db / item_vending.txt

about the item icon or sprite. go to iteminfo.lua or lub

  • Upvote 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
Go to topic listing
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use and Privacy Policy.

  I accept