Popular Post Easycore Posted July 10, 2018 Popular Post Share Posted July 10, 2018 View File Extended Vending 2.0 Extended Vending 2.0 Made in Git Hash: '042b88623bf549b88ba619991aaa186d45f7f998' Description Yet another version of Extended Vending, this one works in actual rA c++. It has a few fixes, including vending tax only working with Zeny as currency. What is new? I tried to improve this amazing mod adding a new feature: Vending Report (Mailbox). Basically... whenever you buy items to a vendor, he receive a report that who bough,what items, how many and total profit of them. You can disable this feature through conf/feature, or If you want to disable it for a specific player you must set the permanent variable called NOVREPORT (by a NPC/Bindatcmd/Idk) For < 2015-05-13 Clients Since old mailbox has 300 characters less than RoDex, I decided to take off items name and amount. So only will send 'who bought' and 'total profit'. Feel free to Donate If you want to support me. Submitter Easycore Submitted 07/10/2018 Category Source Modifications Video Content Author Lilith, Easycore 10 2 3 1 Quote Link to comment Share on other sites More sharing options...
JaranSwitch0101 Posted July 11, 2018 Share Posted July 11, 2018 Can you make video used this system? Quote Link to comment Share on other sites More sharing options...
Easycore Posted July 11, 2018 Author Share Posted July 11, 2018 1 hour ago, JaranSwitch0101 said: Can you make video used this system? https://www.youtube.com/results?search_query=extended+vending+ro First two. Quote Link to comment Share on other sites More sharing options...
Secrets Posted July 11, 2018 Share Posted July 11, 2018 Why 2 separate files for two platforms? O_O Quote Link to comment Share on other sites More sharing options...
A3gir Posted July 11, 2018 Share Posted July 11, 2018 Thank you very much for this release ! Quote Link to comment Share on other sites More sharing options...
spinzaku Posted July 11, 2018 Share Posted July 11, 2018 (edited) Awesome job! Thank you for sharing this. Btw there's a minor bug -> How do you fix the mailing name? it gives null name.. string name invalid? Also the 30000 for zeny and 30001 for cash is just placeholder? so just uses the zeny icon or something? When people select zeny, they actually use the zeny currency right? not the zeny item (30000?) same goes with cash point ? Edited July 11, 2018 by spinzaku Quote Link to comment Share on other sites More sharing options...
Easycore Posted July 11, 2018 Author Share Posted July 11, 2018 11 hours ago, Secrets said: Why 2 separate files for two platforms? O_O Because the line feed when sends a mail (\r\n and \n) Honestly I don't know If \r\n works equal for Linux, so I only used \n in it. Quote Link to comment Share on other sites More sharing options...
Easycore Posted July 11, 2018 Author Share Posted July 11, 2018 3 hours ago, spinzaku said: Btw there's a minor bug -> How do you fix the mailing name? it gives null name.. string name invalid? What do you mean exactly with 'mailing name'? 3 hours ago, spinzaku said: When people select zeny, they actually use the zeny currency right? not the zeny item (30000?) same goes with cash point ? You're right, they're only for show an Icon. Quote Link to comment Share on other sites More sharing options...
sikiro Posted July 12, 2018 Share Posted July 12, 2018 two bugs or maybe just one. after if you launch the vending skill and decide not to do anything and hit cancel your character will freeze in place and will not move until you re-log. and the other is cash and zeny showing as unkown items but that just may be me not allowing the client to read up to 30k items. Quote Link to comment Share on other sites More sharing options...
AinsLord Posted July 12, 2018 Share Posted July 12, 2018 will this work on 20151104 clients??? Quote Link to comment Share on other sites More sharing options...
Easycore Posted July 12, 2018 Author Share Posted July 12, 2018 1 hour ago, AinsLord said: will this work on 20151104 clients??? Yes, just ensure that your emulator is update. Quote Link to comment Share on other sites More sharing options...
Easycore Posted July 12, 2018 Author Share Posted July 12, 2018 19 hours ago, sikiro said: two bugs or maybe just one. after if you launch the vending skill and decide not to do anything and hit cancel your character will freeze in place and will not move until you re-log. and the other is cash and zeny showing as unkown items but that just may be me not allowing the client to read up to 30k items. I'll check about the skill. Quote Link to comment Share on other sites More sharing options...
Litro Endemic Posted July 13, 2018 Share Posted July 13, 2018 On 7/12/2018 at 11:23 AM, sikiro said: two bugs or maybe just one. after if you launch the vending skill and decide not to do anything and hit cancel your character will freeze in place and will not move until you re-log. and the other is cash and zeny showing as unkown items but that just may be me not allowing the client to read up to 30k items. i have compared this diff and old diff there is structure line change on skill.cpp, i dont really understand why but i have changed line from this diff with old one and its work as intended now Quote Link to comment Share on other sites More sharing options...
Easycore Posted August 7, 2018 Author Share Posted August 7, 2018 - Updated to Git Hash: 11b255e - Added Bound Items check Quote Link to comment Share on other sites More sharing options...
Lord Turtle Posted August 9, 2018 Share Posted August 9, 2018 is autotrade compatible with this feature? Quote Link to comment Share on other sites More sharing options...
sikiro Posted August 14, 2018 Share Posted August 14, 2018 @tribal0306 yes it should work the same as normal autotrade vending. Quote Link to comment Share on other sites More sharing options...
Lord Turtle Posted August 14, 2018 Share Posted August 14, 2018 vending.cpp(384): warning C4244: '-=': conversion from 'double' to 'int', possible loss of data Should i ignore this warning? On 7/13/2018 at 7:12 PM, Litro Endemic said: i have compared this diff and old diff there is structure line change on skill.cpp, i dont really understand why but i have changed line from this diff with old one and its work as intended now Hello what exactly did you changed? can i see it On 7/10/2018 at 8:21 PM, Easycore said: View File Extended Vending 2.0 Extended Vending 2.0 Made in Git Hash: '042b88623bf549b88ba619991aaa186d45f7f998' Description Yet another version of Extended Vending, this one works in actual rA c++. It has a few fixes, including vending tax only working with Zeny as currency. What is new? I tried to improve this amazing mod adding a new feature: Vending Report (Mailbox). Basically... whenever you buy items to a vendor, he receive a report that who bough,what items, how many and total profit of them. You can disable this feature through conf/feature, or If you want to disable it for a specific player you must set the permanent variable called NOVREPORT (by a NPC/Bindatcmd/Idk) For < 2015-05-13 Clients Since old mailbox has 300 characters less than RoDex, I decided to take off items name and amount. So only will send 'who bought' and 'total profit'. Feel free to Donate If you want to support me. Submitter Easycore Submitted 07/10/2018 Category Source Modifications Video Content Author Lilith, Easycore Hello sir, using the latest revision of rathena [d17ddf4] i am experiencing a 2 different bugs which: 1. when there is an autotrade and i restart the server, the autotrade wont include on the restart 2. sometimes the autotrade vendors is included when i restart on the server but when i buy their items it wont consume anything. even if its specified that the currency is pods Quote Link to comment Share on other sites More sharing options...
NakedWolf Posted September 23, 2018 Share Posted September 23, 2018 @Easycore after if you launch the vending skill and decide not to do anything and hit cancel your character will freeze in place and will not move until you re-log. how to fix this. Quote Link to comment Share on other sites More sharing options...
iubantot Posted September 24, 2018 Share Posted September 24, 2018 @Easycore , Im having these error Quote Link to comment Share on other sites More sharing options...
NakedWolf Posted September 26, 2018 Share Posted September 26, 2018 On 9/23/2018 at 11:41 AM, NakedWolf said: @Easycore after if you launch the vending skill and decide not to do anything and hit cancel your character will freeze in place and will not move until you re-log. how to fix this. bump Quote Link to comment Share on other sites More sharing options...
Easycore Posted October 1, 2018 Author Share Posted October 1, 2018 On 9/23/2018 at 3:11 AM, NakedWolf said: @Easycore after if you launch the vending skill and decide not to do anything and hit cancel your character will freeze in place and will not move until you re-log. how to fix this. Fixed. On 9/24/2018 at 4:32 AM, iubantot said: @Easycore , Im having these error You forgot to increase #define MAP_MAX_MSG to 1600. 1 Quote Link to comment Share on other sites More sharing options...
iubantot Posted October 1, 2018 Share Posted October 1, 2018 May i ask what files are changed on the fix for the vend stuck? i fixed my error already thanks! 1 hour ago, Easycore said: Fixed. You forgot to increase #define MAP_MAX_MSG to 1600. Quote Link to comment Share on other sites More sharing options...
NakedWolf Posted October 2, 2018 Share Posted October 2, 2018 18 hours ago, Easycore said: @Easycore after if you launch the vending skill and decide not to do anything and hit cancel your character will freeze in place and will not move until you re-log. how to fix this. Thank you so much and its working perfectly the stuck after canceling skill working fine with out any errors. Quote Link to comment Share on other sites More sharing options...
Keitenai Posted October 5, 2018 Share Posted October 5, 2018 On 8/15/2018 at 6:20 AM, tribal0306 said: vending.cpp(384): warning C4244: '-=': conversion from 'double' to 'int', possible loss of data Should i ignore this warning? in vending.cpp find this code: sprintf(message + strlen(message), "Total profit: %s x %d", "Zeny" ,(mailprofit -= mailprofit * (battle_config.vending_tax / 10000.))); change it to this: sprintf(message + strlen(message), "Total profit: %s x %d", "Zeny" ,(mailprofit -= mailprofit * (int)(battle_config.vending_tax / 10000.))); is my solution correct @Easycore ? Quote Link to comment Share on other sites More sharing options...
NakedWolf Posted October 5, 2018 Share Posted October 5, 2018 check if you are using the latest rAthena and also check all your codes if you have pasted it coz i just added them they compile with out any error Quote Link to comment Share on other sites More sharing options...
