Jump to content

Quests, Games: (Bug Fixed) Fishing Simulation System (Timing Fishing + Sound Included)

yuchinin
 Share

Recommended Posts

yuchinin Poring

yuchinin

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  120
  • Reputation:   48
  • Joined:  07/23/13
  • Last Seen:  
Posted
(Bug Fixed) Fishing Simulation System (Timing Fishing + Sound Included)

View File

(Bug Fixed) Fishing Simulation System (Timing Fishing + Sound Included)

[NOTE] For now on I will keep release all of my work for free , I hope most people can enjoy my script without paid. But if you still want to support my work, please consider donate or become my patron. Thank you.

 

Tired of boring odd base fishing game which just click and wait for the reward?
Then maybe you will need this simulate fishing game. Idea from a Japanese Video Game.
The Legend of Heroes VI: Sora no Kiseki


Feature:

  • Easy add / modify / remove local database
  • Not bound to npc when fishing, that mean you can walk freely, but there are timeout there.
  • Everyone can look and hear how you fish
  • Sound Effect included
  • Easy setup and configure each fishing spot
  • Can easily duplicate the npc and will not conflict to each other

Global Rod / Bait / Fish Database Example:

Spoiler

setarray $@rod_data$, "25031|0|0",
      "25032|25|75",
      "25033|75|25"; // rod data "<rod id>|<indicator slow bonus>|<variation reduce>"
      // $@rod_data$ value suggestion "<itemid>|<0~∞%>|<0~100%>"
setarray $@bait_data$, "501|500|20",
      "502|600|15",
      "503|750|15",
      "504|500|20",
      "505|400|25",
      "506|500|60";  // bait data "<bait id>|<delay before run>|<timeout>"
      // $@bait_data$ value suggestion "<itemid>|<500~1000>|<10~60>"
setarray $@fish_data$,"Junk|500|0|junkitem|713:909:914:915",
      "Fish|100|50|getfish|6049:6771:6774:6778:6779:6780:6096",
      "Bass|100|70|getitem|501:502:503",
      "Fish Monster|75|100|mob|1070:1073",
      "Strouf|75|120|mob|1065",
      "Marina|75|120|mob|1141",
      "Mermaid|100|80|useskill|28:34|2184",
      "Evil Mermaid|100|80|useskill|86:184|2184",
      "MVP Monster|-50|300|mob|2202:2319",
      "Frog|100|40|mob|2678:2679",
      "Shark",
      "Mackerel",
      "Thief Fish|100|70|delitem|501:502:503";  // fish data "<fish name>|<fish speed>|<variation>|<mode>|<mode data>|<additional data>"
      // $@fish_data$ value suggestion "<fish name>|<0~500>|<10~500>|<getitem/delitem/useskill/mob>|<itemid/mobid>|<use by mob mode only>"

Each Spot Npc Example:

Spoiler
izlude,110,67,0 script Test Spot::FISHTEST 723,{
Fishing_Start_Func(".rod_list",".bait_list");
end;
OnSuccess:
 emotion E_LOUD,1;
 showscript "I got it!",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
 specialeffect 6;
 soundeffectall "fish_reel03.wav",0;
 
 Fish_Reward_Func();
 Fishing_End_Func();
 
OnHit:
 emotion E_SWT2;
 emotion E_SWT2,1;
 specialeffect 4;
 soundeffectall "fish_reel02.wav",0;
 //setVariable(".timeout"+strnpcinfo(3),getVariable(".timeout"+strnpcinfo(3))+1); // add 1 more sec on each successful hook
 end;
 
// Event without player attach =================================================================================
OnCharacterGone:
 Fishing_End_Func();
OnWrongTiming:
 emotion E_HMM,1,getVariable(".charname"+strnpcinfo(3)+"$");
 showscript "I shouldn't pull at this situation...",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
 specialeffect 5;
 Fishing_End_Func();
OnTimeOut:
 emotion E_HMM,1,getVariable(".charname"+strnpcinfo(3)+"$");
 showscript "The bait is gone...",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
 specialeffect 5;
 Fishing_End_Func();
OnRodGone:
 emotion E_OMG,1,getVariable(".charname"+strnpcinfo(3)+"$");
 showscript "Where is my rod?",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
 specialeffect 5;
 Fishing_End_Func();
OnFail:
 soundeffectall "fish_reel01.wav",0;
 emotion E_SWT,1,getVariable(".charname"+strnpcinfo(3)+"$");
 showscript "I lost it...",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
 specialeffect 5;
 Fishing_End_Func();
OnInit:
// =========================< Rod & Bait Effect >========================================================================
setarray .rod_list,25031,25032,25033;   // rod allow to use  (Copy from $@rod_data$)
setarray .bait_list,504,505,506;    // bait consume id  (Copy from $@bait_data$)
setarray .fish_list$,"Mermaid|10000|5|120";//,"Bass|10000|5|120";    // fish list in this npc (Copy from $@fish_data$) string as id
// ======================================================================================================================
Fish_Spot_Initialize();
callfunc("EF_Bubble");
}

This script need my release of:

Spoiler
  1. Yuchinin Common Library (common.txt)

If you bought this script and need help on setting the npc, feel free to pm me on rAthena mailbox.

Suggestion are welcome.

Upcoming List:

  • Leaderboard
  • Fishing Contest
  • Private Pond & Public Pond

By downloading this script, you agree to these terms:

  • You are not allowed to redistribute this script in any way, shape, or form.
  • Chargeback scams are not tolerated and will get you punished on rAthena.
  • I still retain all rights to this script and sound.
  • Terms above may be changed or adjusted without prior notification.

Copyright © - Yuchinin 2017 - All Rights Reserved

 

  • Upvote 1
Link to comment
Share on other sites
spangler Poring

spangler

Posted
  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  7
  • Reputation:   0
  • Joined:  02/24/17
  • Last Seen:  
Posted

Will you expand this fishing system more in the future ?

I would like to see more of it such as leveling as you get more fish, fishing rank ladder, Rare fish (despite the sprite etc) in certain spot, as well as getting further prize, just like world of fishing made by scripter in the past.

Link to comment
Share on other sites
yuchinin Poring

yuchinin

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  120
  • Reputation:   48
  • Joined:  07/23/13
  • Last Seen:  
  • Author
Posted (edited)

Sure it is open to be expand. But I will expand it when there is really need.


In this fishing game, the "success rate" are mostly base on player not character in game, since the success rate are base on timing click.
If you got good timing skill(I mean in real), plus some of the luck (your connection speed to server), you will get it fish on. Not mainly base on variable in game. The only one can make you more easily on fishing are different of rod and bait, you may set up different rod and bait with it's data into global database.

*I will add the fishing rank ladder into todo list


Actually now it can already set different Fish in different npc, if you need more spot just duplicate the npc and it will have same fish db but still have own instance. Here are some more info.

Fish Global Database: (Add or change the fish database here to your like since these few are just some demotrate fish)

Spoiler

"Fish Monster|75|mob|1070:1073",
      "Strouf|75|mob|1065",
      "Marina|75|mob|1141",
      "Mermaid|100|useskill|28:34|2184",
      "Evil Mermaid|100|useskill|86:184|2184",
      "MVP Monster|-50|mob|2202:2319",
      "Frog|100|mob|2678:2679",
      "Shark",
      "Mackerel",
      "Thief Fish|100|delitem|501:502:503";

Spot Setting:

Spoiler

OnInit:
// =========================< Rod & Bait Effect >========================================================================
setarray .rod_list,25031,25032,25033;   // rod allow to use  (Copy from $@rod_data$)
setarray .bait_list,501,502,503;    // bait consume id  (Copy from $@bait_data$)
setarray .fish_list$,"Evil Mermaid","Thief Fish","Mermaid","Strouf","Bass","Marina","Fish Monster";    // fish list in this npc (Copy from $@fish_data$) string as id
// =========================< Other Config >==========================================================================
.hide_rate = 0;      // hide rate on each fishing
.delayfail = 2000;      // hide delay time when fail
.delaysuccess = 5000;     // hide delay time when success
.line_break_rate = 0;     // fish line breaking rate on wrong click timing instead of increasing the indicator index, 0 mean line never break
.variation = 0;      // variation on the indicator, you may turn it off if too hard to you

Different spot can have difference fish in it. Let say if you want to have a simple spot which have some easy catch fish, then just add the fish data to the Fish Global Database. (Example: "Bass|100|getitem|501:502:503")

In this example when you fish on Bass, the bass has speed of 100 which will determine the indicator speed. This fish mode is [getitem] so it will give you one of this potion (Red Potion, Orange Potion, Yellow Potion)

If you want A spot to have Bass, just add the string "Bass" into the A spot .fish_list$  local array. (Example" setarray .fish_list$,"Bass";)

Mode currently support: (Will add more mode in the future)

  • [getitem] (item giving fish)
  • [delitem] (item stoler)
  • [useskill] (The hooked on fish will use random skill define in this fish database and cast it on fisher)
  • [mob] (the hook on fish will get summon on fisher spot) (Optional: If you have my Monster Controller script installed the summoned mob will always be aggressive)

Buff Fish Example:

Spoiler

("Mermaid|100|useskill|28:34|2184") The fish name will be "Mermaid", indicator speed of 100, mode [useskill], last index 2184 are sprite id which will use on the monster

Currently setting which can set on different spot are:

  • .rod_list (rod id which can be use in this spot)
  • .bait_list (bait id which can be use in this spot)
  • .fish_list$ (fish which will appear in this spot) [Note: Use the Fish String in $@fish_data$ to put it here]

About the Other Config, I believe it not hard to understand, but if you need more clear on what it do, I will try to explain it more here:

  • .hide_rate (The rate which the spot will get hide after each fishing)
  • .delayfail (Set hide time on fail fishing)
  • .delaysuccess (Set hide time on success fishing)
  • .line_break_rate (I believe the description behide the variable already make it clear enough@@)
  • .variation (If you increase this value, the indicator on fishing will be more randomize which will surely make it more harder to fish)

Hope this will let you understand more. Feel free to ask if you got more question.
Suggestion and idea are welcome.;)

Edited by yuchinin
Add more description
Link to comment
Share on other sites
  • 3 months later...
Badarosk0 Poring

Badarosk0

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  81
  • Reputation:   5
  • Joined:  02/07/12
  • Last Seen:  
Posted

 

Hi, I'm having trouble running the event. When I click on the Spot Test nothing happens and I get the following error:

[Debug]: script debug : 0 110150052 : Monster Controller: Not Found
[Debug]: script debug : 0 110150481 : Monster Controller: Not Found
[Info]: npc_parse_function: Overwriting user function [arrfind_fishdb] (npc/realro/eventos/disguise.txt:588)
[Info]: npc_parse_function: Overwriting user function [arrget_fishdb] (npc/realro/eventos/disguise.txt:598)

Link to comment
Share on other sites
yuchinin Poring

yuchinin

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  120
  • Reputation:   48
  • Joined:  07/23/13
  • Last Seen:  
  • Author
Posted
2 minutes ago, Badarosk0 said:

 

Hi, I'm having trouble running the event. When I click on the Spot Test nothing happens and I get the following error:

[Debug]: script debug : 0 110150052 : Monster Controller: Not Found
[Debug]: script debug : 0 110150481 : Monster Controller: Not Found
[Info]: npc_parse_function: Overwriting user function [arrfind_fishdb] (npc/realro/eventos/disguise.txt:588)
[Info]: npc_parse_function: Overwriting user function [arrget_fishdb] (npc/realro/eventos/disguise.txt:598)

New version uploaded. Pending for approval.
//= 1.2.2 Remove function (arrfind_fishdb , arrfind_fishdb)
//=       Change function name (arrfind_fishdb > arrfind_db, arrget_fishdb > arrget_db)
//=       Remove function name arrfind_db and arrget_fishdb and added it to common library
//= 1.2.2a Add a hard fish example

Link to comment
Share on other sites
Badarosk0 Poring

Badarosk0

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  81
  • Reputation:   5
  • Joined:  02/07/12
  • Last Seen:  
Posted (edited)
On 04/08/2017 at 3:27 AM, yuchinin said:

New version uploaded. Pending for approval.
//= 1.2.2 Remove function (arrfind_fishdb , arrfind_fishdb)
//=       Change function name (arrfind_fishdb > arrfind_db, arrget_fishdb > arrget_db)
//=       Remove function name arrfind_db and arrget_fishdb and added it to common library
//= 1.2.2a Add a hard fish example

A very good, I am waiting for the new version to be approved. Very good event! Thank you!

EDIT: Hello, I'm trying to use your fishing event, however it's not working. Clicking on the Spot Test does not happen. I'm using the new version. Does the setVariable and getVariable functions exist in rAthena?

 

Resolved when I did this:
        //if(is_function("aimode")){
        //    aimode(.@gid,"aggro");
        //}

Edited by Badarosk0
Link to comment
Share on other sites
  • 3 months later...
Haikenz Poring

Haikenz

Posted
  • Group:  Members
  • Topic Count:  84
  • Topics Per Day:  0.02
  • Content Count:  309
  • Reputation:   82
  • Joined:  11/15/11
  • Last Seen:  
Posted

@yuchinin

Error version 1.2.2b

https://pastebin.com/hE7bdeFd

Link to comment
Share on other sites
yuchinin Poring

yuchinin

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  120
  • Reputation:   48
  • Joined:  07/23/13
  • Last Seen:  
  • Author
Posted
1 hour ago, Windows XP said:

@yuchinin

Error version 1.2.2b

https://pastebin.com/hE7bdeFd

//=====******** Note ********=================================
//= This script need my release of:
//= 1. Yuchinin Common Library (common.txt)
//= Better let it load first before adding my other script.

Link to comment
Share on other sites
Haikenz Poring

Haikenz

Posted
  • Group:  Members
  • Topic Count:  84
  • Topics Per Day:  0.02
  • Content Count:  309
  • Reputation:   82
  • Joined:  11/15/11
  • Last Seen:  
Posted (edited)
4 hours ago, yuchinin said:

//=====******** Note ********=================================
//= This script need my release of:
//= 1. Yuchinin Common Library (common.txt)
//= Better let it load first before adding my other script. 

// ------------------ Global Scripts Functions ------------------
// Utilitarian functions used by many scripts.
npc: npc/other/Global_Functions.txt
npc: npc/other/common.txt // Your Script
[Error]:  Loading NPC file: npc/custom/pesca.txt
script error on npc/custom/pesca.txt line 126
    parse_callfunc: expected ')' to close argument list
   121 :                specialeffect 6;
   122 :                soundeffectall "fish_start01.wav",0;
   123 :                do{
   124 :                        // track item
   125 :                        if(getVariable(".charname"+.@npc$+"$") != ""){
*  126 :                                if(attachrid(getcharid2'('3,getVariable(".charname"+.@npc$+"$")))){
   127 :                                        if(countitem(getVariable(".trackitem"+.@npc$))<1){
   128 :                                                Local_Fish_Val_Set(getVariable(".fish"+.@npc$+"$"),".fish_amt",1);
   129 :                                                if($@Fishing_Debug) debugmes "OnRodGone";
   130 :                                                donpcevent strnpcinfo(3)+"::OnRodGone";
   131 :                                                end;
[Error]:
script error on npc/custom/pesca.txt line 309
    script:add_word: invalid word. A word consists of undercores and/or alphanumeric characters, and valid variable prefixes/postfixes.
   304 :        .@mstr$ = "Leave:";
   305 :        for(.@x=0;.@x<getarraysize(getVariable(.@arrvarname$));.@x++){
   306 :                .@temp$ = .@arrvarname$+"["+.@x+"]";
   307 :                .@optional$ = "";
   308 :                if(.@arrvarname$==".rod_list"){
*  309 :                        .@index = arrfind_db('"'$@rod_data$",getVariable(.@temp$));
   310 :                        .@indicator_slow_bonus = atoi(arrget_db("$@rod_data$",.@index,1));
   311 :                        .@variation_reduce = atoi(arrget_db("$@rod_data$",.@index,2));
   312 :                        .@optional$ = " [-"+.@indicator_slow_bonus+"% Spd] [-"+.@variation_reduce+"% variation]";
   313 :                }else if(.@arrvarname$==".bait_list"){
   314 :                        .@index = arrfind_db("$@bait_data$",getVariable(.@temp$));
[Error]:
script error on npc/custom/pesca.txt line 373
    parse_line: expect command, missing function name or calling undeclared function
   368 :        .@arrname1$ = getarg(0);
   369 :        .@arrname2$ = getarg(1);
   370 :
   371 :        if( getVariable(".status"+.@npc$) == 0 && @bindspot$ == "" ){
   372 :                mes "[ "+CStr(strnpcinfo(0),"RED")+" ]";
*  373 :                .@rod = Fishing_Item_Check_Func('.'@arrname1$,"Select a rod");
   374 :                if(!.@rod || getVariable(".status"+.@npc$)!= 0){
   375 :                        mes "You don't have the selected item or someone is using this spot, please try again later.";
   376 :                        end;
   377 :                }
   378 :                mes "Selected "+Itemlink(.@rod);
[Error]:
script error on npc/custom/pesca.txt line 427
    parse_line: expect command, missing function name or calling undeclared function
   422 : {
   423 :        //.@sleepduration = getarg(0);
   424 :        .@npc$ = strnpcinfo(3);
   425 :        delwaitingroom .@npc$;
   426 :        .@name$ = getVariable(".charname"+.@npc$+"$");
*  427 :        .@aid = getcharid2('3',.@name$);
   428 :        .@charid = getcharid2(0,.@name$);
   429 :        if(isloggedin(.@aid,.@charid)){
   430 :                setd "@bindspot$","",getcharid2(0,getVariable(".charname"+.@npc$+"$"));
   431 :        }
   432 :        setVariable(".fish"+.@npc$+"$","");
[Error]:
script error on npc/custom/pesca.txt line 449
    parse_line: expect command, missing function name or calling undeclared function
   447 : {
   448 :        sleep2 1000;
*  449 :        if(!playerattached()) 'F'ishing_End_Func();     // add check to counter unexpected player not attach (server reload/disconnect/logout)
   450 :        showscript "It's a "+getVariable(".fish"+strnpcinfo(3)+"$")+"!",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
   451 :        sleep2 1000;
   452 :        if(!playerattached()) Fishing_End_Func();       // add check to counter unexpected player not attach (server reload/disconnect/logout)
   453 :        .@fish$ = getVariable(".fish"+strnpcinfo(3)+"$");
   454 :        .@fish_index = arrfind_db("$@fish_data$",.@fish$);
[Error]:
script error on npc/custom/pesca.txt line 567
    parse_line: expect command, missing function name or calling undeclared function
   566 : {
*  567 : 'F'ishing_Start_Func(".rod_list",".bait_list");
   568 : end;
   569 :
   570 : OnSuccess:
   571 :        emotion ET_BLABLA,getcharid(3,getVariable(".charname"+strnpcinfo(3)+"$"));
   572 :        showscript "I got it!",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
[Info]: Done loading '15175' NPCs:
        -'3575' Warps
        -'257' Shops
        -'11343' Scripts
        -'3400' Spawn sets
        -'50035' Mobs Cached
        -'0' Mobs Not Cached
[Debug]: script debug : 0 110000000 : table name [ custom_inventory ] installed!

@Edit SOLVED!

I was using the common version of your GIT because it is very old there.

Edited by Windows XP
  • Upvote 1
Link to comment
Share on other sites
  • 2 months later...
Strand Poring

Strand

Posted
  • Group:  Members
  • Topic Count:  39
  • Topics Per Day:  0.01
  • Content Count:  102
  • Reputation:   2
  • Joined:  07/01/13
  • Last Seen:  
Posted

Hello guys,

I get an error when I try to fish anything: 

[Error]: script_rid2sd: fatal error ! player not attached!
[Debug]: Function: emotion (1 parameter):
[Debug]: Data: variable name='ET_THINK' index=0
[Debug]: Source (NPC): Test Spot at izlude (127,60)
[Warning]: script:get_val: cannot access player variable 'ET_THINK', defaulting to 0

Any ideas why is it showing up and how to fix it?

Thanks for your time.

Link to comment
Share on other sites
yuchinin Poring

yuchinin

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  120
  • Reputation:   48
  • Joined:  07/23/13
  • Last Seen:  
  • Author
Posted
On 2/23/2018 at 12:02 PM, GMHelios said:

Hello guys,

I get an error when I try to fish anything: 


[Error]: script_rid2sd: fatal error ! player not attached!
[Debug]: Function: emotion (1 parameter):
[Debug]: Data: variable name='ET_THINK' index=0
[Debug]: Source (NPC): Test Spot at izlude (127,60)
[Warning]: script:get_val: cannot access player variable 'ET_THINK', defaulting to 0

Any ideas why is it showing up and how to fix it?

Thanks for your time.

Update your rAthena to latest to fix it

Link to comment
Share on other sites
  • 3 months later...
arby89 Poring

arby89

Posted
  • Group:  Members
  • Topic Count:  4
  • Topics Per Day:  0.00
  • Content Count:  14
  • Reputation:   1
  • Joined:  04/20/16
  • Last Seen:  
Posted (edited)

Thank you for this awesome fishing script. 


 

 

Edited by arby89
somehow it work after restart server
  • Like 1
Link to comment
Share on other sites
  • 1 month later...
Attitude Poring

Attitude

Posted
  • Group:  Members
  • Topic Count:  0
  • Topics Per Day:  0
  • Content Count:  1
  • Reputation:   0
  • Joined:  06/24/18
  • Last Seen:  
Posted
On 11/28/2017 at 9:45 AM, Haikenz said: 

// ------------------ Global Scripts Functions ------------------
// Utilitarian functions used by many scripts.
npc: npc/other/Global_Functions.txt
npc: npc/other/common.txt // Your Script

[Error]:  Loading NPC file: npc/custom/pesca.txt
script error on npc/custom/pesca.txt line 126
    parse_callfunc: expected ')' to close argument list
   121 :                specialeffect 6;
   122 :                soundeffectall "fish_start01.wav",0;
   123 :                do{
   124 :                        // track item
   125 :                        if(getVariable(".charname"+.@npc$+"$") != ""){
*  126 :                                if(attachrid(getcharid2'('3,getVariable(".charname"+.@npc$+"$")))){
   127 :                                        if(countitem(getVariable(".trackitem"+.@npc$))<1){
   128 :                                                Local_Fish_Val_Set(getVariable(".fish"+.@npc$+"$"),".fish_amt",1);
   129 :                                                if($@Fishing_Debug) debugmes "OnRodGone";
   130 :                                                donpcevent strnpcinfo(3)+"::OnRodGone";
   131 :                                                end;
[Error]:
script error on npc/custom/pesca.txt line 309
    script:add_word: invalid word. A word consists of undercores and/or alphanumeric characters, and valid variable prefixes/postfixes.
   304 :        .@mstr$ = "Leave:";
   305 :        for(.@x=0;.@x<getarraysize(getVariable(.@arrvarname$));.@x++){
   306 :                .@temp$ = .@arrvarname$+"["+.@x+"]";
   307 :                .@optional$ = "";
   308 :                if(.@arrvarname$==".rod_list"){
*  309 :                        .@index = arrfind_db('"'$@rod_data$",getVariable(.@temp$));
   310 :                        .@indicator_slow_bonus = atoi(arrget_db("$@rod_data$",.@index,1));
   311 :                        .@variation_reduce = atoi(arrget_db("$@rod_data$",.@index,2));
   312 :                        .@optional$ = " [-"+.@indicator_slow_bonus+"% Spd] [-"+.@variation_reduce+"% variation]";
   313 :                }else if(.@arrvarname$==".bait_list"){
   314 :                        .@index = arrfind_db("$@bait_data$",getVariable(.@temp$));
[Error]:
script error on npc/custom/pesca.txt line 373
    parse_line: expect command, missing function name or calling undeclared function
   368 :        .@arrname1$ = getarg(0);
   369 :        .@arrname2$ = getarg(1);
   370 :
   371 :        if( getVariable(".status"+.@npc$) == 0 && @bindspot$ == "" ){
   372 :                mes "[ "+CStr(strnpcinfo(0),"RED")+" ]";
*  373 :                .@rod = Fishing_Item_Check_Func('.'@arrname1$,"Select a rod");
   374 :                if(!.@rod || getVariable(".status"+.@npc$)!= 0){
   375 :                        mes "You don't have the selected item or someone is using this spot, please try again later.";
   376 :                        end;
   377 :                }
   378 :                mes "Selected "+Itemlink(.@rod);
[Error]:
script error on npc/custom/pesca.txt line 427
    parse_line: expect command, missing function name or calling undeclared function
   422 : {
   423 :        //.@sleepduration = getarg(0);
   424 :        .@npc$ = strnpcinfo(3);
   425 :        delwaitingroom .@npc$;
   426 :        .@name$ = getVariable(".charname"+.@npc$+"$");
*  427 :        .@aid = getcharid2('3',.@name$);
   428 :        .@charid = getcharid2(0,.@name$);
   429 :        if(isloggedin(.@aid,.@charid)){
   430 :                setd "@bindspot$","",getcharid2(0,getVariable(".charname"+.@npc$+"$"));
   431 :        }
   432 :        setVariable(".fish"+.@npc$+"$","");
[Error]:
script error on npc/custom/pesca.txt line 449
    parse_line: expect command, missing function name or calling undeclared function
   447 : {
   448 :        sleep2 1000;
*  449 :        if(!playerattached()) 'F'ishing_End_Func();     // add check to counter unexpected player not attach (server reload/disconnect/logout)
   450 :        showscript "It's a "+getVariable(".fish"+strnpcinfo(3)+"$")+"!",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
   451 :        sleep2 1000;
   452 :        if(!playerattached()) Fishing_End_Func();       // add check to counter unexpected player not attach (server reload/disconnect/logout)
   453 :        .@fish$ = getVariable(".fish"+strnpcinfo(3)+"$");
   454 :        .@fish_index = arrfind_db("$@fish_data$",.@fish$);
[Error]:
script error on npc/custom/pesca.txt line 567
    parse_line: expect command, missing function name or calling undeclared function
   566 : {
*  567 : 'F'ishing_Start_Func(".rod_list",".bait_list");
   568 : end;
   569 :
   570 : OnSuccess:
   571 :        emotion ET_BLABLA,getcharid(3,getVariable(".charname"+strnpcinfo(3)+"$"));
   572 :        showscript "I got it!",getcharid2(3,getVariable(".charname"+strnpcinfo(3)+"$"));
[Info]: Done loading '15175' NPCs:
        -'3575' Warps
        -'257' Shops
        -'11343' Scripts
        -'3400' Spawn sets
        -'50035' Mobs Cached
        -'0' Mobs Not Cached
[Debug]: script debug : 0 110000000 : table name [ custom_inventory ] installed!

@Edit SOLVED!

I was using the common version of your GIT because it is very old there.

Can you teach me how to do ?
I got the same problem. 

Link to comment
Share on other sites
  • 1 month later...
FelipeMartins Santa Poring

FelipeMartins

Posted
  • Group:  Members
  • Topic Count:  26
  • Topics Per Day:  0.01
  • Content Count:  174
  • Reputation:   6
  • Joined:  07/01/12
  • Last Seen:  
Posted

I was testing it and it presents a lot of errors.

 

fishing erro.png

Link to comment
Share on other sites
Litro Endemic Poporing

Litro Endemic

Posted
  • Group:  Members
  • Topic Count:  25
  • Topics Per Day:  0.01
  • Content Count:  283
  • Reputation:   79
  • Joined:  06/13/13
  • Last Seen:  
Posted

getvariable shouldbechanged to getvariableofnpc 

*getvariableofnpc(<variable>,"<npc name>")

Returns a reference to a NPC variable (. prefix) from the target NPC.
This can only be used to get . variables.

Examples:

//This will return the value of .var, note that this can't be used, since the value isn't caught.
	getvariableofnpc(.var,"TargetNPC");

//This will set the .v variable to the value of the TargetNPC's .var variable.
	set .v, getvariableofnpc(.var,"TargetNPC");

//This will set the .var variable of TargetNPC to 1.
	set getvariableofnpc(.var,"TargetNPC"), 1;

Note: even though function objects can have .variables,
getvariableofnpc will not work on them.

 

Link to comment
Share on other sites
yuchinin Poring

yuchinin

Posted
  • Group:  Members
  • Topic Count:  12
  • Topics Per Day:  0.00
  • Content Count:  120
  • Reputation:   48
  • Joined:  07/23/13
  • Last Seen:  
  • Author
Posted
On 9/11/2018 at 5:46 AM, FelipeMartins said:

I was testing it and it presents a lot of errors.

 

fishing erro.png

Load the common.txt first before loading fishing script

Link to comment
Share on other sites
  • 2 weeks later...
ReyKo Drops

ReyKo

Posted
  • Group:  Members
  • Topic Count:  0
  • Topics Per Day:  0
  • Content Count:  2
  • Reputation:   0
  • Joined:  04/07/18
  • Last Seen:  
Posted

The settings in the chat room are very interesting.

Download as a research template reference Thanks for sharing

Link to comment
Share on other sites
  • 3 months later...
Seirei Poring

Seirei

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  33
  • Reputation:   0
  • Joined:  05/07/18
  • Last Seen:  
Posted

I really love this fishing game /lv
Thanks for sharing ?

Link to comment
Share on other sites
  • 5 months later...
LearningRO Magmaring

LearningRO

Posted
  • Group:  Members
  • Topic Count:  107
  • Topics Per Day:  0.02
  • Content Count:  778
  • Reputation:   73
  • Joined:  02/10/12
  • Last Seen:  
Posted

where config to set how much u can fishing the fish?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...