Jump to content

Brian

Members
  • Posts

    2223
  • Joined

  • Last visited

  • Days Won

    24

Everything posted by Brian

  1. Correct, this script only allows 2 active players per IP (not counting @autotrade). So if everyone at a LAN house has the same public IP, only 2 can play.
  2. "No tables found in database." It looks like phpBB has not been installed yet (or the install process failed to create any tables). They have instructions here: https://www.phpbb.com/support/documentation/3.0/quickstart/quick_installation.php
  3. Here you go: - script Only2perIP -1,{ OnPCLoginEvent: if (getgmlevel() >= 99) end; set .@myname$, strcharinfo(0); if (query_sql("SELECT `char`.`name` FROM `char` LEFT JOIN login ON `char`.account_id=login.account_id WHERE login.last_ip='"+getcharip()+"' AND `char`.online=1 AND `char`.char_id!="+getcharid(0), .@name$) >= 2) { for (set .@i,0; .@i<getarraysize(.@name$); set .@i,.@i+1) { if (checkvending(.@name$[.@i]) != 2) set .@sameip, .@sameip +1; } if (.@sameip >= 2) { announce "Sorry, only 2 accounts per IP can be logged in at a time.", bc_self; sleep 1000; atcommand "@kick " + .@myname$; } } end; }
  4. You can suggest their inclusion in the SVN by posting a topic in the forum (Script Discussion).
  5. Here are some of the free SVN hosts: SourceForge - http://sourceforge.net/ Google Code - http://code.google.com/projecthosting/ Assembla - https://www.assembla.com/ XP-Dev - https://xp-dev.com/
  6. I didn't add database configs because query_sql uses the current (same) SQL connection as the map-server. As Toshiro said, you can execute SQL queries on any database on the same MySQL Server instance as long as the rAthena SQL user has privileges on that database. Just add the database name in front of the table name: ragnarok1.login
  7. Fixed. http://rathena.sourceforge.net/tools/login_background/
  8. Here you go: account_registration.txt
  9. bugreport:6923 has been fixed. Update your SVN and recompile.
  10. The Linux build process (both make and CMake) already create the /import/ folder from the template folder. It's just the Windows build process that we need to fix. Can Visual Studio be told to copy files/folders in the compile process? If not, then maybe a batch file to do this?
  11. So to access this NPC in-game, they would have to login first right? How would players create the first account to login with?
  12. Brian

    Code Style

    I vote for these Astyle options for trunk/src/: # Brackets are broken from namespaces, classes, and function definitions. # Brackets are attached to statements within a function. --style=kr # Indent using tabs. Convert 4 spaces to 1 tab. --indent=tab=4 # Indent 'class' and 'struct' blocks --indent-classes # Indent multi-line preprocessor definitions ending with a backslash. --indent-preprocessor # Indent comments beginning in column one. --indent-col1-comments # When a header is built of multiple lines, the lines will be aligned with the paren on the preceding line. --min-conditional-indent=0 # Insert space padding after paren headers only (e.g. 'if', 'for', 'while'...). --pad-header # Remove extra space padding around parenthesis on the inside and outside. --unpad-paren # Don't break complex statements and multiple statements residing on a single line. --keep-one-line-statements ######################################################### # Which --align-pointer and --align-reference options? ######################################################### # Do not retain a backup of the original file. (your working copy has SVN History) --suffix=none # For each directory in the command line, process all subdirectories recursively. --recursive Also, some previous discussion: (rough draft) Scripting & Coding Style Guidelines and User:Gepard/Sandbox.
  13. I should clarify - I didn't mean telling users to put every single OnPCLoginEvent in the same file; I meant combining ones that made sense. Ex: combine these 3 npcs into 1: Yes you're right. With my suggestion @gmotd would probably be removed since the MOTD would not be restricted to text announcements anymore.
  14. Their purchase is credited to your account in IP.Downloads. You can use this credit to purchase other people's files in the Downloads section, or you can do a Payout Request which transfers the money to your PayPal.
  15. Is this what it's like to work in a zoo?

  16. You could only log GM @commands and not player @commands. trunk/conf/groups.conf <log_commands> Boolean value. If true then all commands used by the group will be logged to atcommandlog. If setting is omitted in a group definition, false is assumed. Requires 'log_commands' to be enabled in 'conf/log_athena.conf'. Set log_commands: false for groups which you don't want @commands to be logged.
  17. For examples of script commands that accept multiple pairs of arguments, there's: isequipped, isequippedcnt, npcshopitem, npcshopadditem, npcshopdelitem
  18. Brian

    lock.o

    There was an error in r16898. http://build.rathena...iles/builds/194 It was fixed right after that. Have you updated your SVN to the latest revision and recompiled?
  19. This suggestion is for checkweight to accept multiple sets of <item>,<amt> right? checkweight(<item1>,<amt1>, <item2>,<amt2>, <item3>,<amt3>) I vote yes!
  20. Ah good point. Why didn't I think of putting news/svn updates in the MOTD like that? XD
  21. I'd like to suggest moving the Message Of The Day to a script with OnPCLoginEvent instead of !svn/bc/16928/trunk/conf/motd.txt suggestion: trunk/npc/scripts_athena.conf // --------------------------- MOTD ----------------------------- npc: conf/motd.txt // so people will find the MOTD script in the same place it's always been // or should we go keep all NPCs in the same folder? npc: npc/motd.txt motd.txt - script rathena_MOTD -1,{ OnPCLoginEvent: if (getbattleflag("display_version")) dispbottom "SVN version: " + get_revision(); dispbottom "Welcome to rAthena SVN! Enjoy! Please report any bugs you find."; // add your custom MOTD messages and other script commands here: end; } Advantages: + easier for server owners to customize + not limited to just displaying a message + they can trigger ANY script commands (ex: a common one, atcommand "@main on" + (?) encourages new users learning rAthena to put all OnPCLoginEvent triggers in one file, thus avoiding "Event queue full" errors Disadvantages: - performance? loading one more npc script - might still cause "Event queue full" errors if they already have a bunch of separate scripts with OnPCLoginEvent.. + solution: load our MOTD script first, since it will not have any script commands that pause script execution
  22. I vote for storing all maps as lowercase, so mapname lookups are case-insensitive (Arcenciel's idea). oops I replied in the bugreport before I read this topic.
  23. 1. Suggestions for Users Online: - FluxCP: get it from /fluxcp/?module=server&action=status-xml - CeresCP: parse it from /cerescp/server_status.php - other CPs: ??? When server owners login to edit their server listing, maybe under "Users Online" have a dropdown list where they choose which CP, then a text box next to it where they input their CP URL. 2. Online Status: optionally let server owners input their IP and ports so your website can display Online/Offline status (if they use FluxCP, grab the server status from /fluxcp/?module=server&action=status-xml)
×
×
  • Create New...