Jump to content

rentitem2


Emistry

Recommended Posts


  • Group:  Forum Moderator
  • Topic Count:  93
  • Topics Per Day:  0.02
  • Content Count:  10013
  • Reputation:   2348
  • Joined:  10/28/11
  • Last Seen:  

File Name: RentItem2

File Submitter: Emistry

File Submitted: 01 Mar 2012

File Category: Source Modifications

Content Author: Brian

A Script command that extent the usage of

rentitem

it work just like item2 command..but with rental period.

*rentitem2 <item id>,<time>, <identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>;
*rentitem2 "<item name>",<time>, <identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>;

original post link :

http://www.eathena.w...1

I have updated the diff with these changes, and now it works on the current rAthena (r16852).

rentitem2_r16852.diff

Click here to download this file

Link to comment
Share on other sites

  • 4 weeks later...

  • Group:  Members
  • Topic Count:  40
  • Topics Per Day:  0.01
  • Content Count:  530
  • Reputation:   33
  • Joined:  01/17/12
  • Last Seen:  

not working on latest SVN

a Question also, can the Card be removed?

Edited by ngek202
Link to comment
Share on other sites


  • Group:  Forum Moderator
  • Topic Count:  93
  • Topics Per Day:  0.02
  • Content Count:  10013
  • Reputation:   2348
  • Joined:  10/28/11
  • Last Seen:  

Link to comment
Share on other sites

  • 7 months later...

  • Group:  Members
  • Topic Count:  59
  • Topics Per Day:  0.01
  • Content Count:  396
  • Reputation:   53
  • Joined:  07/24/12
  • Last Seen:  

rentitem2 not working :(

bump.. any solutions?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  42
  • Topics Per Day:  0.01
  • Content Count:  297
  • Reputation:   15
  • Joined:  11/17/11
  • Last Seen:  

it works fine for me. nothing to fix. just apply all patches properly. been using this since june.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  75
  • Topics Per Day:  0.02
  • Content Count:  2223
  • Reputation:   593
  • Joined:  10/26/11
  • Last Seen:  

The original rentitem2.diff I posted in March 2010 works for e/rAthena r14260.

rentitem2 not working :(

The diff no longer works due to these changes:

- r15420/trunk/src/map/script.c

- r16361/trunk/src/map/script.c

I have updated the diff with these changes, and now it works on the current rAthena (r16852).

rentitem2_r16852.diff

Link to comment
Share on other sites

  • 2 weeks later...

  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  53
  • Reputation:   4
  • Joined:  02/08/12
  • Last Seen:  

i found 2 bugs on this command :

1. When an item expired while being equiped,it didn't dissapear, it is just moved to inventory and not equipable. But the item dissapear when character logout or changing map. (Not critical)

2. Adding card to rentitem is abusable, The slotted card can easily extracted by card remover. Player will get "Free" card from this method. (This is absolutely critical)

Hope fixed soon..

Edited by serakh00
Link to comment
Share on other sites


  • Group:  Forum Moderator
  • Topic Count:  93
  • Topics Per Day:  0.02
  • Content Count:  10013
  • Reputation:   2348
  • Joined:  10/28/11
  • Last Seen:  

2. Adding card to rentitem is abusable, The slotted card can easily extracted by card remover. Player will get "Free" card from this method. (This is absolutely critical)

Hope fixed soon..

add this diff..

and re-edit your npc to check for the expire date of and item before they can remove card from the item.

http://www.eathena.ws/board/index.php?showtopic=241313&view=findpost&p=1318374

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  40
  • Topics Per Day:  0.01
  • Content Count:  587
  • Reputation:   104
  • Joined:  11/19/11
  • Last Seen:  

i found 2 bugs on this command :

1. When an item expired while being equiped,it didn't dissapear, it is just moved to inventory and not equipable. But the item dissapear when character logout or changing map. (Not critical)

2. Adding card to rentitem is abusable, The slotted card can easily extracted by card remover. Player will get "Free" card from this method. (This is absolutely critical)

Hope fixed soon..

2. in original post,

you can get script command getequipexpiretick

if(getequipexpiretick(<equipment slot>)) close;

Well , Emistry post faster than me lol..

Edited by QQfoolsorellina
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  53
  • Reputation:   4
  • Joined:  02/08/12
  • Last Seen:  

i got this error when compiled with the diff (getequipexpiretic)

1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6531): error C2065: 'equip' : undeclared identifier
1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6531): error C2065: 'equip' : undeclared identifier
1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6531): error C2109: subscript requires array or pointer type
1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6538): error C2065: 'equip' : undeclared identifier
1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6538): error C2109: subscript requires array or pointer type
1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6538): error C2198: 'pc_checkequip' : too few arguments for call

Edited by serakh00
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  40
  • Topics Per Day:  0.01
  • Content Count:  587
  • Reputation:   104
  • Joined:  11/19/11
  • Last Seen:  

in your script.c, can you find this ?

static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW};

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  53
  • Reputation:   4
  • Joined:  02/08/12
  • Last Seen:  

in your script.c, can you find this ?

static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW};

sure there is

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  40
  • Topics Per Day:  0.01
  • Content Count:  587
  • Reputation:   104
  • Joined:  11/19/11
  • Last Seen:  

in your script.c, can you find this ?

static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW};

sure there is

It must be declared before you use equip[num] , so BUILDIN_FUNC(getequipexpiretick){...} must be put after that array declare

Edited by QQfoolsorellina
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  53
  • Reputation:   4
  • Joined:  02/08/12
  • Last Seen:  

in your script.c, can you find this ?

static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW};

sure there is

It must be declared before you use equip[num] , so BUILDIN_FUNC(getequipexpiretick){...} must be put after that array declare

OK its work now..

sorry for my fool :P

Thanks QQ and Emistry for fast respone.

Link to comment
Share on other sites


  • Group:  Forum Moderator
  • Topic Count:  93
  • Topics Per Day:  0.02
  • Content Count:  10013
  • Reputation:   2348
  • Joined:  10/28/11
  • Last Seen:  

I have updated the diff with these changes, and now it works on the current rAthena (r16852).

rentitem2_r16852.diff

read previous post....beside i already updated the Download site too....

Link to comment
Share on other sites

  • 3 months later...

  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  53
  • Reputation:   4
  • Joined:  02/08/12
  • Last Seen:  

someone can update this to recent revision?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  164
  • Reputation:   12
  • Joined:  03/08/12
  • Last Seen:  

someone can update this to recent revision?

Its working @latest rev. :)

Link to comment
Share on other sites

  • 6 years later...

  • Group:  Members
  • Topic Count:  0
  • Topics Per Day:  0
  • Content Count:  1
  • Reputation:   0
  • Joined:  01/03/20
  • Last Seen:  

would be nice if it were rentitem2 <item id> <amount> <time>

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...