Jump to content

Recommended Posts

Posted

Instance Mode Expansion

As of 32c829d, rAthena now supports more instance modes!

Suggested by the community instance now support three new modes: No player attached, single character attached, and guild attached!

Notable changes:

  • New instance modes: IM_NONE, IM_CHAR, IM_GUILD (with IM_PARTY as default)
    • Restructured instance_create("<instance name>"{,<instance mode>{,<owner ID>}}); to accept the new modes while keeping backwards support!
  • The instance_db now includes the timeout time to allow easy customization for each instance.
  • The instance_db now reads EnterMap as Map1 to remove redundancy.
  • Instance maps are now stored in a dynamic array to conserve memory. Now supports up to 255 maps!
  • Instances are now destroyed if the owner cannot be found.
  • Added script command instance_check_guild(<guild id>{,<amount>{,<min>{,<max>}}}); which works the same as instance_check_party.
  • Adjusted script command instance_announce to check when instance ID is 0 rather than -1 since instance IDs are stored as unsigned now.
  • Upvote 12
Posted (edited)

Great addition.
But to be honest.... i would have prefered to see missing official content to be implemented instead.

 

Why?

Because there are only a handfull of people who ever made instance scripts at all.
So this isn't really for the *masses*, it's just a great to have.

roDex anyone?
Which is just one example out of a lot of missing official features.

( i know it's being worked on )

 

 

Not to mention that Battlegrounds is still bugged which is one of the core pvp features in ro.

 

 

Priorities...

 

 

And now let the hate rain down on me.

Edited by Everade
  • Upvote 1
Posted

Great addition.

But to be honest.... i would have prefered to see missing official content to be implemented instead.

Why?

Because there are only a handfull of people who ever made instance scripts at all.

So this isn't really for the *masses*, it's just a great to have.

roDex anyone?

Which is just one example out of a lot of missing official features.

( i know it's being worked on )

Not to mention that Battlegrounds is still bugged which is one of the core pvp features in ro.

Priorities...

And now let the hate rain down on me.

I believe optimization of the code we have should always be prioritized before adding of newer content. If one keeps adding more features without optimizing we end up with a mass of spaghetti code that's harder to fix and optimize later down the line.

Mind linking me BG bug reports btw I'd like to take a look at these.

  • Upvote 1
Posted

I believe optimization of the code we have should always be prioritized before adding of newer content. If one keeps adding more features without optimizing we end up with a mass of spaghetti code that's harder to fix and optimize later down the line.

Mind linking me BG bug reports btw I'd like to take a look at these.

 

I agree.

But fixing an optimizing code/features is a never ending process.

You can't tell me that you're going to work on new things ones everything has been fixed.

That's never going to happen.

 

So fixing bugs according to bug reports should always stay one of the main priorities.

 

 

However at the current state are a lot of pending official features which are in the pipeline since quite a time.

That's why i'm saying, i would have prefered to see them instead.

Especially roDex because the old mail system was used by quite some people, and it has been ripped out of our hands.

 

 

About the BG bug, i think that one is related to newer clients only, i'm not sure.

However it's not script related:

https://github.com/rathena/rathena/issues/1240

Another major bug with status effects:

https://github.com/rathena/rathena/issues/996

Or that we ran out of monster id ressources (doesn't look like anyone else than me is being interested into that issue though)

https://github.com/rathena/rathena/issues/1253

 

 

These are just some of mine, i'm sure there might be even more important things to do.

Or things more people are affected off.

 

 

@Aleos is still doing an awesome job, no matter what ;)

So please don't get me wrong on this

Posted (edited)

Amazing, thanks.

 

PS: Can you give me a common use of an instance which is attached to no one?

Edited by Vykimo
Posted

Personally I'm looking forward to playing with this alot.

 

If I could get IM_CHAR to work properly I'd agree /spin

Posted

Personally I'm looking forward to playing with this alot.

If I could get IM_CHAR to work properly I'd agree /spin

I plan on playing with it between my next 2 request I'll let you know how it goes.

  • Upvote 2

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...