Revert / bring back the old equipment switch frost.

[MusiLiciouS]

I know Switch Frost is a bug in ragnarok but my players are used to it.. Players in pre-renewal severs are used to it. Im currenly using ramod..

I know it has been fixed but i want to bring it back.. It may be sound insane but my players want it.. Can anyone give me how to revert the changes? or how to bring it back?

[Playtester]

The easiest way to do that is to go to status.c and remove that part:

	if (bl->type == BL_PC && ((TBL_PC*)bl)->delayed_damage != 0) {
		if (opt&SCO_FORCE)
			((TBL_PC*)bl)->state.hold_recalc = 0; /* Clear and move on */
		else {
			((TBL_PC*)bl)->state.hold_recalc = 1; /* Flag and stop */
			return;
		}
	}

[Dhall]

https://rathena.org/board/topic/103978-frost-switch/

[MusiLiciouS]

https://rathena.org/board/topic/103978-frost-switch/

i revert it but i only got errors in recompiling

[Stolao]

https://rathena.org/board/topic/103978-frost-switch/

i revert it but i only got errors in recompiling

Then post your errors

[MusiLiciouS]

 

 

https://rathena.org/board/topic/103978-frost-switch/

i revert it but i only got errors in recompiling

Then post your errors

 

 

Currenly im using rAmod.. So i was expecting that its almost the same with rathena. Some lines are not present in my battle.c.. i cannot revert the changes because some lines are not the same with the revisions made from the link..

[Dhall]

Post your error if you want some help! We really don't know them! 

[MusiLiciouS]

We've reverted the changes from here https://github.com/H...3ff74343cd3ae76
 

make[1]: Entering directory `/home/trincli0900/trunk/src/map'
        MKDIR   obj
        CC      achievement.c
        CC      atcommand.c
atcommand.c:52:21: error: faction.h: No such file or directory
atcommand.c: In function 'atcommand_mobevent':
atcommand.c:8602: warning: unused variable 'y'
atcommand.c:8602: warning: unused variable 'x'
atcommand.c: In function 'atcommand_faction':
atcommand.c:10791: warning: implicit declaration of function 'faction_search'
atcommand.c:10791: warning: assignment makes pointer from integer without a cast
atcommand.c:10798: error: dereferencing pointer to incomplete type
atcommand.c:10801: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_language':
atcommand.c:10813: warning: initialization makes pointer from integer without a cast
atcommand.c:10814: error: dereferencing pointer to incomplete type
atcommand.c:10821: error: dereferencing pointer to incomplete type
atcommand.c:10821: warning: implicit declaration of function 'lang_search'
atcommand.c:10821: error: dereferencing pointer to incomplete type
atcommand.c:10823: error: dereferencing pointer to incomplete type
atcommand.c:10824: error: dereferencing pointer to incomplete type
atcommand.c:10836: warning: assignment makes pointer from integer without a cast
atcommand.c:10836: error: dereferencing pointer to incomplete type
atcommand.c:10842: error: 'lang_pow' undeclared (first use in this function)
atcommand.c:10842: error: (Each undeclared identifier is reported only once
atcommand.c:10842: error: for each function it appears in.)
atcommand.c:10844: error: dereferencing pointer to incomplete type
atcommand.c:10850: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_learnlang':
atcommand.c:10860: warning: assignment makes pointer from integer without a cast
atcommand.c:10866: error: 'lang_pow' undeclared (first use in this function)
atcommand.c:10868: error: dereferencing pointer to incomplete type
atcommand.c:10875: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_unlearnlang':
atcommand.c:10885: warning: assignment makes pointer from integer without a cast
atcommand.c:10891: error: 'lang_pow' undeclared (first use in this function)
atcommand.c:10894: error: dereferencing pointer to incomplete type
atcommand.c:10899: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_say':
atcommand.c:10913: warning: implicit declaration of function 'lang_convert'
make[1]: *** [obj/atcommand.o] Error 1
make[1]: Leaving directory `/home/trincli0900/trunk/src/map'
make: *** [map] Error 2

Then we tried this https://github.com/rathena/rathena/commit/2732176

 

Some lines are missing from our src files..

Edited January 8, 2016 by MusiLiciouS

[Emistry]

I wondering what emulator are you currently using ??

 

You mentioned using rAmod, but then you applied source mod from Hercules, and trying to fix it by revert to rAthena ?

 

do you actually know each of these rAmod / Hercules / rAthena have very big different for their source codes?

[MusiLiciouS]

I wondering what emulator are you currently using ??

 

You mentioned using rAmod, but then you applied source mod from Hercules, and trying to fix it by revert to rAthena ?

 

do you actually know each of these rAmod / Hercules / rAthena have very big different for their source codes?

I thought rathena source codes are quite similar.. im quite new with this thing, im sorry.. and yet someone linked me to those fixes thats why i tried,. it was clearly stated on this post that im using ramod.. i posted this incase someone knows how to revert this in ramod..

[MusiLiciouS]

Anyone knows how to revert this in ramod???

Edited January 17, 2016 by MusiLiciouS

[Scylla]

I wondering what emulator are you currently using ??

 

You mentioned using rAmod, but then you applied source mod from Hercules, and trying to fix it by revert to rAthena ?

 

do you actually know each of these rAmod / Hercules / rAthena have very big different for their source codes?

 

She mentioned here that she's using 3CeAM.

 

@MusiLiciouS

Anyway, 3CeAM is still an eAthena emulator, not rA or herc.

 

3CeAM = 3rd Class eAthena Modification.

Edited January 17, 2016 by Scylla

[MusiLiciouS]

I wondering what emulator are you currently using ??

 

You mentioned using rAmod, but then you applied source mod from Hercules, and trying to fix it by revert to rAthena ?

 

do you actually know each of these rAmod / Hercules / rAthena have very big different for their source codes?

 

She mentioned here that she's using 3CeAM.

 

@MusiLiciouS

Anyway, 3CeAM is still an eAthena emulator, not rA or herc.

 

3CeAM = 3rd Class eAthena Modification.

Ah yea coz i have 2 servers mam.. one is in ramod.. then i made a new one and it's 3ceam..

[Deviszh]

still no fix for this? rathena is not active as i am always looking for other problem like this.

[Deviszh]

I want to revert back the status of switching weapons? Example Mjolnir switch to 4 stormy knight mace = frost with 150 dex (no cast)

 

please help me revert it back. full details please.

 

you can help me in skype.

 

my skype id is "facebook:dnkip1" 

 

or 

 

i need a trusted developer. my server is finished, i just got problem in switching weapon status.

Edited October 11, 2016 by Kinkkynipps

[Deviszh]

Thank you, really appreciated sir. I will try it.

The easiest way to do that is to go to status.c and remove that part:

	if (bl->type == BL_PC && ((TBL_PC*)bl)->delayed_damage != 0) {
		if (opt&SCO_FORCE)
			((TBL_PC*)bl)->state.hold_recalc = 0; /* Clear and move on */
		else {
			((TBL_PC*)bl)->state.hold_recalc = 1; /* Flag and stop */
			return;
		}
	}

Thanks sir! It works!

[Azeroth]

 

The easiest way to do that is to go to status.c and remove that part:

	if (bl->type == BL_PC && ((TBL_PC*)bl)->delayed_damage != 0) {
		if (opt&SCO_FORCE)
			((TBL_PC*)bl)->state.hold_recalc = 0; /* Clear and move on */
		else {
			((TBL_PC*)bl)->state.hold_recalc = 1; /* Flag and stop */
			return;
		}
	}

PlayTester? would you mind to explain me a little bit? about frost switching? and how does it work?

[Playtester]

On official servers the damage of an attack and what status effects it causes it determined at the beginning of the attack. So even if you change equip during the attack, neither damage nor effect will change.

 

On eAthena, the damage of an attack is calculated at the start of the attack but status effects are calculated only the moment when the damage is actually applied (HP substracted). So in eAthena it was possible to start an attack with a strong weapon and during the attack switch to a weak weapon that causes status changes and then deal the high damage of the strong weapon and causing the status changes at the same time.

 

rAthena implemented a system that blocks your status from being recalculated during an attack and solves that issue this way (the code above).

[Emistry]

Anyone knows how to revert this in ramod???

undo all the changes done on the relevant commit.

 

 

still no fix for this? rathena is not active as i am always looking for other problem like this.

this isn't "fixing" a bug or issue, it's "bringing back" the old bug.

[Playtester]

At least give the thread a proper title if you merge them all together. =D

 

Edit: Done.

[xtremegun]

@Playtester @Emistry

I need help regarding this same problem. I already edited the status.c file under src/map/status.cpp.

I tried restarting the server for it to take effect. But when I tried its still not working. Can you help me?

[LearningRO]

8 hours ago, xtremegun said:

@Playtester @Emistry

I need help regarding this same problem. I already edited the status.c file under src/map/status.cpp.

I tried restarting the server for it to take effect. But when I tried its still not working. Can you help me?

you need recompile the server first