Ninja

You try to look at battle.h // Final calculation Damage int64 battle_calc_damage(struct block_list *src,struct block_list *bl,struct Damage *d,int64 damage,uint16 skill_id,uint16 skill_lv); int64 battle_calc_gvg_damage(struct block_list *src,struct block_list *bl,int64 damage,uint16 skill_id,int flag); int64 battle_calc_bg_damage(struct block_list *src,struct block_list *bl,int64 damage,uint16 skill_id,int flag); simply changing the return type would do it but that would affect a lot of things.

// The rate at which a pet will become hungry. (Note 2) pet_hungry_delay_rate: 100 You simply set this to 0 if you want to save yourself the trouble of doing source modification. Though this also means that pets in your server will never be hungry

You should try to check if you compiled your server with RENEWAL_CAST enabled. mmo.h /// Renewal cast time /// (disable by commenting the line) /// /// Leave this line to enable renewal casting time algorithms and enable fixed cast bonuses. /// See also default_fixed_castrate in conf/battle/skill.conf for default fixed cast time (default is 20%). /// Cast time is altered be 2 portion, Variable Cast Time (VCT) and Fixed Cast Time (FCT). /// By default FCT is 20% of VCT (some skills aren't) /// - VCT is decreased by DEX * 2 + INT. /// - FCT is NOT reduced by stats, reduced by equips or buffs. /// Example: /// On a skill whos cast time is 10s, only 8s may be reduced. the other 2s are part of a FCT #define RENEWAL_CAST It causes a FCT of 20%VCT. Casting time reduction items only affect VCT in this mode. Just comment out the last line to achieve no cast time.

can you post a snippet of your script? I'm not really sure what type of bonus you are trying to give

@eezclide Hey man, I just got back from my hiatus. I'm still catching up with a lot of stuff here in rA. I'll try to get back to you as soon as I get my environment up and running again. Cheers.

Do you guys have a plan for the milestones which contains which stuff should be prioritized to be converted to c++? (e.g. Milestone 1: Development Ready, Milestone 2: Modification ready) I had a long hiatus to learn stuff in dev-ing (though mostly on testing) and now I'm back, I want to find a way to be able to contribute. @meko9586 This is actually one point of interest that I'm looking forward to.

Hi, this is cool, but is it possible to set a fixed coordinates? instead of typing the exact numbers?. thanks. If you look at the script closely, you'll see that if a gamemaster uses @gotm, he's able to set the map and the coordinates in-game.

Hi, You can try using this: https://rathena.org/board/topic/103318-how-to-add-new-commands-in-normal-players/#entry290783 and use "atcommand @gotm" as your item script

@Namine210 can you post the error here? Thanks

after monster .@map$,0,0,"--ja--",1002,150,.@label$,2;

no problem.

please try this //===== Hercules Script =========================================== //= King of Emperium Hill //===== By: ======================================================= //= AnnieRuru //===== Current Version: ========================================== //= 1.1 //===== Compatible With: ========================================== //= hercules 2015-12-19 //===== Description: ============================================== //= defends the emperium in the middle of the map until times up //===== Topic ===================================================== //= http://hercules.ws/board/topic/4495-gvg-king-of-emperium-hill/ //===== Additional Comments: ====================================== //= Finally there is a topic for this ! //================================================================= - script KoE FAKE_NPC,{ OnInit: disablenpc "The King#KoE"; disablenpc "Exit#KoE"; bindatcmd "koe", strnpcinfo(0)+"::OnCommand", 99,100; // Rewards .include_offline = 0; // Include offline guild members? ( 1 = Enabled | 0 = Disabled ) setarray .Items[0],7779,1; // Item Id, Item Amount end; OnCommand: if ( compare( .@atcmd_parameters$, "on" ) ) goto L_Start; else if ( compare( .@atcmd_parameters$, "off" ) ) goto L_End; else { dispbottom "type - '@koe on' to start the event"; dispbottom "type - '@koe off' to end the event"; } end; L_Start: OnClock2015: // everyday 8pm starts if ( .start ) end; gvgon "guild_vs1"; announce "The King of Emperium Hill has begun!", bc_all; .start = true; enablenpc "The King#KoE"; disablenpc "Exit#KoE"; $koegid = 0; donpcevent "::OnRevKoE"; maprespawnguildid "guild_vs1", $koegid, 3; killmonster "guild_vs1", "KoE::OnEmpDead"; monster "guild_vs1",49,49, "EMPERIUM", EMPELIUM, 1, "KoE::OnEmpDead"; end; L_End: OnClock2045: // everyday 8:30pm ends gvgoff "guild_vs1"; announce "The King of Emperium Hill is over!", bc_all; .start = 0; enablenpc "Exit#KoE"; disablenpc "The King#KoE"; killmonster "guild_vs1", "KoE::OnEmpDead"; // maprespawnguildid "guild_vs1", $koegid, 2; // uncomment this line to kick non-owner off the map when event ends query_sql "SELECT `account_id`, `char_id` FROM `guild_member` WHERE `guild_id` = '" + $koegid + "'",.@aid,.@cid; for ( .@i = 0; .@i < getarraysize( .@aid ); .@i++ ) { if ( isloggedin( .@aid[ .@i ], .@cid[ .@i ] ) ) { if ( attachrid( .@aid[ .@i ] ) ) { if ( !checkvending() ) { for ( .@x = 0; .@x < getarraysize( .Items ); .@x+=2 ) getitem .Items[ .@x ], .Items[ .@x + 1 ]; } } } if ( .include_offline ) { for ( .@x = 0; .@x < getarraysize( .Items ); .@x+=2 ) { if ( query_sql( "SELECT `nameid` FROM `inventory` WHERE `char_id` = '" + .@cid[ .@i ] + "' AND `nameid` = '" +.Items[ .@x ]+ "'" ) ) query_sql "UPDATE `inventory` SET `amount` = `amount` + " + .Items[ .@x + 1 ] + " WHERE `char_id` = '" + .@cid[ .@i ] + "' AND `nameid` = '" +.Items[ .@x ]+ "'"; else query_sql "INSERT INTO `inventory` ( `char_id`, `nameid`, `amount`, `identify` ) VALUES ( '" +.@cid[ .@i ]+ "' , '" +.Items[ .@x ]+ "', '" +.Items[ .@x + 1 ]+ "', '1')"; } } } end; OnEmpDead: $koegid = getcharid(2); announce "The current King of Emperium Hill is the ["+ strcharinfo(2) +"] guild.", bc_all; donpcevent "::OnRevKoE"; maprespawnguildid "guild_vs1", $koegid, 2; killmonster "guild_vs1", "KoE::OnEmpDead"; sleep 500; if ( .start ) monster "guild_vs1",49,49, "EMPERIUM", EMPELIUM, 1, "KoE::OnEmpDead"; end; } // KoE Entrance doubrius,86,112,4 script The King#KoE 4_M_CHNGENERL,{ mes "[The King]"; if ( !getcharid(2) ) { mes "You must have a guild to participate in the ^FF0000King of Emperium Hill Tournament^000000."; close; } mes "Hello."; mes "Would you like to participate in the ^FF0000King of Emperium Hill Tournament^000000?"; if ( select ( "Yes", "No" ) == 2 ) close; if ( !getvariableofnpc( .start, "KoE" ) ) close; switch( rand(1,4) ){ case 1: warp "guild_vs1", 50, 88; end; case 2: warp "guild_vs1", 88, 50; end; case 3: warp "guild_vs1", 50, 11; end; case 4: warp "guild_vs1", 11, 50; end; } } // KoE Exit guild_vs1,49,56,5 script Exit#KoE 1_M_BARD,{ mes "[Exit]"; mes "See ya."; if ( getcharid(2) == $koegid ) getitem 20032,2; getitem 14232,3; getitem 20033,1; getitem 20034,3; getitem 7227,10; // configure prize here close2; warp "Save",0,0; end; } // Flags doubrius,77,108,5 script King of Emperium Hill#1::koe_flag GUILD_FLAG,{ if ( !$koegid ) end; mes "[King of Emperium Hill]"; mes "The Current King of Emperium Hill is the ["+ getguildname($koegid) +"] guild."; close; //OnInit: // Uncomment this line to make the emblem stay after @reloadscript OnRevKoE: flagemblem $koegid; end; } guild_vs1,61,49,6 duplicate(koe_flag) King of Emperium Hill#2 GUILD_FLAG guild_vs1,38,49,2 duplicate(koe_flag) King of Emperium Hill#3 GUILD_FLAG guild_vs1,49,61,0 duplicate(koe_flag) King of Emperium Hill#4 GUILD_FLAG guild_vs1 mapflag nobranch guild_vs1 mapflag nomemo guild_vs1 mapflag nopenalty guild_vs1 mapflag noreturn guild_vs1 mapflag nosave SavePoint guild_vs1 mapflag noteleport guild_vs1 mapflag gvg_noparty guild_vs1 mapflag nowarp guild_vs1 mapflag nowarpto guild_vs1 mapflag guildlock

@Emistry Yes I understand. I was looking into future posts

First, You have to know which warp point you want to disable. Then use disablenpc instance_npcname("warp name") then add a trigger script to enable it. base it here: https://rathena.org/board/topic/92382-disable-warp-on-instance-dungeon/#entry243658 as an example: prontera,150,150,0 script Instanced Prontera#a 101,{ set .@instance$, "Primer Jefe"; if (instance_id()) { if (select("Enter Instance.:Cancel.") == 2) end; if (instance_enter(.@instance$) != 0) { mes "Instance entrance ^FF0000failed^000000."; close; } } else { if (select("Create Instance.:Cancel.") == 2) end; if (instance_create(.@instance$) < 0) { mes "Instance creation ^FF0000failed^000000."; close; } mes "Instance created."; close2; instance_enter(.@instance$); //this .@map$ = instance_mapname("prontera"); .@label$ = instance_npcname(strnpcinfo(0))+"::OnMyMobDead"; monster .@map$,0,0,"--ja--",1002,150,.@label$,2; //end } end; //this OnMyMobDead: enablenpc instance_npcname("warppoint name"); end; //end OnInstanceInit: disablenpc instance_npcname(strnpcinfo(0)); //this disablenpc instance_npcname("warppoint name"); //end end; }

can you post your KoE script?

Well, I'm not really sure how will be able to help you with so little info on what you're trying to achieve.

can't say anything about it with just that line. thought what I meant was that I had to add an "Addtime" line. Maybe you can show the whole script and let's see what we can figure out from there.

@Dissidia try checking your scripts. Mine was about "addtimer"

I think this is client-sided

errr let me just clear something out, scripting != sourcing. scripting are the npc/event stuff and sourcing is the backend work that makes script functional. I personally started to try sourcing back then because I loved making things work and I did have some C++ background and what I did was look at the code, read a few stuff over the internet, look at the patterns and then voila. I stopped though because I didn't know which direction I should go and started looking at scripting which is way easier. I started by looking at the script_commands.txt. Looked at few simple codes. Tried it myself. Looked at complicated codes. Tried it myself. Find good ideas to work at. Tried it myself. Started modifying the work of others. Started to receive some scripts for free. Now, I'm trying to go back and contribute to the sourcing scene since I've seen the issues bloat up lately and never reached < 100. I'm doing it by asking a few people over at the discord channel (pardon me for bugging you guys ) then observed and tried stuff on my own. Then looked at a few codes and tried it myself. Bottom line? See my sig.

If there's any input that I can provide just let me know.

set a character variable and check it. if (NotEverReachedMaxLevelSinceForever){ set NotEverReachedMaxLevelSinceForever, 0; } else { mes "You have already reached the max level"; close; }

Just a suggestion so that at the very least people will be informed in what has been happening in the development scene just by taking a glimpse.

I'd wait for it. Then modify it to my likings <3