Extended Cell PvP [1.7]

[Darkpurple]

oh yes map server can't load 

 

 

http://pastebin.com/kfUi05Zz

 

In this script, if not use max_scriptarray.patch, will it got any problems or bugs?

Edited September 19, 2014 by Darkpurple

[Napster]

if mod max_scriptarray over to 128 no problem
 

$@onlineaid  use SCRIPT_MAX_ARRAYSIZE

 

SCRIPT_MAX_ARRAYSIZE 128 = 128 player online
 

[Darkpurple]

if mod max_scriptarray over to 128 no problem

 

$@onlineaid  use SCRIPT_MAX_ARRAYSIZE

 

SCRIPT_MAX_ARRAYSIZE 128 = 128 player online

 

 

But if my running server is 3xx online people now, does it mean it can only detect 128 people in this script?

Edited September 19, 2014 by Darkpurple

[Napster]

yes sir 128 people

$@onlineaid -> accout id player online

and $@onlinecount for loop check event script again

[Darkpurple]

yes sir 128 people

$@onlineaid -> accout id player online

and $@onlinecount for loop check event script again

 

Okay, it will ignore half of part (around 150up) people, right ?

It will lead unfair situation....   

[sRC] Cell PvP 1.7

 

Last update : 18/07/2014

 

Support : rAthena SVN revision 12425

 

Feature : Create cell for player vs player with out mapflag pvp

How to use this ?

You can enable or disable this feature

conf/battle/misc.conf

 

// Addon Cell PVP [Napster]

// Enable Deathmatch for cell pvp

// Default: 0

// 0 = No

// 1 = Yes

cellpvp_deathmatch: 1

 

// Delay player alive deathmatch for cell pvp

// Default: 1000 (1 secand)

cellpvp_deathmatch_delay: 1000

 

// When player is dead recovery HP/SP Rate for cell pvp

// Default: 100 (recovery 100%)

deathmatch_hp_rate: 100

deathmatch_sp_rate: 100

 

// Enable buff when player is dead for cell pvp

// Default: 1

// 0 = No

// 1 = Yes

// Request core npc files use name "deathmatch_core"

cellpvp_autobuff: yes

 

// Can atk player in party

// Default: 1

// 0 = No

// 1 = Yes

cellpvp_party_enable: no

 

// Can atk player in guild

// Default: 1

// 0 = No

// 1 = Yes

cellpvp_guild_enable: no

 

// When player move to cell pvp is delay walk out cooldown

// Default: 5000 (5 secand)

cellpvp_walkout_delay: 5000

 

how to create cell pvp

 

 

- script test_cellpvp -1,{

end;

OnInit:

setcell "new_1-1",45,109,53,102,cell_pvp, 1;

end;

}

 

How to use auto buff script

Add npc script don't edit npc name "deathmatch_core" 

 

 

function script F_Autobuff {

 

sc_start SC_BLESSING, 60000, 10;

sc_start SC_INCREASEAGI, 60000, 10;

return;

}

 

- script deathmatch_core -1,{

 

callfunc("F_Autobuff");

end;

}

 

Change log

 

 

Cell PvP 1.7

1. Fix & Cleanup some code

2. Fix timer info when walkout cell pvp

3. support rAthena SVN revision 12425+

enjoy!

 

I found a situation, when I warp into the normal PVP map (not cell pvp map),

the right under corner it always flash "1/1" .....is it bug for this patch?

Edited September 20, 2014 by Darkpurple

[Lelouch vi Britannia]

After compiling i found this...

 

atcommand.c: In function ‘atcommand_mapmove’:
atcommand.c:495: warning: suggest parentheses around ‘&&’ within ‘||’

pc.c: In function ‘pc_isUseitem’:
pc.c:4559: warning: suggest parentheses around ‘&&’ within ‘||’
pc.c: In function ‘pc_memo’:
pc.c:5368: warning: suggest parentheses around ‘&&’ within ‘||’
pc.c: In function ‘pc_dead’:
pc.c:7397: warning: suggest parentheses around ‘&&’ within ‘||’

skill.c: In function ‘skill_castend_nodamage_id’:
skill.c:6420: warning: suggest parentheses around ‘&&’ within ‘||’

Edited September 21, 2014 by Lelouch vi Britannia

[Napster]

I will try fixed later next version

if found bug please report

 

thank you

[Lordok]

SVN Revision: '17706'

Bug01
If the target get a PC SC_ status (buff or deBuff) area Skills dont Affect. Example: Magnus vs Undead (evil druid card), damage but if the unDead got Agi or Assump or Kyrie, the Magnus dont deal Damage.

 

Bug02
Status Alter vs Element. PC_Undead enemy got Poison, Silence and Curse status o.O

 

Fix - My Bad >.<

Edited November 20, 2014 by Lordok

[ekkapap981]

i am little speak englist. i am test compile src.    

 

bug       

1.i can not use skill dispell attack player

2. in pvp map( not cell pvp ) lower right player member  example 1/2 flashing alway.

 

 

Napster please fix bug i cant use src cell pvp in rathena revision 12425

Edited February 5, 2015 by ekkapap981

[Darkpurple]

i am little speak englist. i am test compile src.    

 

bug       

1.i can not use skill dispell attack player

2. in pvp map( not cell pvp ) lower right player member  example 1/2 flashing alway.

 

 

Napster please fix bug i cant use src cell pvp in rathena revision 12425

 

Same bug 2 problem.

[anacondaq]

Bumb for that. Can confirm last two bugs in this topic.

[4n0biz]

i am little speak englist. i am test compile src.    

 

bug       

1.i can not use skill dispell attack player

2. in pvp map( not cell pvp ) lower right player member  example 1/2 flashing alway.

 

 

Napster please fix bug i cant use src cell pvp in rathena revision 12425

same 2

Edited July 18, 2015 by 4n0biz

[Deleted User]

Any chances to UPDATE this to latest GIT

[amplove]

if (dstsd && dstsd->spiritball && (sd == dstsd || map_flag_vs(src->m) || (sd && sd->duel_group && sd->duel_group == dstsd->duel_group)) &&

- if (dstsd && dstsd->spiritball && (sd == dstsd || map_flag_vs(src->m)) && ((dstsd->class_&MAPID_BASEMASK) != MAPID_GUNSLINGER || (dstsd->class_&MAPID_UPPERMASK) != MAPID_REBELLION))

[Haikenz]

could someone post a diff compatible with the current git of rAthena

[solid2005]

i didn't test this code. i try my best to help you.

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

Extended_Cell_PvP_1.7.1.patch

[Haikenz]

4 hours ago, solid2005 said:

i didn't test this code. i try my best to help you.

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

Extended_Cell_PvP_1.7.1.patch

First of all I want to thank you for helping me.
Well, compiled right, but only gave this warning, what would it be?

@Edit ~Solved

clif_messagecolor(sd,color_table[COLOR_YELLOW], e_msg, false, SELF);

change

clif_messagecolor(&sd->bl, color_table[COLOR_YELLOW], e_msg, false, SELF);

@Edit 2

This appeared when running the emulator, can I change it in const.txt for this? or will it conflict?

[Status]: Done reading '2291' entries in 'db/const.txt'.
[Error]: script_set_constant: Attempted to overwrite existing constant 'CELL_PVP' (old value=10, new value=16).
[Error]: script_set_constant: Attempted to overwrite existing constant 'CELL_CHKPVP' (old value=16, new value=22).

const.txt

CELL_PVP		10
CELL_CHKPVP	16

to

CELL_PVP		16
CELL_CHKPVP	22

@Edit 3

even changing the error still appears in the emulator

[Error]: script_set_constant: Attempted to overwrite existing constant 'CELL_PVP' (old value=16, new value=16).
[Error]: script_set_constant: Attempted to overwrite existing constant 'CELL_CHKPVP' (old value=22, new value=22).

 

Edited September 18, 2017 by Dream Catcher

[solid2005]

try to remove CELL_PVP and CELL_CHKPVP at const.txt.

i did not saw that const.txt have a cell_pvp and cell_chkpvp cause i already input at the script_constants. may that cause the problem.

[Mithrandir]

Hello

Buenos dias, he tenido un problema con este diff

He implementado todo y en el servidor corre bien, pero cuando me salgo de la celda de pvp me sale este error y se apaga el mapa server:

[Error]: Server received crash signal! Attempting to save all online characters!
Me podrian ayudar porfavor? 

-------------------------------------
Good morning, I had a problem with this diff

I have implemented everything and it runs fine on the server, but when I leave the pvp cell I get this error and the server map turns off:

[Error]: Server received crash signal! Attempting to save all online characters!
Could you please help me?

[inwnutza69]

map.cpp: In function ‘void map_setcell(int16, int16, int16, cell_t, bool)’: map.cpp:3135:8: error: ‘CELL_PVP’ was not declared in this scope case CELL_PVP: map[m].cell[j].pvp = flag; break; // Addon ^ map.cpp: In function ‘int map_pvp_area(map_session_data*, bool)’: map.cpp:4072:13: warning: switch condition has type bool [-Wswitch-bool] switch(flag)

[Blackrockxii]

hlep

9>e:\server apple-ro 2018 new\src\map\unit.cpp(703): error C2664: 'void clif_messagecolor_target(block_list *,unsigned long,const char *,bool,send_target,map_session_data *)': cannot convert argument 1 from 'map_session_data *' to 'block_list *'
9>e:\server apple-ro 2018 new\src\map\unit.cpp(703): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
9>Generating Code...
 

Quote

 

// Addon Cell PVP [Napster]
    if (bl->type == BL_PC)
    {
        struct map_session_data* sd = (TBL_PC*)bl;
        unsigned int tick = gettick();

        if (sd && sd->pvpcan_walkout_tick && !map_getcell( sd->bl.m, x, y, CELL_CHKPVP ) ) {
            if ( DIFF_TICK(tick, sd->pvpcan_walkout_tick) < battle_config.cellpvp_walkout_delay )
            {
                int e_tick = (battle_config.cellpvp_walkout_delay - DIFF_TICK( tick, sd->pvpcan_walkout_tick))/1000;
                char e_msg[150];
                if( e_tick > 99 )
                        sprintf(e_msg, msg_txt(sd, 1599), sd->status.name, (double)e_tick / 60); 
                else
                        sprintf(e_msg, msg_txt(sd, 1600), sd->status.name, e_tick+1);

                clif_messagecolor(sd,color_table[COLOR_YELLOW], e_msg, false, SELF);
                return 0;
            }
        }
    }

 

 

[myserver]

whats wrong ???

 

some script are not there.

[myserver]

I used latest I cant find the others script to svn

[noobzter003]

I was able to make this source work in latest git of rathena, 

but i have one problem, how to make this PVP with user counting instead of PK.

i want something like this, tq

 

Edited July 4, 2020 by noobzter003

[ScarrFace]

On 7/4/2020 at 11:45 AM, noobzter003 said:

I was able to make this source work in latest git of rathena, 

but i have one problem, how to make this PVP with user counting instead of PK.

i want something like this, tq

 

do you mind to share your diff?