Stolao's Weapon Mastery [v1.29] -Unsupported, Bug Fixes Only-

[spinzaku]

can't get it to run.. on latest rathena.

https://github.com/Stolao/Npc_Release/blob/master/Weapon_Mastery/WeaponMastery_v1.26.txt

[Stolao]

can't get it to run.. on latest rathena.

https://github.com/Stolao/Npc_Release/blob/master/Weapon_Mastery/WeaponMastery_v1.26.txt

ya aperently 1.26 doesnt work but 1.22 does

[spinzaku]

1.22 still errors:

 

 

[Stolao]

1.22 still errors:

https://github.com/Stolao/Npc_Release/tree/master/Weapon_Mastery

 

Update

1.26 -> 1.29

[spinzaku]

Thank you! its running now.

 

@wi works

@winfo doesn't work

 

is there any other commands? or any info/spreadsheets of bonuses or stats gain per level?

[Stolao]

Thank you! its running now.

@wi works

@winfo doesn't work

is there any other commands? or any info/spreadsheets of bonuses or stats gain per level?

I'll take a look at @winfo but as for spreadsheet all I have is

https://github.com/Stolao/Npc_Release/blob/master/Weapon_Mastery/WeaponMastery_Details_v1.20.txt

Though I think that's not completely up to date but gives a general idea

[Bringer]

nice script

Edited June 19, 2016 by DrewxD

[Mad Walker]

awesome but is there any way to make the following bonuses show on alt + a(stat)

[Stolao]

awesome but is there any way to make the following bonuses show on alt + a(stat)

what?

[Mad Walker]

 

awesome but is there any way to make the following bonuses show on alt + a(stat)

what?

 

I mean just like this one, additional stats from safeguard not visible on alt + a?

 

[Stolao]

It does on my test servers, what git version are you using and do you have any errors?

[Mad Walker]

I tried it on the latest revision of rathena. July 11. No errors on the map server

[Stolao]

I tried it on the latest revision of rathena. July 11. No errors on the map server

 

 

works fine for me, are you letting activating pccalcevent (change map, add stats, add skill point, buff/debuff) after raising your weapon level?

[Mad Walker]

okay, is it compatible to other emulators like herucles?

[Stolao]

okay, is it compatible to other emulators like herucles?

I do not support for Hercules , I believe to make it work for them all you need to do in implement onpccalcevent but I may be mistaken.

[DutchDuck]

I keep having errors in my mapserver

 

it works though stats and all are added but i tryed it with

 

- script ..................   then i got the not visible on map thing

 

and when i add it to a map this happends ... 

Edited August 3, 2016 by DutchDuck

[Stolao]

I keep having errors in my mapserver

it works though stats and all are added but i tryed it with

- script .................. then i got the not visible on map thing

and when i add it to a map this happends ...

The latest should not have that issue

https://github.com/Stolao/Npc_Release/blob/master/Weapon_Mastery/WeaponMastery.txt

[birdkung]

[Warning]: npc_event: player's event queue is full, can't add event 'PCSTATCALC::OnPCStatCalcEvent' !

 

v 1.35

[Deleted User]

src\map\map.h

Look for:

Quote

#define MAX_EVENTQUEUE

Increase what values you liked.

Don't forget to recompile your emulator.

 

[Synel]

Not sure if Stalao is still looking for feedback but I'm gonna leave this here in case he come's across it. 

Using it on a custom server I've been setting up. There's only one real issue that I'm having. I haven't been able to fix it myself and that has to do with the level up message. I believe the message is supposed to be:

"X mastery has increased to level X!"

The problem is that that whatever level you've reached has a 1 added to it. Not one number higher but a 1 added afterward. After looking at the script I think this has to do with the way the script is written but it both functions correctly in that it displays the right level and doesn't in that it always adds a 1 to the level. (E.G. at level 12 it would say "X mastery has increased to 121!" 

I enabled dual wielding for classes other than assassin and combined with this script it's had some pretty interesting effects. Essentially the way the script is set up by default you get a standard bonus for the main hand with a half bonus to the offhand. If you have dual wielding of various weapons enabled you effectively see the same thing happen for any combination with the exception of the use of a shield, but I believe that's because Stalao made the script such that any shield combo runs as safeguard. So for instance, if you used a sword and a dagger you'd get a standard onslaught bonus with a 50% swiftness bonus. Same thing for X weapon + Y weapon of any combo.

Anyway, if you see this Stalao thank you for the script. It's been awesome so far. 

Edited March 29, 2017 by Synel

[BlackStarS]

It's so funny！I will apply it in my server

[Stolao]

On 3/29/2017 at 9:56 AM, Synel said:

Not sure if Stalao is still looking for feedback but I'm gonna leave this here in case he come's across it. 

Using it on a custom server I've been setting up. There's only one real issue that I'm having. I haven't been able to fix it myself and that has to do with the level up message. I believe the message is supposed to be:

"X mastery has increased to level X!"

The problem is that that whatever level you've reached has a 1 added to it. Not one number higher but a 1 added afterward. After looking at the script I think this has to do with the way the script is written but it both functions correctly in that it displays the right level and doesn't in that it always adds a 1 to the level. (E.G. at level 12 it would say "X mastery has increased to 121!" 

I enabled dual wielding for classes other than assassin and combined with this script it's had some pretty interesting effects. Essentially the way the script is set up by default you get a standard bonus for the main hand with a half bonus to the offhand. If you have dual wielding of various weapons enabled you effectively see the same thing happen for any combination with the exception of the use of a shield, but I believe that's because Stalao made the script such that any shield combo runs as safeguard. So for instance, if you used a sword and a dagger you'd get a standard onslaught bonus with a 50% swiftness bonus. Same thing for X weapon + Y weapon of any combo.

Anyway, if you see this Stalao thank you for the script. It's been awesome so far. 

Replied to other topic about this, pushing update soon

[twiggs62]

Hi there sir , i was using the updated weapon mastery , i found out something .. its about the ranged mastery itself .. example i am a ranger with mastery like lvl 50, then i tried to clicked the healer and test my damage , my damage was around 150k on the dummy, after that i tried to buff like "improve concentration" and my damage drag down like 130k , i test it again and yes it is the same .. is there any problem with the ranged? pls help

[Stolao]

What's your stats?

 

Because the main value scales with primary stat, only thing I can think of. It works fine and not op on my server.

[twiggs62]

sir stolao , i am proud of you weapon mastery system and its great on my server !! thumbs up to your work ,

is there any command that will reset all players mastery ? because i had a mistake .. i set up the max mastery in lvl 500 at first then changed it in lvl 128 default,

however some of my players had like lvl 300 weapon mastery , is it gonna stuck at lvl 128 even though they have lvl 300 weapon master ?>??

 

thank youuuu .....