themon Posted November 23, 2013 Posted November 23, 2013 (edited) item_db.txt to item_db.conf http://haru.ws/hercules/itemdbconverter/ 13114,P_Revolver3,Eden Revolver III,4,0,,0,76,,7,0,0x41000000,63,2,34,3,60,0,17,{ bonus bHit,-5; },{},{}13115,Upg_Revolver,Upg Revolver,4,20,,500,35,,7,1,0x41000000,63,2,34,3,1,1,17,{ bonus bBaseAtk,(getrefine()*5); bonus bLongAtkRate,(getrefine()*2); if(BaseLevel>70) bonus bBaseAtk,(((BaseLevel-70)/10)*5); },{},{}13116,Novice_Revolver,Novice Revolver,4,0,,500,20,,7,0,0x41000000,63,2,34,1,1,0,17,{ bonus bHit,-5; },{},{}13118,Spark_Light,Spark Light,4,1,,100,0,,,,0x41000000,63,2,34,1,1,1,17,{},{},{}13119,Spark_Of_Freedom,Spark Of Freedom,4,1,,100,100,,,,0x41000000,63,2,34,3,1,1,17,{},{},{} item_db: (/******************************************************************************************* Entry structure ******************************************************************************************************************************{// =================== Mandatory fields ===============================Id: ID (int)AegisName: "Aegis_Name" (string, optional if Inherit: true)Name: "Item Name" (string, optional if Inherit: true)// =================== Optional fields ================================Type: Item Type (int, defaults to 3 = etc item)Buy: Buy Price (int, defaults to Sell * 2)Sell: Sell Price (int, defaults to Buy / 2)Weight: Item Weight (int, defaults to 0)Atk: Attack (int, defaults to 0)Matk: Magical Attack (int, defaults to 0, ignored in pre-re)Def: Defense (int, defaults to 0)Range: Attack Range (int, defaults to 0)Slots: Slots (int, defaults to 0)Job: Job mask (int, defaults to all jobs = 0xFFFFFFFF)Upper: Upper mask (int, defaults to any = 0x3f)Gender: Gender (int, defaults to both = 2)Loc: Equip location (int, required value for equipment)WeaponLv: Weapon Level (int, defaults to 0)EquipLv: Equip required level (int, defaults to 0)EquipLv: [min, max] (alternative syntax with min / max level)Refine: Refineable (boolean, defaults to true)View: View ID (int, defaults to 0)BindOnEquip: true/false (boolean, defaults to false)Script: <"Script(it can be multi-line)">OnEquipScript: <" OnEquip Script (can also be multi-line) ">OnUnequipScript: <" OnUnequip Script (can also be multi-line) ">// =================== Optional fields (item_db2 only) ================Inherit: true/false (boolean, if true, inherit the valuesthat weren't specified, from item_db.conf,else override it and use default values)},******************************************************************************/{Id: 13114AegisName: "P_Revolver3"Name: "Eden Revolver III"Type: 4Buy: 0Atk: 76Range: 7Job: 0x41000000Upper: 63Loc: 34WeaponLv: 3EquipLv: 60Refine: falseView: 17Script: <" bonus bHit,-5; ">},{Id: 13115AegisName: "Upg_Revolver"Name: "Upg Revolver"Type: 4Buy: 20Weight: 500Atk: 35Range: 7Slots: 1Job: 0x41000000Upper: 63Loc: 34WeaponLv: 3EquipLv: 1View: 17Script: <"bonus bBaseAtk,(getrefine()*5);bonus bLongAtkRate,(getrefine()*2);if(BaseLevel>70) bonus bBaseAtk,(((BaseLevel-70)/10)*5);">},{Id: 13116AegisName: "Novice_Revolver"Name: "Novice Revolver"Type: 4Buy: 0Weight: 500Atk: 20Range: 7Job: 0x41000000Upper: 63Loc: 34WeaponLv: 1EquipLv: 1Refine: falseView: 17Script: <" bonus bHit,-5; ">},{Id: 13118AegisName: "Spark_Light"Name: "Spark Light"Type: 4Buy: 1Weight: 100Job: 0x41000000Upper: 63Loc: 34WeaponLv: 1EquipLv: 1View: 17},{Id: 13119AegisName: "Spark_Of_Freedom"Name: "Spark Of Freedom"Type: 4Buy: 1Weight: 100Atk: 100Job: 0x41000000Upper: 63Loc: 34WeaponLv: 3EquipLv: 1View: 17},) Edited November 23, 2013 by themon
LuLu Posted November 23, 2013 Posted November 23, 2013 why? I think the item_db.txt structure is fine and I have no any valid reason to switch. 2
nanakiwurtz Posted November 23, 2013 Posted November 23, 2013 It makes it more readable to human eyes, but just like LuLu has said, the current item_db.txt is fine for me
themon Posted November 23, 2013 Author Posted November 23, 2013 Well if that's rathena decision to be stuck to the old item_db.txt with so many unwanted ,,,,,,,,,,,, so be it
Boom Posted November 23, 2013 Posted November 23, 2013 (edited) We can't say that what we're currently using is "old" because some other emulator is using a "new" one. Our present item_db.txt is pretty much easier to edit especially on text editors that has the capability to edit swiftly through columns. Edited November 23, 2013 by Boom
Akkarin Posted November 23, 2013 Posted November 23, 2013 Several things need to be considered when thinking about something like that: How does that affect SQL usage How does that affect currently in-use item database tools How does that affect control panels How does that affect any custom source that reads from the item database How does that affect websites that read item data Judging by the responses in that announcement thread, it looks like very little regard was given for the above list. The only real benefit to users would be that it's easier to read. Personally, i see that as a waste of time.
Euphy Posted November 23, 2013 Posted November 23, 2013 There are plenty of programs that already do this, for example: http://rathena.org/board/files/file/2252-rathena-database-editor/ GUIs will do a better job than any formatting of a plain-text file.
orange Posted November 23, 2013 Posted November 23, 2013 just because its implemented in hercules doesnt mean it should be implemented here too 1
nanakiwurtz Posted November 23, 2013 Posted November 23, 2013 just because its implemented in hercules doesnt mean it should be implemented here too Yep, I agree with orange
Stolao Posted November 23, 2013 Posted November 23, 2013 PROS This is only visual more appealing CONS Increase document size by a large amount Breaks backwards combatability Breaks combatability with all 3rd party programs that read the item_db, websites control panels etc... Would this decrease processing times? More then likely not.
nanakiwurtz Posted November 23, 2013 Posted November 23, 2013 Combatibility? Maybe you mean compatibility That will be useful only if you're actively adding lots of custom items by yourself, but if you're just using the default item_db.txt, then probably you won't need it
QQfoolsorellina Posted November 23, 2013 Posted November 23, 2013 good for reading or writing item script
Akinari Posted November 24, 2013 Posted November 24, 2013 At the current point in time, the development team has decided not to merge this. I think the previous points given are enough.
Kido Posted November 24, 2013 Posted November 24, 2013 At the current point in time, the development team has decided not to merge this. I think the previous points given are enough. Totally agree, glad to hear that :3 Well if that's rathena decision to be stuck to the old item_db.txt with so many unwanted ,,,,,,,,,,,, so be it ow i can't imagine using this awful item_db and, what a pity! i'm not just saying this to provoke anyone i say this because that item_db totally does not fallow a basic principle that any devolper/scripter must fallow and that's the KISS PRINCIPLE http://en.wikipedia.org/wiki/KISS_principle what's next, a modification that makes the server lag? One thing is improve and other thing is getting worsen, no offense
Cydh Posted November 28, 2013 Posted November 28, 2013 For me, actually I'm 50-50 on this, how if this kind is implemented and just keep current CSV works. Just what I can't accept, because of it, makes whole item_db has too many lines, and the good point, it's easy to read. I just keep on my mind, if support 'old' item_db.txt and item_db.conf (so item_db.conf just works like db/item_db2.txt, that placed on same dir 'db', be read after item_db.txt itself) I can't resist, if the format is really really easy to read (well, just remind me about some kinds of PHP frameworks which use association array that make easy to edit) 1
Recommended Posts