nanakiwurtz

October Digest 2017

Recommended Posts

October Digest 2017
The following digest covers the month of October, 2017.

 

Staff Changes

  • None.

Development Highlights

  • CORE:
    • Migrated mob.c to mob.cpp (593ac627, 215aa158)
    • Migrated skill.c to skill.cpp (2606cf97)
    • Prefer static_casts instead of C casts (a5719e72)
    • Fixes homunculus being able to attack from Manhole (6b671774)
    • Corrected Overed Boost behavior (53ba373c)
    • Fixed a bug where refine bonuses was being incorrectly parsed (872cb42a)
    • Corrected character slot movement (fe75aeab, ae0da362)
    • Fixed a couple of warnings (fb882c4a, ff6722c9)
    • Removed SCRIPT_CALLFUNC_CHECK ifdef-directives (b8562932)
    • Resolved Skill Unit Database parsing issue (54a119c5)
    • Added a duplicate name check for the itemdb (828f7832, 48fcc92a)
    • Updated callshop selling list variables (fa425b83)
    • Updated Convex Mirror to match official behavior (951ff555)
    • Moved some remaining constants into src (f42c2ff2, b196b46b)
    • Added support for 3 new hat effects (8c2f727f)
    • Fixes required equipment check for skills (db37fc7d)
    • Adjusted script command bindatcmd (b4106eb9)
    • Implemented round,floor,ceil script commands (2830183e)
    • Added support for October clients (7dc6f757)
    • Fixed an import issue in mapindex (caf31521)
    • Enabled import for translations by default (3b219565)
    • Added 2 new NPC constants (93ad3a13)
    • Adjusted Item Shop trade restriction (5208d169)
    • Add check in configure to ensure C++ compiler (feb1ab9d)
    • Fixed searchstore for vendings with item id > 32k (18e0f0ab)
    • Fixed duplicated condition check (9772639a)
    • Fixed cmake (611dee07)
  • DATABASE:
    • Added AB_RENOVATIO as reproducible skill (2df18b12)
    • Implemented Terra Gloria cards (091738ac)
    • Implemented cards for Moscovia monsters (fc8534f7, b8844a09, 75653d9d)
    • Fixed missing comma in /db/re/item_db.txt (77a7bc2d)
    • Corrected Aegis names (7f9747c1, 0791adb4)
    • Fixed a duplicate Aegis name (319fc4d1)
    • Fixed Zaha Doll Hat not being refinable (800fd3da)
    • Fixed several item positions (3e78cc1c)
    • Added Mob DB placeholders (705cc5a8)
    • Updated Rebellion class (6a2c1229, 3ab39c4c)
    • Corrected Endure hit count behavior (ea0b54e0)
    • Added new 2016 Wedding skills (c73e10cb, 828f7d6e)
    • Fixed Crimson Saber equip class requirement (b90df893)
    • Added new Intro map for Renewal (c7d5b614, cb760a0a)
    • Corrected Dark Claw behavior (2c1df58b)
    • Corrected St. Patrick's Hat and Green Ale (d15b5fc5)
  • SCRIPT:
    • Updated Job Master NPC (2676d053)
    • Corrected some refiner checks (76923ac5)
    • Added an option to disable Baby Novice on Job Master (7991f47a)
    • Added missing warps from dali to dali02, dali02 to dali (f07ceced)
    • Added MC_CARTDECORATE as Platinum skill (10d40570)
    • Initial release of Sarah and Fenrir memorial (5ed21132, c9ee8eb6)
    • Added new Global Function `F_GetPlatinumSkills` (c76f3675)
  • OTHERS:
    • Updated .sql files to fix Random Options with negative values being stored as 0 in database (f20ac015)
    • Updated the contributing documentation (2c8ab4ff, 9210bf5d, 00682683)

Statistics

  • Excluding merges, 12 authors have pushed 84 commits to master and 168 commits to all branches.
  • On master, 128 files have changed.
  • There have been 12,094 additions and 5,820 deletions.
  • There are 38 merged Pull Requests and 14 Proposed Pull Requests.
  • There are 15 new Issues and 51 Closed Issues.

List of Contributors

  • @4144, @Akkarinage, @Aleos89, @anacondaqq, @Atemo, @Braniff, @cydh, @Daegaladh, @dastgir, @esu1214, @Everade, @exneval, @feltenc, @Haikenz, @hc3490, @hendra814, @jenkijo, @Jeybla, @joelolopez, @kaninhot004, @Lemongrass3110, @lunixoid, @M4karov, @mazvi, @Mickosis, @Mikegyver, @MuzTank, @RagnarokNova, @Ridley8819, @rpdigos, @Rytech2, @secretdataz, @shushusao, @Stolao, @ToiletMaster, @TokeiBuru, @uddevil, @Yuchinin

/no1Show your support to rAthena by submitting your Issue or Pull Requests! /mail
By providing enough useful info (Git Hash, Client Date, RE/Pre-RE, crashdump, how to reproduce, etc) you will help us to solve the issues faster

  • Upvote 2
  • Love 3
  • Like 1

Share this post


Link to post
Share on other sites

Was wondering if its worth tagging people who contribute. I imagine you copy the contributors from somewhere resulting in the lack of tags like @nanakiwurtz
I'm also not sure if its worth bothering with considering not all of those contributors seem to use the same name on rA/Git. Regardless, nice work as always.

Regards,
~Azura Skyy

Edited by Azura Skyy

Share this post


Link to post
Share on other sites

i understand that src is being moved from c to cpp. am just curious about the difference between having c and having cpp source.

Edited by Jhedzkie

Share this post


Link to post
Share on other sites

The problem with tagging a forum user in the digest is the name is not always the same between github and rA forum, so it's hard to keep track of who is who.
But if someone has a suggestion, please post it here.

Or maybe if there is another section inside the github Issue/PR template, like "Forum username" I think I can make it work.

On 11/4/2017 at 11:47 AM, Azura Skyy said:

Was wondering if its worth tagging people who contribute. I imagine you copy the contributors from somewhere resulting in the lack of tags like @nanakiwurtz
I'm also not sure if its worth bothering with considering not all of those contributors seem to use the same name on rA/Git. Regardless, nice work as always.

2

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now