Specialty Shops

[Stolao]

I wold like to suggest 2 new shop types (similar to cashshop)

 

1st being itemshop

Example:

<map name>,<x>,<y>,<facing>	itemshop	<NPC Name>	<sprite id>,<costitem>,<itemid>:<price>{,<itemid>:<price>...}

this would work just like a shop but would of course check for item defined in script

 

 

 

2nd would be more of a replacement to cashshop

Example:

 

<map name>,<x>,<y>,<facing>    pointshop    <NPC Name>    <sprite id>,<"points">,<itemid>:<price>{,<itemid>:<price>...}
 

 

this could use any player or account bound point types such as #CashPoints or PvpPoints, as defined in script

 

 

 

Now i know how to add these without any source changes I've done it a thousand times, I'm suggesting we eliminate alot of the complexity of those script types.

 

Thoughts?

 

 

[Akinari]

I agree with this.  I would also think not only does this make it extremely easy to make a item/point shop, but also decrease processing time as you wouldn't need to go through script engine like you have to now.  +1 from me.

[pr3p]

+1 for this, yah its a nice sir

[Limestone]

+1!!!!

[Euphy]

It's not *that* hard to write scripts for this... /hides

 

But on a serious note, I support this too.

References:

• Orcao's setcashpoints: [xantara] [orcao]
• Ind's custom cash shop: [rathena] [eathena]

[Stolao]

It's not *that* hard to write scripts for this... /hides

 

Not at all, XD

[Aleos]

I support this as well.

[Rebel]

Orcao's nor Xantara's setcashpoints is not working as of now in the new revision because of the change in "clif_parse_cashshop_buy"..... Hope it will be have a fix soon. Thanks.

[Reaper_san]

>_< i want this!!
anyone working on this?

[Reaper_san]

nothing yet?

[Akinari]

This modification is in the final stages actually.  We were just working on this today and hopefully a release will be done within the week.

[Stolao]

Oh yay <3

Can't wait for it.

[Akinari]

Sorry for the delay on this.  I've had some motivational problems after releasing that statement and I won't be around until likely later next week.  That's not to say someone else can't pick it up.  Attached the current diff (not sure if it's up to date to GIT).  Feel free to check it out.  This is courtesy of Aleos by the way.

 

 

newshops.diff

[Cydh]

Sorry for the delay on this.  I've had some motivational problems after releasing that statement and I won't be around until likely later next week.  That's not to say someone else can't pick it up.  Attached the current diff (not sure if it's up to date to GIT).  Feel free to check it out.  This is courtesy of Aleos by the way.

only if ur diff is up-to-date with latest rev, it would be nice

[Limestone]

i tried to apply this but i got compile warnings,

 

1>d:\ragnarok server\rathena\src\map\npc.c(1224): error C2143: syntax error : missing ';' before 'type'

1>d:\ragnarok server\rathena\src\map\npc.c(1226): error C2065: 'i_data' : undeclared identifier

1>  pc.c

1>d:\ragnarok server\rathena\src\map\npc.c(1226): error C2223: left of '->jname' must point to struct/union

[Lord Ganja]

 

i tried to apply this but i got compile warnings,

 

1>d:\ragnarok server\rathena\src\map\npc.c(1224): error C2143: syntax error : missing ';' before 'type'

1>d:\ragnarok server\rathena\src\map\npc.c(1226): error C2065: 'i_data' : undeclared identifier

1>  pc.c

1>d:\ragnarok server\rathena\src\map\npc.c(1226): error C2223: left of '->jname' must point to struct/union

 

 

I also encountered this error.. any help would be appreciated.. thank you.

[Cydh]

I have no idea until try it.

 

--- EDIT

ok tested, npc.c, change the line 1223 until 1229 to

case ITEMSHOP:
{
struct item_data *i_data = itemdb_exists(nd->u.shop.itemshop_nameid);
 
sprintf(output, msg_txt(sd,387), i_data->jname);
clif_broadcast(&sd->bl, output, strlen(output) + 1, 0x10, SELF);
clif_npcbuysell(sd,nd->bl.id);
} break;

just need curly.

 

hmm, the msg number, it's something

**OK, bump!**

 

Thank guys for attention and ur patience. Now, the shops are here 32fd3ee

(thank @Aleos & @Akinari too)

 

Here, my ugly test

The NPC file

prontera,155,158,4 itemshop ItemShop-Test1 123,501,1201:3,1202:5
prontera,155,160,4 itemshop ItemShop-Test2 123,502,2201:3,2202:5
prontera,155,162,4 pointshop PointShop-Test1 123,points,501:1,502:2
prontera,155,164,4 pointshop PointShop-Test2 123,#vippoints,678:5,607:5,608:3
prontera,155,166,4 pointshop PointShop-Test3 123,#votepoints,678:5,607:5,608:3

And the ugly results see attachments