My rAthena suggestions

[Limestone]

hmm.. another one suggestion.. kindly edit some of pre-re npc's, because there are npc's in pre-re are same in re npc's ( Sorry for bad English )

ex:

Job Change Quest, Training Grounds, and some of City Npc's

[EvilPuncker]

indeed, added

[Limestone]

Thanks EvilPuncker!

[EvilPuncker]

updated and bump! hopping to see some more added to rA!

[xazax]

Maybe some lazy times after work I'll add the most trivial ones

[Kichi]

There are

quests_13_1

quests_13_2

why episode 13.3 called quest_dicastes ?

[xazax]

Added some stuff, not too much though.

About kagerou & oboro skills, we should poke Rytech.

Anyways I wonder if it worth adding pre-re map_cache.dat, because users need to also add old maps to their client, and it is not hard to rebuild mapcache after that.

[EvilPuncker]

malufett got some already as you can see here

and about map_cache thing I've report it and Ind confirmed and I still think it is a good thing to add xD

[xazax]

Well, I'm with JoWei on this one, somehow I think a pre-re mapcache can cause more confusion only.

Anyways go-go Malufet hopefully he will manage to add them.

I will convert some more messages to msg_athena, and maybe start working on scriptable statuses .

[EvilPuncker]

my point about the split map_cache.dat thing is that since there are changes in the map, the npcs will be located badly since users wouldn't be able to walk to them or something like that btw I'm looking forward to see malufett work and you to add some more msgs =D

[Mystery]

They've began the process of:

- add some text from src into msg_athena so we may translate them easier, FI: the msg from item cooldown, the vending area limit msg, and some from atcommand.c

in r16495

[EvilPuncker]

oh yeah! btw added some eA merge patches made by me, hope any dev can merge them

[Ind]

First I'd like to thank you for the list, effort and interest. now my comments regarding the merges (in blue), note I've gone through every one of the links you've listed.

Some things that I want to see in rA:

- merge some changes from eA (note: anything related to cmake I didn't take into account, hope flaviojs commit some):

• r15115,r15116,r15118 (r15117 is already in rA) I've added the update to the clif repair, everything else I skipped, they've moved some packets into its own functions with no real benefit -- It actually makes the thing slower for it has to call a new node. I don't think its worth adding them for it's 'pretty' effect.
  
• r15119,r15120 clif.h and clif.c -> change before #ifdef PCRE_SUPPORT not made, because of fakename thing, hope any dev take a look and change as necessary (look here and here for source commit) Pretty much same reason as the above set. I didn't get the clif_displayformatted because although implemented its not used anywhere.
  
• r15130 This is already fixed in rathena
  
• r15139 The handling is incomplete
  
• r15140,r15141,r15142 postponed for i want to check out some stuff regarding
  
• r15153 These warnings are not present here and the typecasting in the dbmap implementation is not necessary for rathena thanks to gepards upgrade of the system
  
• r15154 changed messages types, didn't change the content.
  
• r15155 I'm not sure on the usefulness of Sql_PrintExtendedInfo (to me it sounds the same as saying "you're running windows ver blablabla" -- you already know it), I'll ask the other developers their opinions prior to taking action
  

[Vianna]

Maybe the packets moved to their own functions could be moved to their own inline functions instead, so there's no calling overhead and you still have the 'pretty' effect.

[xazax]

If a function defined in the same file it was called, ( especially if it was made static ), it is very likely, it will be inlined by the compiler automagically.

[Vianna]

Yeah, it's a micro-optimization. I don't think it's worth worrying about it. Let the compiler do its job =)

[Ind]

add monster hp bar from 4/04/2012 - Maintenance

do any of you got the packets for that specific hp bar?

[EvilPuncker]

add monster hp bar from 4/04/2012 - Maintenance

do any of you got the packets for that specific hp bar?

Maybe this help? post:117411

[Ind]

Thank you very much, added in r16669

[Maki]

Please split this topic (from now on) into separate topics for a more organization; that way we may label each topic as "Implemented". Thanks!

[kyeme]

Isuggest the Cash Shop icon (on mini map)

[Judas]

those are only possible on other types of clients, the ones we use ragre dont' have those icons available

[EvilPuncker]

bump for Reins of mount

[EvilPuncker]

updated some, btw still missing the msg from item cooldown into msg_athena.conf