Limestone Posted July 12, 2012 Group: Members Topic Count: 155 Topics Per Day: 0.03 Content Count: 647 Reputation: 16 Joined: 11/21/11 Last Seen: December 28, 2022 Share Posted July 12, 2012 hmm.. another one suggestion.. kindly edit some of pre-re npc's, because there are npc's in pre-re are same in re npc's ( Sorry for bad English ) ex: Job Change Quest, Training Grounds, and some of City Npc's Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 12, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted July 12, 2012 indeed, added Quote Link to comment Share on other sites More sharing options...
Limestone Posted July 12, 2012 Group: Members Topic Count: 155 Topics Per Day: 0.03 Content Count: 647 Reputation: 16 Joined: 11/21/11 Last Seen: December 28, 2022 Share Posted July 12, 2012 Thanks EvilPuncker! Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 24, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted July 24, 2012 updated and bump! hopping to see some more added to rA! Quote Link to comment Share on other sites More sharing options...
xazax Posted July 24, 2012 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted July 24, 2012 Maybe some lazy times after work I'll add the most trivial ones 1 Quote Link to comment Share on other sites More sharing options...
Kichi Posted July 24, 2012 Group: Members Topic Count: 25 Topics Per Day: 0.01 Content Count: 509 Reputation: 80 Joined: 11/20/11 Last Seen: October 3, 2020 Share Posted July 24, 2012 There are quests_13_1 quests_13_2 why episode 13.3 called quest_dicastes ? Quote Link to comment Share on other sites More sharing options...
xazax Posted July 24, 2012 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted July 24, 2012 Added some stuff, not too much though. About kagerou & oboro skills, we should poke Rytech. Anyways I wonder if it worth adding pre-re map_cache.dat, because users need to also add old maps to their client, and it is not hard to rebuild mapcache after that. Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 24, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted July 24, 2012 malufett got some already as you can see here and about map_cache thing I've report it and Ind confirmed and I still think it is a good thing to add xD Quote Link to comment Share on other sites More sharing options...
xazax Posted July 24, 2012 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted July 24, 2012 Well, I'm with JoWei on this one, somehow I think a pre-re mapcache can cause more confusion only. Anyways go-go Malufet hopefully he will manage to add them. I will convert some more messages to msg_athena, and maybe start working on scriptable statuses . Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 25, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted July 25, 2012 my point about the split map_cache.dat thing is that since there are changes in the map, the npcs will be located badly since users wouldn't be able to walk to them or something like that btw I'm looking forward to see malufett work and you to add some more msgs =D Quote Link to comment Share on other sites More sharing options...
Mystery Posted July 25, 2012 Group: Members Topic Count: 94 Topics Per Day: 0.02 Content Count: 2192 Reputation: 252 Joined: 11/11/11 Last Seen: June 24, 2020 Share Posted July 25, 2012 They've began the process of: - add some text from src into msg_athena so we may translate them easier, FI: the msg from item cooldown, the vending area limit msg, and some from atcommand.c in r16495 Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 25, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted July 25, 2012 oh yeah! btw added some eA merge patches made by me, hope any dev can merge them Quote Link to comment Share on other sites More sharing options...
Ind Posted July 26, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.04 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Share Posted July 26, 2012 First I'd like to thank you for the list, effort and interest. now my comments regarding the merges (in blue), note I've gone through every one of the links you've listed. Some things that I want to see in rA: - merge some changes from eA (note: anything related to cmake I didn't take into account, hope flaviojs commit some): r15115,r15116,r15118 (r15117 is already in rA) I've added the update to the clif repair, everything else I skipped, they've moved some packets into its own functions with no real benefit -- It actually makes the thing slower for it has to call a new node. I don't think its worth adding them for it's 'pretty' effect. r15119,r15120 clif.h and clif.c -> change before #ifdef PCRE_SUPPORT not made, because of fakename thing, hope any dev take a look and change as necessary (look here and here for source commit) Pretty much same reason as the above set. I didn't get the clif_displayformatted because although implemented its not used anywhere. r15130 This is already fixed in rathena r15139 The handling is incomplete r15140,r15141,r15142 postponed for i want to check out some stuff regarding r15153 These warnings are not present here and the typecasting in the dbmap implementation is not necessary for rathena thanks to gepards upgrade of the system r15154 changed messages types, didn't change the content. r15155 I'm not sure on the usefulness of Sql_PrintExtendedInfo (to me it sounds the same as saying "you're running windows ver blablabla" -- you already know it), I'll ask the other developers their opinions prior to taking action 2 Quote Link to comment Share on other sites More sharing options...
Vianna Posted July 26, 2012 Group: Members Topic Count: 0 Topics Per Day: 0 Content Count: 47 Reputation: 8 Joined: 12/06/11 Last Seen: January 13, 2013 Share Posted July 26, 2012 Maybe the packets moved to their own functions could be moved to their own inline functions instead, so there's no calling overhead and you still have the 'pretty' effect. Quote Link to comment Share on other sites More sharing options...
xazax Posted July 26, 2012 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted July 26, 2012 If a function defined in the same file it was called, ( especially if it was made static ), it is very likely, it will be inlined by the compiler automagically. Quote Link to comment Share on other sites More sharing options...
Vianna Posted July 26, 2012 Group: Members Topic Count: 0 Topics Per Day: 0 Content Count: 47 Reputation: 8 Joined: 12/06/11 Last Seen: January 13, 2013 Share Posted July 26, 2012 Yeah, it's a micro-optimization. I don't think it's worth worrying about it. Let the compiler do its job =) Quote Link to comment Share on other sites More sharing options...
Ind Posted August 19, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.04 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Share Posted August 19, 2012 add monster hp bar from 4/04/2012 - Maintenance do any of you got the packets for that specific hp bar? Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted August 20, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted August 20, 2012 add monster hp bar from 4/04/2012 - Maintenance do any of you got the packets for that specific hp bar? Maybe this help? post:117411 Quote Link to comment Share on other sites More sharing options...
Ind Posted August 20, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.04 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Share Posted August 20, 2012 Thank you very much, added in r16669 2 Quote Link to comment Share on other sites More sharing options...
Maki Posted August 20, 2012 Group: Members Topic Count: 146 Topics Per Day: 0.03 Content Count: 1195 Reputation: 467 Joined: 11/15/11 Last Seen: April 11, 2023 Share Posted August 20, 2012 Please split this topic (from now on) into separate topics for a more organization; that way we may label each topic as "Implemented". Thanks! 1 Quote Link to comment Share on other sites More sharing options...
kyeme Posted August 21, 2012 Group: Members Topic Count: 10 Topics Per Day: 0.00 Content Count: 164 Reputation: 12 Joined: 03/08/12 Last Seen: Sunday at 10:22 PM Share Posted August 21, 2012 Isuggest the Cash Shop icon (on mini map) Quote Link to comment Share on other sites More sharing options...
Judas Posted August 21, 2012 Group: Members Topic Count: 26 Topics Per Day: 0.01 Content Count: 2244 Reputation: 182 Joined: 11/19/11 Last Seen: April 14 Share Posted August 21, 2012 those are only possible on other types of clients, the ones we use ragre dont' have those icons available Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted September 1, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted September 1, 2012 bump for Reins of mount Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted November 3, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Author Share Posted November 3, 2012 updated some, btw still missing the msg from item cooldown into msg_athena.conf Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.