Mob chat not working - help

[iraciz]

About the mob_chat_db in trunk,
is not working, I already tested with wounded morroc in battle , and not message is shown.

Mobskill.db
//5% HP - Dragon Fear
1917,Wounded Morroc@NPC_DRAGONFEAR,chase,659,10,10000,0,600000,no,self,myhpltmaxrate,5,,,,,,,17
1917,Wounded Morroc@NPC_DRAGONFEAR,attack,659,10,10000,0,600000,no,self,myhpltmaxrate,5,,,,,,,17
//10% HP - Talk
1917,Wounded Morroc@NPC_TALK,chase,682,10,10000,0,600000,no,self,myhpltmaxrate,10,,,,,,,16
1917,Wounded Morroc@NPC_TALK,attack,682,10,10000,0,600000,no,self,myhpltmaxrate,10,,,,,,,16

mob_chat_db
16#0xFF0000#Oh, you're stronger than I thought!
17#0xFF0000#No, this can't be happening! I'm Satan Morroc, Demon King of Destruction!

How to display this?

[OptimusM]

do you have the correct files inside your GRF? i think u can make that on XML format inside your GRF, like this:

Make a simple text ând edit it like this:
 

<?xml version="1.0" encoding="UTF-8" ?>
<enemy_monster_talk_table>
	<alarm>
		<discovery>	Tick Tock... Tick Tock... Tick Tock...	</discovery>
		<discovery>	Alert!! Alert!! It's the enemy!! Enemy!!	</discovery>
		<attack>	Eat this!!	</attack>
		<attack>	It is now your time to die!!	</attack>
		<hp50>	Tick Tock... It's not quite time yet!... Tick Tock...	</hp50>
		<hp25>	Tick... No! Not yet!! No!!... Tock	</hp25>
		<kill>	Muhahahaha... Ding Ding Ding!!!	</kill>
		<dead>	Tick Tock, the Alarm is dead...	</dead>
		<dead>	Tick...... Tock......	</dead>
	</alarm>
	<alice>
		<attack>	I thought it was my master but to think it was you...	</attack>
		<attack>	What is this!?! You're not my master!!!	</attack>
		<attack>	You're not my master and you pretend to be! How rude!!	</attack>
		<attack>	Why are you lying to me? Do you want to be my master that badly?	</attack>
		<hp50>	I can't die yet! Not until I see my master...	</hp50>
		<hp25>	Ma... Master... Please come back... I can't stand this any longer...	</hp25>
		<kill>	Be proud of me, Master. I have killed the imposter.	</kill>
		<dead>	Finish me... You're not coming back, are you master...	</dead>
		<dead>	It's too late... I can't see my master anymore...	</dead>
		<dead>	It's too late... Even if my master could save me...	</dead>
	</alice>
</enemy_monster_talk_table>

 

After that, save it on your Data (root folder) as "monstertalktable.xml"

If u need how can u make a new entry on that, this is the way to do it

<enemy_monster_talk_table>: This is the start of the monster talk table. Leave it as it is =3! 
<mob_db_name_here>: The mob_db.txt first name you see, after the ID, goes here =3! Its used to identify the mob 
<discovery>%TAB%Text Here%TAB%</discovery>: This is an event, same as the one below. When a monster see you, this one will be displayed =3! 
<attack>%TAB%Text Here%TAB%</attack>: When a monster attacks you, this one will be displayed O_O! 
<hp50>%TAB%Text Here%TAB%</hp50>: When a monster's hp is at 50%, this one will be displayed o..o! 
<hp25>%TAB%Text Here%TAB%</hp25>: When a monster's hp is at 25%, this one will be displayed x,x 
<kill>%TAB%Text Here%TAB%</kill>: When a monster kills a character/player, this one will be displayed T~T! 
<dead>%TAB%Text Here%TAB%</dead>: When a monster dies by player hand, this one will be displayed ^__^! 
</mob_db_name_here>: The same name of the mob_db.txt, the one after the ID. 
</enemy_monster_talk_table>: Keep it like this.

Information obtained from Her*** (Voldemort.ws)


 

[iraciz]

Dear Optimus, this is monstertalk table you brought, 
the mob_chat is the issue reported, when you fight Nydhogg, Wounded, or Lost Dragon the will display the script located in db, mob_chat_db.txt

is not displaying, how to enable it? any conf?

 

[OptimusM]

@iraciz
Sorry for late response, but it is working, the only detail is when u use the NPC_TALK at lvl 10 will fail.

 somehow when u use it at lvl 1 the mob_chat_db works perfectly but not by default at lvl 10.

[Chun3]

Enable Monster Tables on hexed diff.

[iraciz]

After almost 10 months of  this

I had found the solution

SCR/MAP/MOB.CPP

line 81

add:  int a = mob_chat_db[id].msg_id;

example:

//Dynamic mob chat database
std::map<short,struct mob_chat> mob_chat_db;
struct mob_chat *mob_chat(short id) {
    int a = mob_chat_db[id].msg_id;
    return util::map_find( mob_chat_db, id );
}
 

Success:

 

[Kreustoo]

Be careful with that hotfix! @iraciz
I really not tested that much, maybe try catch it or just change it to :

struct mob_chat a = mob_chat_db[id];
 

At least you'll not try to .msg_id a null value, it'll be fixed too, but I really can't explain why and what will be the implication of that :/. But I was happy to help you ^^.

 

I tryed replacing id by 0 and some other value, it does not fix the problem but THAT exact line does.

[iraciz]

thanks, we should update when the issue is fixed.

[iraciz]

It's done, here:

https://github.com/rathena/rathena/pull/4908/commits/e2c6919bc450e08f8bf0e1209d93e9f81b104f9c

finally.

Credits to Kreustoo  and dev team.

Edited July 5, 2020 by iraciz