[Debug]: npc_scriptcont: 'Unknown NPC'

[LearningRO]

hei, in my console i get this error

 

[Error]: buildin_delitem: failed to delete 50 items (AID=2000169 item_id=6488).
[Debug]: Source (NPC): Thanks Ticket Machine at malangdo (215,119)
[Debug]: npc_scriptcont: 'Unknown NPC' (sd->npc_id=0) is not Thanks Ticket Machine (id=110365850).
[Debug]: npc_scriptcont: 'Unknown NPC' (sd->npc_id=0) is not Thanks Ticket Machine (id=110365850).
[Debug]: npc_scriptcont: 'Unknown NPC' (sd->npc_id=0) is not Thanks Ticket Machine (id=110365850)

somebody can help about this? and the meaning of this error?

[Functor]

I was able to reproduce it. I will share info about this vulnerability with developers. But in few days. I am not at home now. 

Edited January 31, 2019 by Functor

[Zell]

6 hours ago, melv0 said:

any news about this?? have developer try to fix this vulnerability?

Prob this

https://github.com/rathena/rathena/commit/25aaeec135409c735554f973a5c271c6be5acee6

[n0tttt]

Could it be because this other NPC's (malangdo,218,123,1    script    Namis#invest    545,4,4) OnTouch gets executed while you're on the other and sets the player current NPC id to 0 with its "end"?

Test removing this for now:

OnTouch:
	if (rand(2))
		emotion ET_SLEEPY;
	else
		specialeffect EF_SLEEPATTACK;
	end;

 

[AnnieRuru]

[Error]: buildin_delitem: failed to delete 50 items (AID=2000169 item_id=6488).

comes from this line
https://github.com/rathena/rathena/blob/master/npc/re/guild/invest_main.txt#L1579

this tells a lot
few days ago melvo show me a screenshot of someone trying to hack in his server, he claim that player is duping elunium

yes his map-server also spam with this kind of error

I also have no idea how the countitem can fail the check, but the delitem command can catch it, maybe some 3rd party tools can bypass it

[sader1992]

2 hours ago, AnnieRuru said:

[Error]: buildin_delitem: failed to delete 50 items (AID=2000169 item_id=6488).

comes from this line
https://github.com/rathena/rathena/blob/master/npc/re/guild/invest_main.txt#L1579

this tells a lot
few days ago melvo show me a screenshot of someone trying to hack in his server, he claim that player is duping elunium 

yes his map-server also spam with this kind of error 

I also have no idea how the countitem can fail the check, but the delitem command can catch it, maybe some 3rd party tools can bypass it 

yes , I have encounter the same issue at the same line in one of the server (it was beta test)
and after the gepard is on the problem just disappear
it make sense to be 3rd party software

 

however I couldn't find what was the issue

I think the best thing to do is make the delitem command return the number of the deleted items as extra check for those who done have any protection on their servers

or does the script auto stop on fail , I just woke up xD

Edited January 31, 2019 by sader1992

[LearningRO]

On 1/31/2019 at 11:25 AM, Functor said:

I was able to reproduce it. I will share info about this vulnerability with developers. But in few days. I am not at home now. 

how did u reproduce it? with 3rdparty software?. i just want to know :D. just answer yes or no

[Functor]

@melv0 Yes.

P.S. I sent info to developers of emulators.

[LearningRO]

6 hours ago, Functor said:

@melv0 Yes.

P.S. I sent info to developers of emulators.

okay now make sense

sometime i got this warning too?

http://prntscr.com/mdq6e5
 

does this also include 3rd party software?

[Functor]

Correct

[LearningRO]

any news about this?? have developer try to fix this vulnerability?