Jump to content

Ind

Members
  • Posts

    1260
  • Joined

  • Last visited

  • Days Won

    52

Everything posted by Ind

  1. As I was doing r16651 I've noticed the quest system has these in (struct) map_session_data int quest_index[MAX_QUEST_DB];// 8.000 byte struct quest quest_log[MAX_QUEST_DB];// 72.000 byte (MAX_QUEST_DB is defined in mmo.h by default as 2k) struct s_quest_db { int id; // 4 unsigned int time; // 4 int mob[MAX_QUEST_OBJECTIVES]; // 4 * 3 int count[MAX_QUEST_OBJECTIVES];// 4 * 3 int num_objectives;// 4 }; // 4 + 4 + (4*3) + (4*3) + 4 = 36 (reference) which is hum...72.000 byte...about to 70kb per player. imo this is...absurd O_O (i didn't really measure compared to the whole map_session_data but by taking a glance at it i'd bet it is the source of at least 25% of each map_session_data instance). and its most wasted data since like no players will have the 2k quests' data. I propose the system be reviewed. for example, as the first thing that comes to my mind, use pointers so that if a player has 20 quests it spends 20*36=720 bytes instead of wasting 72.000 bytes. post your thoughts opinions call me a performance megalomaniac, whatever you like. but post.
  2. whops, my bad. you're right. thank you.
  3. Monthly Digest #4 Hello and welcome, this is rAthena's fourth development digest. Below is a small report for July 12th - August 14th period (past 33 days). Development Team @Cookie joined as Core Developer joined as Script / DB Developer @Joseph joined as Script / DB Developer @Kisuka joined as Script / DB Developer @Salepate joined as Core Developer Development Highlights Further npc/custom/ updates Improved Homun-S support New group permissions show_bossmobs, disable_pvm and disable_pvp Ability to bind atcommands to NPC events Initial Oboro/Kagerou Skill Support Favorite Item Tab Further Oboro/Kagerou Support NPC Folder Redesigned Item elvMax support Euphy's slaughtering spree of script file sizes (aka optimizations all over the place). Many skill behavior fixes by malufett and team. Misc. Stats During the period there were 218 commits. Of these 218 commits 97 were bug-fixes.
  4. no. your login server is coded to try to obtain the last_mac field.
  5. indeed we don't have. thats custom and therefore not rathena's fault.
  6. Another bugfix in r16625 regarding this feature, at this point I come to think this feature might be fully functional now.
  7. some #define was changed and you didn't recompile all 3 servers (btw even if you recompile its gonna break cause the define you changed was changed to a value higher than supported)
  8. I understand that, which is why I previously said your previous reply contained fair points.
  9. fair points, just to clarify. the implementation is pretty straightforward actually, say you already have the field being loaded by char server into (struct item)->unique, in pc.c::pc_additem just the following addition would be necessary. if( !item_data->unique && !itemdb_isstackable(data) ) item_data->unique = the_global_unique_id_counter++;
  10. This is something that has been requested for several times in the past, I'd like to know your opinions regarding this feature being built in. Specs from my proposal: Non-stackable items are given a unique ID stored as unsigned int 64 ( up to 18.446.744.073.709.551.615 ) Stackable items are not traceable in the current way they're stored; as when you get a red potion when you already have 10 the data from the new red potion is lost and the data that stores the 10 red potions gets it's amount += 1. Post all your opinions, thank you for your time.
  11. q eu lembre isso é qndo vc tem mais de uma versão e ele nao sabe escolher ou qndo a versao q vc tem não bate com o (esqueci o nome |: ehm o coiso q se o seu sistema eh 32 ou 64) vc pode tanto especificar com ./configure --with-zlib=??? ou tentar na sorte e mandar ele ignorar o 64 com ./configure --disable-64bit
  12. the last known bug from this feature has been fixed in r16555. should you step by any bugs please step by our core bug tracker :3 thank you
  13. baidu is not a user, it is a search engine crawler.
  14. sincerely i'm not much sure either. apparently the guild level is managed by the char server, and the exp is handled by a timer which is run every 10s -- the timer then sends the guild data to char server who then checks for level & other stuff, updates the data accordingly and sends it back to the map server.
  15. i'm not handing over any deadlines nor progress.
  16. sorry for the delay, started to implement this feature. all developers who submit their paypal addresses to us already have the initial support on their profiles. example: http://rathena.org/board/user/468-daegaladh/
  17. there is no need for a id entry in the combo db -- since the id value is not used in any other files the reference is not required, we can assign ids for them as they are parsed. Applied the update here: r16508
  18. First I'd like to thank you for the list, effort and interest. now my comments regarding the merges (in blue), note I've gone through every one of the links you've listed.
  19. in the command code you may use the following to call a npc run_script(npc_name2id("NPCName"))->u.scr.script,0,sd->bl.id,fake_nd->bl.id);
  20. join me at congratulating our beloved admin who made rathena a reality. HAPPY B-DAY JMAN <3
  21. this is a problem present since eAthena, bugreport:309 details it. the item hash or "tagging" prevents exploits like thanks to kenpachi's item_combo_db we can now store all combos away from the items preventing the above scenario from taking place w/o the hash stuff, e.g. looping through the combo db once and checking for matching pairs, however that is quite inefficient (you see, we have about to 200 pairs of combos and 14 equipment slots, the loop would be awful), we need a clever way to fix this bug (preferably away from that awfully huge loop). discuss / post your opinions / scream at me, whatever you like :3
  22. Monthly Digest #3 Hello and welcome, this is rAthena's third development digest. Below is a small report for June 12th - July 12th period (past 30 days). Development Team @Daegaladh joined as Script / DB Developer og2 returned as Script / DB Developer Development Highlights 2012-04-10 Client Support New Merchant Carts Exp Tables Update Couple New Item Bonuses Initial support for Homun-S New Izlude Kenpachi's item_combo_db.txt Euphy's /npc/custom overhaul Job Master Universal Rental [*]And many, many and many skill behavior fixes by malufett and team. Development Notes The src/map/config folder was moved to src/config, depending on your svn client it might not have deleted the old one, therefore if you still have it delete it (its no longer used nor changes to it will be read) in r16369 a exploit present since eAthena regarding the mail system was fixed, make sure you don't miss that update. Misc. Stats During the period there were 136 commits. Of these 136 commits 68 were bug-fixes.
×
×
  • Create New...