If Condition Help

[nasagnilac]

what is the best way to summarize this?

				if ($@members > 4) {
					set .@greward,1;							// 5-9 Members

					if ($@members > 9){
						set .@greward,2;						// 10-14 Members

						if ($@members > 14){
							set .@greward,3; set .@areward,1;			// 15-19 Members

							if ($@members > 19){
								set .@greward,4; set .@areward,2;		// 20-24 Members
		
								if ($@members == 25){
									set .@greward,5; set .@areward,3;	// 25 Members
								}
							}	
						}					
					}			

				}

[painrugi]

use else if for condition 2 or more....

 

correct me if i'm wrong

[Dynasty]

if ($@members >= 5) {
set .@greward,1;// 5-9 Members
	}else if ($@members >= 10){
			set .@greward,2; // 10-14 Members
		} else if($@members >= 15){
				set .@greward,3; 
				set .@areward,1; // 15-19 Members
			} else if($@members >= 20){
						set .@greward,4; 
						set .@areward,2; // 20-24 Members
					}else if($@members == 25){
									set .@greward,5; 
									set .@areward,3;	// 25 Members
								} else if ($@members >= 26) end;

like this.. but i think if that is a rewards system you must do all the thinks inside the condicional { } (getitem, delitem) all of this... instead used another script for get the rewards.. is my point of view only..

[nasagnilac]

im using it in guild package.. does my script is correct?

[Dynasty]

I don't have enough experience to say that you script is wrong but the script that i modify probably work

Edited November 26, 2013 by Dynasty

[Patskie]

if ($@members > 4) set .@greward,1;

else if ($@members > 9) set .@greward,2;

else if ($@members > 14) { set .@greward,3; set .@areward,1; }

else if ($@members > 19) { set .@greward,4; set .@areward,2; }

else if ($@members == 25) { set .@greward,5; set .@areward,3; }

else end;

[Emistry]

@Patskie

your way...doesnt work fully....especially when the member is more than 4 ....

everytime they will just stuck at this part 

if ($@members > 4) set .@greward,1;   // even they have 25 member..still it's MORE THAN 4..

it should be something like this

if( $@members >= 25 ){
	set .@greward,5; set .@areward,3;
}else if( $@members > 19 ){
	set .@greward,4; set .@areward,2;
}else if( $@members > 14 ){
	set .@greward,3; set .@areward,1;
}else if( $@members > 9 ){
	set .@greward,2; set .@areward,2;
}else if( $@members > 4 ){
	set .@greward,1; set .@areward,1;
}

normally i would do checking for highest to lowest ....

Edited November 27, 2013 by Capuche
Typo.

[Patskie]

I just modify what the topic starter have posted. I realized now that it will stuck on the first if condition xD