Certain map weapon restriction

[rootKid]

HI I'd like to request the code that will make weapons unequipable on a certain map.

[Kisuka]

You can do this with scripting...

[AnnieRuru]

https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/db/re/item_noequip.txt

seems like I've tried, I'm able to save up to 32768, zone 11

perhaps the item_noequip.txt and skill_nocast_db.txt should make an update for it

[rootKid]

Well here is the thing, I don't want to enter each and every item that I don't want players to be able to equip on a certain map. I want the ability to block equipping depending on their equipment positions, for example they cannot equip anything on their right hand or left hand in prontera. This would be different because I don't have to enter every weapon and shield or w/e to the item_noequip.txt

Edited January 14, 2013 by kou

[Stolao]

Just write an onloadmapevent script for this.

[rootKid]

Could you show me an example?

[Emistry]

you can try this if you want...

https://rathena.org/board/index.php?/files/file/2505-%7B?%7D/

[rootKid]

That is pretty similar to adding items to the item_noequip.txt. I'm looking for a code that will actually make equipping things impossible on a certain map. Does not matter if they have it in their inventory. Now who can really help me with this? I'm sure it is possible. I don't want a script, else I wouldn't have posted here.

[AnnieRuru]

noitem mapflag

prontera	mapflag	noitem	4,5

item type 4 (weapon) and item type 5 (armor) can't equip in prontera map

since this is SVN discussion,

I dunno this modification should add into SVN or not

because this question also frequently asked in database/script request section

[Emistry]

you can try this too..

http://rathena.org/board/topic/77378-skillitem-map-restriction-now-supports-multiple-maps/

[rootKid]

Which SVN was the mapflag noitem feature added?

Edited January 19, 2013 by kou

[clydelion]

This should be moved in Source Request section. And to answer your question, this is a custom source mod made by Annie.

[Dori]

Is this mapflag officially implemented in rathena revisions or is this still a custom add-on?

I need to know cuz I'm looking for a way to block equipping in a certain map also. I tried to find 'noitem' in my src files, but couldn't find a match.

[AnnieRuru]

[paste=1a4xw30mq7va]

actually strtok is not thread safe ... I'm thinking writing a new one

ok done lol, quite fast

[paste=43c3y0h62jbk]

EDIT:

I think there's some problem with encoding ...

I use attachment for the time being

noitem_20140108_.patch

Edited January 8, 2014 by AnnieRuru

[Dori]

I got this warning during the recompiling process...
 

npc.c: In function ‘npc_parse_mapflag’:
npc.c:3707: warning: suggest parentheses around assignment used as truth value
npc.c:3716: warning: suggest parentheses around && within ||

And the map flag didn't work. I had the mapflag set like this for one of my maps

prontera mapflag noitem 4

 

This should block weapons from being equipped in that map, correct?

 

Well it didn't work, I was able to equip weapons.

[AnnieRuru]

download from the attachment, don't use pastebin

if you download from pastebin you'll get this problem

blame @Akkarin

I'm going to wear a maid costume and serve him some tea

[Dori]

download from the attachment, don't use pastebin

if you download from pastebin you'll get this problem

blame @Akkarin

I'm going to wear a maid costume and serve him some tea

 

I did. I downloaded the attachment. I applied the patch all well too.

[AnnieRuru]

I don't get any warning during compile ( of course no warning or else I've fix it )

prontera	mapflag	noitem	4

this is actually restricting ARMOR <.<

https://github.com/rathena/rathena/blob/master/doc/item_db.txt#L30

if you want to block WEAPON, use 5

[Dori]

oh right i forgot about the wep type changing.

 

 

About the warnings, my revision is 11800. I'm not at the latest revision, and maybe that's why I'm getting the warning?

So, Could you tell me what that warning means and maybe tell me how I can get rid of it?

 

The warnings are coming form the first and the last line in npc.c:

 

		if ( l = strlen(w4) ) {
			i = 0;
			while ( i <= l && k < MAX_RESTRICTED_LIST ) {
				if ( w4[i] != ' ' && w4[i] != '	' && w4[i] != ',' && w4[i] != '\0' ) {
					temp[j++] = w4[i];
				}
				else if ( w4[i-1] != ' ' && w4[i-1] != '	' && w4[i-1] != ',' ) {
					temp[j] = '\0';
					id = atoi( temp );
					if ( id >= IT_HEALING && id < IT_MAX || itemdb_exists( id ) )

Edited January 9, 2014 by Phenex

[AnnieRuru]

I got this warning during the recompiling process...

 

npc.c: In function ‘npc_parse_mapflag’:
npc.c:3707: warning: suggest parentheses around assignment used as truth value
npc.c:3716: warning: suggest parentheses around && within ||

how about you tell me whats the exact line in 3707 and 3716 ?

... or better off just show me the whole npc.c file

Edited January 9, 2014 by AnnieRuru

[Dori]

Sure.

The line are this:

if ( l = strlen(w4) ) {

And This:

if ( id >= IT_HEALING && id < IT_MAX || itemdb_exists( id ) )

Thank you!

npc.rar

[AnnieRuru]

seems like you are using different compiler than mine

your compiler can even suggest me to write the code cleaner

try this one

noitem_20140110.patch

curious, tell me what's the compiler you are using ...

I'm using microsoft visual c++ 2010

[Dori]

Thank you, I will try this out. As for the compiler, it's the compiler provided by Asura hosting. So I'm not exactly sure what they use for the compiler ^^;

Edit: It works! No warnings~ Perfect! Thank you very much Annie Ruru!

Edited January 10, 2014 by Phenex

[AnnieRuru]

@Darkpurple asked to update this one so ...

noitem_20140828r.diff

the difference about this and official

is allow_equip_restricted_item just nullify the cards, but mine can unequip them