Expand conf files a bit...

[Peopleperson49]

There are several things that most people update from time to time through source edit. However, is it really necessary? The battle conf files are a collection of source edits that are placed in easy to reload documents. Why not do the same thing with stuff like max guild size, max vending, max party size, max party size, max produce list, etc... I just picked random stuff, but theres around 30 that are commonly modified. I'm sure theres a reason that you have to update the source files and recompile, but since I have made some of the edits myself and they work fine, I don't see why it can be done on the rAthena scale.

Peopleperson49

[EvilPuncker]

lol, I was just about to post about removing some of them xd

[GreenBox]

Those constants can't be changed via config because they are used for declaring arrays. As arrays must have a constant size(at least on MSVC), they cannot be initialized via a config file(well, they can but we will need to malloc and free the arrays, imo is alot of useless code).

[MarkZD]

• Is this idea good? Yes
  
• Is this idea useful? Yes
  
• Will this idea cause more problems than solutions? A little problem to developers, almost no problem to old users, but it'll be good in future. No problem to new users, and it'll help.
  
• Am I the only person that benefits from this? No
  
• Will other people not understand what I am posting? Yes, but it's easy to understand.(Usually, if not always someone won't understand, I think this question will always be yes, at least for the next centuries).
  

Edited June 12, 2012 by MarkZD

[Greed2k12]

You get my thumbs up

[Peopleperson49]

If you can't make a conf file, which I think would be awesome then my thought was to make a easy to edit diff. Include all the things that people usually edit. You change the settings and then patch the diff. I'm sure there are more than I listed below.

common/mmo.h
Max cart items
Max storage
Max guild storage
Max party
Max friends

map/itemdb.h
Max RANDITEM

map/map.h
Max mob skill
Max vending
Max event queue

map/pc.h
Max skill tree

map/skill.h
Max produce db
Max arrow db

Peopleperson49

[Nameless2you]

I understand the point your coming from but I don't see this being necessary, the only thing I can see that might be helpful might be adding something like config.c/h where the most useful things are declared that may possibly at later times be updated, instead of having to visit the mmo.h, mob.h and others..

[MarkZD]

I understand the point your coming from but I don't see this being necessary, the only thing I can see that might be helpful might be adding something like config.c/h where the most useful things are declared that may possibly at later times be updated, instead of having to visit the mmo.h, mob.h and others..

It's just same idea from the author's topic above your post, you say you don't get the point but you just said the same thing as his second solution, which is to include it all in one file to make it easy to change, but it's the same as the first suggestion too, just without txt file part.

[xazax]

Max level is also one of the most requested stuff to be moved to a config.

[Peopleperson49]

I really like the idea of putting it into one common src file to be updated. If you use a diff then it still has to be recompiled, so the src files is much easier! When can you get started?

Peopleperson49