Peopleperson49 Posted June 6, 2012 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Share Posted June 6, 2012 There are several things that most people update from time to time through source edit. However, is it really necessary? The battle conf files are a collection of source edits that are placed in easy to reload documents. Why not do the same thing with stuff like max guild size, max vending, max party size, max party size, max produce list, etc... I just picked random stuff, but theres around 30 that are commonly modified. I'm sure theres a reason that you have to update the source files and recompile, but since I have made some of the edits myself and they work fine, I don't see why it can be done on the rAthena scale. Peopleperson49 1 Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted June 6, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Share Posted June 6, 2012 lol, I was just about to post about removing some of them xd Quote Link to comment Share on other sites More sharing options...
GreenBox Posted June 6, 2012 Group: Members Topic Count: 9 Topics Per Day: 0.00 Content Count: 303 Reputation: 101 Joined: 11/13/11 Last Seen: October 11, 2023 Share Posted June 6, 2012 Those constants can't be changed via config because they are used for declaring arrays. As arrays must have a constant size(at least on MSVC), they cannot be initialized via a config file(well, they can but we will need to malloc and free the arrays, imo is alot of useless code). 2 Quote Link to comment Share on other sites More sharing options...
MarkZD Posted June 12, 2012 Group: Members Topic Count: 6 Topics Per Day: 0.00 Content Count: 134 Reputation: 35 Joined: 02/27/12 Last Seen: April 5, 2022 Share Posted June 12, 2012 (edited) Is this idea good? Yes Is this idea useful? Yes Will this idea cause more problems than solutions? A little problem to developers, almost no problem to old users, but it'll be good in future. No problem to new users, and it'll help. Am I the only person that benefits from this? No Will other people not understand what I am posting? Yes, but it's easy to understand.(Usually, if not always someone won't understand, I think this question will always be yes, at least for the next centuries). Edited June 12, 2012 by MarkZD Quote Link to comment Share on other sites More sharing options...
Greed2k12 Posted June 13, 2012 Group: Members Topic Count: 2 Topics Per Day: 0.00 Content Count: 9 Reputation: 1 Joined: 03/08/12 Last Seen: August 25, 2021 Share Posted June 13, 2012 You get my thumbs up Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted June 13, 2012 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted June 13, 2012 If you can't make a conf file, which I think would be awesome then my thought was to make a easy to edit diff. Include all the things that people usually edit. You change the settings and then patch the diff. I'm sure there are more than I listed below. common/mmo.h Max cart items Max storage Max guild storage Max party Max friends map/itemdb.h Max RANDITEM map/map.h Max mob skill Max vending Max event queue map/pc.h Max skill tree map/skill.h Max produce db Max arrow db Peopleperson49 Quote Link to comment Share on other sites More sharing options...
Nameless2you Posted June 13, 2012 Group: Members Topic Count: 14 Topics Per Day: 0.00 Content Count: 351 Reputation: 52 Joined: 11/15/11 Last Seen: June 15, 2015 Share Posted June 13, 2012 I understand the point your coming from but I don't see this being necessary, the only thing I can see that might be helpful might be adding something like config.c/h where the most useful things are declared that may possibly at later times be updated, instead of having to visit the mmo.h, mob.h and others.. Quote Link to comment Share on other sites More sharing options...
MarkZD Posted June 13, 2012 Group: Members Topic Count: 6 Topics Per Day: 0.00 Content Count: 134 Reputation: 35 Joined: 02/27/12 Last Seen: April 5, 2022 Share Posted June 13, 2012 I understand the point your coming from but I don't see this being necessary, the only thing I can see that might be helpful might be adding something like config.c/h where the most useful things are declared that may possibly at later times be updated, instead of having to visit the mmo.h, mob.h and others.. It's just same idea from the author's topic above your post, you say you don't get the point but you just said the same thing as his second solution, which is to include it all in one file to make it easy to change, but it's the same as the first suggestion too, just without txt file part. Quote Link to comment Share on other sites More sharing options...
xazax Posted June 14, 2012 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted June 14, 2012 Max level is also one of the most requested stuff to be moved to a config. Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted June 14, 2012 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted June 14, 2012 I really like the idea of putting it into one common src file to be updated. If you use a diff then it still has to be recompiled, so the src files is much easier! When can you get started? Peopleperson49 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.