about this rental script i'm making.

[Jhedzkie]

im trying to create a one-click rental npc for all classes. i've been working on this for an hour now, almost everything's working pretty well except for the cart rental for mechanics.

after getting the cart, my char (mechanic) will be stuck, and will not be able to move unless when i use @refresh or @go 0. anyway, here's my code.

prontera,142,186,3 script Universal Rental Npc 418,{
if( (BaseClass == Job_Merchant || BaseJob == Job_SuperNovice) )
{
 if((Class == Job_Mechanic || Class == Job_Mechanic_T) )
 {
  if(checkcart() == 1) goto getMado;
  else
  {
switch(select("Cart","Mado"))
{
 case 1:
 {
  goto getCart;
 }
 break;
 case 2:
 {
  goto getMado;
 }
 break;
}
  }
 }
 goto getCart;
}
if( (BaseJob != Job_Archer && BaseClass == Job_Archer) && checkfalcon() == 0 && getskilllv("HT_FALCON") > 0 )
{
 setfalcon;
 end;
}
if ( (Class == Job_Rune_Knight || Class == Job_Rune_Knight_T || Class == Job_Baby_Rune) && checkriding() == 0 && getskilllv("RK_DRAGONTRAINING") > 0 )
{
 setdragon;
 end;
}
if ( (Class == Job_Knight || Class == Job_Lord_Knight || Class == Job_Baby_Knight || Class == Job_Crusader || Class == Job_Paladin || Job_Baby_Crusader || Class == Job_Royal_Guard || Class == Job_Royal_Guard_T || Class == Job_Baby_Guard) && checkriding() == 0 && getskilllv("KN_RIDING") > 0 )
{
 setriding;
 end;
}

getCart:
{
 if(checkcart() == 0 && getskilllv("MC_PUSHCART") > 0)
 {
  setcart;
  end;
 }
}
getMado:
{
 if(checkriding() == 0 && getskilllv("NC_MADOLICENCE") > 0)
 {
  setmadogear;
  end;
 }
}
}

any hint on how i could fix this would be a great help. thanks.

Edited May 31, 2012 by Jhedzkie

[Joseph]

Use checkmadogear instead of checkriding.

[Jhedzkie]

Use checkmadogear instead of checkriding.

mado's working for me no sweat, the cart rental's the one who's messing with me a bit.

[F0xxy]

You can add: atcommand "@refresh"; If the only problem is getting stuck.

And a tip: there's way too many unnecessary curlys in your script

[kadze]

try this

http://upaste.me/0003442e63508eb

[Nameless2you]

forgot an end;

modified it for you & added 1 paste to your account

Edited May 30, 2012 by Nameless2you

[Jhedzkie]

You can add: atcommand "@refresh"; If the only problem is getting stuck.

And a tip: there's way too many unnecessary curlys in your script

did tried adding the @refresh before posting it, but im thinking that there might be another work around for it. and oh, curlys not really a big deal. it makes scripts more readable for me.

@kadze, that paste is almost similar from the script from where i extracted mine from. its good but i modded mine for mechanics. to choose whether to have a cart or to have to have a mado.

and as ive said, my script is working pretty well except that the Job_Mechanic and Job_Mechanic_T, whenever they are getting a CART, they get the cart, but gets STUCK (IMMOBILE) as well.

EDIT: hah. fixed it already. thanks guys.

end; should have been close;

Edited May 31, 2012 by Jhedzkie

[clydelion]

maybe add a close;?

bot in getCart and get mado