Jump to content

Recommended Posts

Posted

I think in line 1092 of script.c there is a mistake.

You're correct good sir. Thanks for pointing that out, wouldn't have seen it otherwise.

Posted

You should keep the values returned by search_str("set"), search_str("callfunc") and search_str("getelementofarray") into global variables to avoid searching for them at every occurrence of assignment statements and user-defined function calls.

Posted

You should keep the values returned by search_str("set"), search_str("callfunc") and search_str("getelementofarray") into global variables to avoid searching for them at every occurrence of assignment statements and user-defined function calls.

Indeed, this was something I brought up in the staff channel on IRC. I've been trying to collect a list of additional changes that need committing, and this is on the list. You have a keen eye, great minds think alike :)

Posted

Thanks! that will make our lives more easier.

P.S If you are not busy, try adding abs() also. So the unidentified groupranditem() will be reverted to its normal :) Ya know what has been broken down there.

Posted

Update

It's important to note that r15998 appears to fix a long-standing issue that appears to have been present in rAthena for an extended period of time. For whatever reason, the instance variable storage system was not being initialised (thus instance variables were not being saved or recorded.) If anyone has any reports prior to r15998 of instance variables not working, please let me know. It baffled our team temporarily as to why this was the case in the source.

Thanks.

Posted

Wow...this is nice...xD

now Z3R0 wont be needed to worry of writing these in the scripts xD hahaha~

  • 3 months later...
Posted

Great ! :)

But how to call a function without using "callfunc", I have not found how to do it.

It does not work like that :

- script Test_Call_Function  -1,{

OnInit:
Test("Hello !");
end;
}

function script Test {

 announce getarg(0),bc_all;
 return;
}

Thank you for your help ! :P

Posted

@Swadon: The function needs to be loaded before it's called, so either move it before the script or place it in another script file altogether.

  • Upvote 1
Guest
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...