Error in KDR Function.

[Legato]

First off, I did not get this message from rAthena's SVN. But, I figured I'd post it here anyway because, lots of people are active in this forum. Here's a screen shot of the said error

Happens when I use the @adjgmlvl 0 <player's name> command on a GM character and then log off.

Tia.

[Emistry]

perhap it is some npc script you have added before??

maybe some function named KDR ??

[Conflicts]

if(!getarg(1)) { debugmes "Error in KDR function, getarg(1) invalid value"; return 0; } // [Lighta]

Caused by this script - Link

As you can see, it's just a debug message.

And you are getting it because that said character has NEVER died yet.

Or at least the NPC never recorded any death from him yet. Thus, KDR (Kill Death Ratio) is impossible to calculate.

[Legato]

Ohh, right. It's happened after I installed that script.(Didn't read the script codes,though. )

Thanks, Conflicts and Emistry.

EDIT :

So, does anyone have any idea why it only happens when I adjust the gm level and then log out?

Edited March 11, 2012 by Legato

[tr0n]

Please post script here or @www.pastebin.com

We can't help just with guessing.

Edited March 11, 2012 by tr0n

[Legato]

Please post script here or @www.pastebin.com

We can't help just with guessing.

Conflicts already posted a link of the script.

You should've seen it if you were reading other's posts.

And I did not know that debug mes was caused by that script in the first place that's why I had provided a screen shot of the error.

[Elijah23]

It's just a normal message..

It will not cause harm.. It's just saying that it cannot calculate anything because the player haven't died yet..

NO Death = Debugmes

[tr0n]

@Legato

My fault, I didn't see the link.

On or Off ?

OnInit:
//--Configuration
set .System, 1; //Toggle PvP System (0:Disable|1:Enable)

and which value do you use here ?

set .GMLevel, 90; //GM levels above or equal this level will be ignored by the system

Edited March 11, 2012 by tr0n

[Legato]

I did not change anything on the script.

That debug mes only appears when I adjust the level of a GM. From level 99 to 0 and then log out.

[tr0n]

It does a callfunc with variables in a query_sql @OnPCLogoutEvent.

Gms above 90 doen't get any variables set for this: (Kill, Death)

callfunc("KDR_Calc", Kill, Death)

Now after you set your gm lvl to 0 this will happen @OnPCLogoutEvent:

if(!getarg(1)) { debugmes "Error in KDR function, getarg(1) invalid value"; return 0; } // [Lighta]

Correct me If I'm wrong.

Edited March 11, 2012 by tr0n

[Legato]

So, do I need to be worried about it and do you know how to fix it?

[tr0n]

[don't worry], it prevents that 0 gets calculated.(be happy~)

If you don't want this debugmes change this:

if(!getarg(1)) { debugmes "Error in KDR function, getarg(1) invalid value"; return 0; } // [Lighta]

into this:

if(!getarg(1)) return 0; // [Lighta]

Edited March 13, 2012 by tr0n

[Derceto]

imho debugmes is pointless there, return 0 (or -1) would be sufficient as "0" deaths isn't that uncommon.

[JayPee]

i think that happens when you have 0 deaths because if you have zero death it will lead to a undefined result example: 14 kills / 0 deaths = undefined. I think if you have 0 deaths you should have a 14.0 ratio. My guess is to make +1 to deaths so it would be 14 kills / 0+1 deaths = 14.0 ratio

[Derceto]

i think that happens when you have 0 deaths because if you have zero death it will lead to a undefined result example: 14 kills / 0 deaths = undefined. I think if you have 0 deaths you should have a 14.0 ratio. My guess is to make +1 to deaths so it would be 14 kills / 0+1 deaths = 14.0 ratio

[don't worry], it prevents that 0 gets calculated.(be happy~)

If you don't want this debugmes change this:

if(!getarg(1)) { debugmes "Error in KDR function, getarg(1) invalid value"; return 0; } // [Lighta]

into this:

if(!getarg(1)) return 0; // [Lighta]

if(!getarg(1)) { return getarg(0); }

It's the naming that was wrong here, "Error" is a too disturbing thing to write in debug. Should have been "Info:" or something, If there's any need for it at all, that is.

Edited March 16, 2012 by Derceto