New carts, Favorite item tab, EFST_SIT

[sizenine]

New bugs found.

1) If your character dies, your cart disappears.

2) If you rent out a cart that you previously had items stored in, it will not display those items inside the cart until you relog respawn with the cart on. Therefore, even if you go rent another cart after dying, you won't be able to see the items you had inside the cart until you relog respawn.

Edited March 5, 2012 by sizenine

[Judas]

yeah, seems normal since cart is using that status effect SC i believe to spawn the cart, which seems official since rathena uses that as well. As for the items not showing, i just had to get a new cart and respawn my location like @go map.

I think this only happens if your using other compiles. I checked out a clean rA and applied this patch, and didn't have to relog to see items in my cart again

[sizenine]

I'm not using other SVNs lol... i applied this diff to r15627. you are right about the respawning (guess you don't need actually to relog), but you say its normal/official for the carts to disappear? so carts disappear upon death on kRO RE now?

Edited March 5, 2012 by sizenine

[Judas]

Im just assuming since rathena has a different way of loading sc now. It doesnt use option anymore, well for carts

[Mystery]

Well, for the newer carts is different since rAthena only has a limited amount of an array for old carts. There weren't any news on expanding the cart array.

Read what Rytech was saying here --> http://rathena.org/board/topic/58335-02012012-kro-maintenance/

[Lordamax]

New bugs found.

1) If your character dies, your cart disappears.

2) If you rent out a cart that you previously had items stored in, it will not display those items inside the cart until you relog respawn with the cart on. Therefore, even if you go rent another cart after dying, you won't be able to see the items you had inside the cart until you relog respawn.

I'm experiencing it also! When your character dies! Your cart is gone!

[Judas]

not really a bug per se since its how its coded in

sc_start2(&sd->bl, SC_ON_PUSH_CART, 9999, type, 0, INVALID_TIMER);

so obviously it lasts forever, but sinces its a SC status obviously it would be gone after you die

[sizenine]

well if it is not official behavior, then it is a bug isn't it? unless you're saying this is the intended behavior..

[Judas]

well guess what im trying to say if its the way the coder intended to code it in as a status, then i wouldn't really call it a bug.

But yeah probably isn't offical behaviour, but from rytech's post it seems we can't add any more options masks anymore?

[Lordamax]

got it.. we can't really call this a bug..

Edited March 6, 2012 by Lordamax

[Judas]

i think one mod you can do, is have it be unlimited time perhaps even if you die? Don't field manuals last if you die?

[sizenine]

well guess what im trying to say if its the way the coder intended to code it in as a status, then i wouldn't really call it a bug.

But yeah probably isn't offical behaviour, but from rytech's post it seems we can't add any more options masks anymore?

he intended to code it as a status, but that doesn't mean he intended to have it not behave correctly.

i think one mod you can do, is have it be unlimited time perhaps even if you die? Don't field manuals last if you die?

good idea.

Edited March 6, 2012 by sizenine

[Lordamax]

Another here is if you rent a cart the other player doesn't see your cart until you use the Change Cart skill

[sizenine]

Another here is if you rent a cart the other player doesn't see your cart until you use the Change Cart skill

Already reported that earlier.

[Lordamax]

Another here is if you rent a cart the other player doesn't see your cart until you use the Change Cart skill

Already reported that earlier.

Oh Sorry about that..

[Ronaldo07]

Another here is if you rent a cart the other player doesn't see your cart until you use the Change Cart skill

Maybe something like that can fix this problem

case SC_ON_PUSH_CART:

sc->opt3 |= OPT3_ON_PUSH_CART;

opt_flag = 0;

break;

for show effect, like for riding. Well, i dunno how to do it ^^

[sizenine]

Another here is if you rent a cart the other player doesn't see your cart until you use the Change Cart skill

Maybe something like that can fix this problem

case SC_ON_PUSH_CART:

sc->opt3 |= OPT3_ON_PUSH_CART;

opt_flag = 0;

break;

for show effect, like for riding. Well, i dunno how to do it ^^

i thought the difference in this diff is that we don't use options anymore for carts.. we use statuses.

[Lordamax]

what could be the possible temp fix for the item problem in cart?

[Ronaldo07]

Well, i can show only the first cart with

if( sd->sc.count && sd->sc.data[sC_ON_PUSH_CART] )

clif_status_change(&sd->bl,SI_ON_PUSH_CART,1,9999,sd->sc.data[sC_ON_PUSH_CART]->val1,0,0);

and

if( tsd->sc.count && tsd->sc.data[sC_ON_PUSH_CART] )

clif_statuschange_single(&sd->bl,&tsd->bl,SI_ON_PUSH_CART,1,9999,tsd->sc.data[sC_ON_PUSH_CART]->val1,0,0);

in clif.c, i copied script from the ALL_RIDING system. Riding using a SC too right?

Now, i dunno how to show other carts (2,3,4,5,6,7,8,9)

[Lordamax]

2) If you rent out a cart that you previously had items stored in, it will not display those items inside the cart until you relog respawn with the cart on. Therefore, even if you go rent another cart after dying, you won't be able to see the items you had inside the cart until you relog respawn.

can you find a fix here ronaldo?

Edited March 13, 2012 by Lordamax

[Ronaldo07]

Yes, i found the solution Judas said :

Add

case SC_ON_PUSH_CART:

After

case SC_FOOD_LUK_CASH:

at line ~8029 in status.c

and Add

case SC_ON_PUSH_CART:

After

case SC_CURSEDCIRCLE_TARGET:

at line ~9644 in status.c

Carts don't disappear anymore on dying with this, so the problem is fixed

Edited March 13, 2012 by Ronaldo07

[sizenine]

Yes, i found the solution Judas said :

Add

case SC_ON_PUSH_CART:

After

case SC_FOOD_LUK_CASH:

at line ~8029 in status.c

and Add

case SC_ON_PUSH_CART:

After

case SC_CURSEDCIRCLE_TARGET:

at line ~9644 in status.c

Carts don't disappear anymore on dying with this, so the problem is fixed

I added those two lines and nothing changed.

[Judas]

nice work I didn't find where statuses were kept probably cause I skimmed to fast. SOLVED =)

[sizenine]

Yes, i found the solution Judas said :

Add

case SC_ON_PUSH_CART:

After

case SC_FOOD_LUK_CASH:

at line ~8029 in status.c

and Add

case SC_ON_PUSH_CART:

After

case SC_CURSEDCIRCLE_TARGET:

at line ~9644 in status.c

Carts don't disappear anymore on dying with this, so the problem is fixed

nice that worked. but now there's another bug >.<

so if you have a character that has a cart on, you will notice that all other characters on that account will also show the cart button in the equipment window (alt+q) and also the OFF button. alt+w will work for those characters although no items can be put in. so far it doesn't seem like a bug that can be abused, but it would be nice to have it fixed.

[Judas]

hmm nope i don't get that problem

btw i only applied this line

Add

case SC_ON_PUSH_CART:

After

case SC_FOOD_LUK_CASH:

at line ~8029 in status.c