How can passive skills like Double Attack be affected by critical?

[Gotcha]

Hello guys.

KRO was updated a few weeks ago.

-Some continuous hitting skills that are activated as passive will change to Critical when activated.

Skill list : Double attack, Chain action, Kagemusha, Triple attack and Fear breeze.

So I tried to apply them. Buy I don't know programming language.

I ask for your help.

[tepek]

https://github.com/rathena/rathena/issues/1788

yea i have same problem. how to update this new mechanic on my server?

[Playtester]

Requires packet capturing as the current packet data doesn't support to combine crit with skill. But of course you could just put that into the damage calculation like Focused Arrow Strike:

	if( !(wd.type&DMG_MULTI_HIT) && sstatus->cri && (!skill_id ||
		skill_id == KN_AUTOCOUNTER || skill_id == SN_SHARPSHOOTING ||
		skill_id == MA_SHARPSHOOTING || skill_id == NJ_KIRIKAGE))

Though this code also checks that it's not a multi hit, so I guess further modifications might be needed.

[Meister]

On 3/10/2017 at 8:49 PM, Playtester said:

Requires packet capturing as the current packet data doesn't support to combine crit with skill. But of course you could just put that into the damage calculation like Focused Arrow Strike:

	if( !(wd.type&DMG_MULTI_HIT) && sstatus->cri && (!skill_id ||
		skill_id == KN_AUTOCOUNTER || skill_id == SN_SHARPSHOOTING ||
		skill_id == MA_SHARPSHOOTING || skill_id == NJ_KIRIKAGE))

Though this code also checks that it's not a multi hit, so I guess further modifications might be needed.

Should it be

 if ( wd.type&DMG_MULTI_HIT && Skill ID )?
	

[Playtester]

No, just look how it's done with other skills if you want to add skills here. Or remove the check for multi hit if you want it to work with multi hit.

[Meister]

6 hours ago, Playtester said:

No, just look how it's done with other skills if you want to add skills here. Or remove the check for multi hit if you want it to work with multi hit.

I tried to bypass the check for multi-hit with adding 

&& !(skill_id == TF_DOUBLE)

It works all double attack now are crit even with double attack but the problem is that it doesn't show the yellow damage. I don't know what does it call. Like when you attack double there's a yellow damage showing. 

[Playtester]

You can't show crit on multi-hits. The client doesn't support it.

[Meister]

On 11/28/2017 at 6:13 PM, Playtester said:

You can't show crit on multi-hits. The client doesn't support it.

How come can't? kRO can show it from Ziu's video. Does it need newer client like 2017? or packet issue?

[Playtester]

Well, if it's a new feature then you will need the client that supports it and capture all the packet data required.

[Foob]

This needs a new code indeed got it fully working! Somehow the triple attack skill is not having a crit but its all good.

[noonbora]

On 2017. 12. 10. at 3:25 PM, iAmGnome said:

This needs a new code indeed got it fully working! Somehow the triple attack skill is not having a crit but its all good.

can i ask what new codes needed?

[Secrets]

From my testing on kRO, Triple Attack doesn't show critting red balloon.

 

[Haganezuka]

@iAmGnome can you share the code if possible? tyvm

[Unkon]

Hello  did someone found it ou ?