Moriarty Posted June 7, 2015 Group: Members Topic Count: 27 Topics Per Day: 0.01 Content Count: 135 Reputation: 13 Joined: 06/20/12 Last Seen: April 14, 2018 Share Posted June 7, 2015 Common, Hercules did it more than year and a half ago, it's past time rAthena do it too.https://github.com/HerculesWS/Hercules/commit/82b583b5ef4e729ad2c3c74b26adce16a145605a Link to comment Share on other sites More sharing options...
Stolao Posted June 7, 2015 Group: Developer Topic Count: 48 Topics Per Day: 0.01 Content Count: 1443 Reputation: 337 Joined: 10/17/12 Last Seen: Wednesday at 07:55 PM Share Posted June 7, 2015 Common, Hercules did it more than year and a half ago, it's past time rAthena do it too. https://github.com/HerculesWS/Hercules/commit/82b583b5ef4e729ad2c3c74b26adce16a145605a honestly i would love this to be added as well, tired of having to compress or use dynamic arrays Link to comment Share on other sites More sharing options...
nanakiwurtz Posted June 7, 2015 Group: Members Topic Count: 81 Topics Per Day: 0.02 Content Count: 1654 Reputation: 583 Joined: 08/09/12 Last Seen: January 14, 2020 Share Posted June 7, 2015 honestly i would love this to be added as well, tired of having to compress or use dynamic arrays Link to comment Share on other sites More sharing options...
Zell Posted June 9, 2015 Group: Members Topic Count: 53 Topics Per Day: 0.01 Content Count: 411 Reputation: 261 Joined: 04/25/12 Last Seen: 12 hours ago Share Posted June 9, 2015 yes, agree Link to comment Share on other sites More sharing options...
Aleos Posted June 9, 2015 Group: Development Manager Topic Count: 56 Topics Per Day: 0.01 Content Count: 732 Reputation: 525 Joined: 12/13/11 Last Seen: August 14, 2023 Share Posted June 9, 2015 I've been done with this for a few months and slowly fixing bugs, but it seems to be pretty much stable now. It's just been sitting on the back burner since I wanted some help to test it but everyone's been busy lately :\. I might create a PR/branch or just push to master very soon. 1 Link to comment Share on other sites More sharing options...
Cydh Posted June 10, 2015 Group: Developer Topic Count: 153 Topics Per Day: 0.04 Content Count: 2285 Reputation: 745 Joined: 06/16/12 Last Seen: June 30, 2023 Share Posted June 10, 2015 I've been done with this for a few months and slowly fixing bugs, but it seems to be pretty much stable now. It's just been sitting on the back burner since I wanted some help to test it but everyone's been busy lately :\. I might create a PR/branch or just push to master very soon.asking someone to test is almost impossible job. force push it, wait report Link to comment Share on other sites More sharing options...
Capuche Posted June 10, 2015 Group: Developer Topic Count: 10 Topics Per Day: 0.00 Content Count: 2407 Reputation: 613 Joined: 07/05/12 Last Seen: Monday at 01:55 PM Share Posted June 10, 2015 Make a PR I want to test it ! Link to comment Share on other sites More sharing options...
nanakiwurtz Posted June 10, 2015 Group: Members Topic Count: 81 Topics Per Day: 0.02 Content Count: 1654 Reputation: 583 Joined: 08/09/12 Last Seen: January 14, 2020 Share Posted June 10, 2015 Does it affect the return value of query_sql as well Link to comment Share on other sites More sharing options...
Aleos Posted June 11, 2015 Group: Development Manager Topic Count: 56 Topics Per Day: 0.01 Content Count: 732 Reputation: 525 Joined: 12/13/11 Last Seen: August 14, 2023 Share Posted June 11, 2015 The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. 1 Link to comment Share on other sites More sharing options...
Zell Posted June 11, 2015 Group: Members Topic Count: 53 Topics Per Day: 0.01 Content Count: 411 Reputation: 261 Joined: 04/25/12 Last Seen: 12 hours ago Share Posted June 11, 2015 The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. Thats is a big pull haha, Thanks! Link to comment Share on other sites More sharing options...
samurai.rukasu Posted June 11, 2015 Group: Members Topic Count: 3 Topics Per Day: 0.00 Content Count: 71 Reputation: 3 Joined: 12/31/11 Last Seen: January 17 Share Posted June 11, 2015 With this update, max storage limit size can be updated more than 850??? Link to comment Share on other sites More sharing options...
Moriarty Posted June 12, 2015 Group: Members Topic Count: 27 Topics Per Day: 0.01 Content Count: 135 Reputation: 13 Joined: 06/20/12 Last Seen: April 14, 2018 Author Share Posted June 12, 2015 With this update, max storage limit size can be updated more than 850??? No The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. I know that there is a ShowWarning if query_sql is to return more than 128 results, I don't see you removing it on your pull. I'll test it soon, thanks a lot for the pull Link to comment Share on other sites More sharing options...
nanakiwurtz Posted June 12, 2015 Group: Members Topic Count: 81 Topics Per Day: 0.02 Content Count: 1654 Reputation: 583 Joined: 08/09/12 Last Seen: January 14, 2020 Share Posted June 12, 2015 @@Moriarty, maybe what Aleos means is the array which holds the query_sql result will be able to hold up to 2 billion, but the result of query_sql itself still won't exceed 128. Link to comment Share on other sites More sharing options...
Aleos Posted June 12, 2015 Group: Development Manager Topic Count: 56 Topics Per Day: 0.01 Content Count: 732 Reputation: 525 Joined: 12/13/11 Last Seen: August 14, 2023 Share Posted June 12, 2015 With this update, max storage limit size can be updated more than 850??? No, not item storage. I meant the overall size/storage that variables take up in memory. Technically, right now, from what I've tested before is that rAthena supports a little over 1000 for player storage sizes (pertaining to your actual question). The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. I know that there is a ShowWarning if query_sql is to return more than 128 results, I don't see you removing it on your pull. I'll test it soon, thanks a lot for the pull That check is limited by this: #define SCRIPT_MAX_ARRAYSIZE (UINT_MAX - 1) Link to comment Share on other sites More sharing options...
samurai.rukasu Posted June 12, 2015 Group: Members Topic Count: 3 Topics Per Day: 0.00 Content Count: 71 Reputation: 3 Joined: 12/31/11 Last Seen: January 17 Share Posted June 12, 2015 With this update, max storage limit size can be updated more than 850??? No, not item storage. I meant the overall size/storage that variables take up in memory. Technically, right now, from what I've tested before is that rAthena supports a little over 1000 for player storage sizes (pertaining to your actual question). Thats is great! I never test it up of 850 since i was config to that limit almost year ago when the item limit was downgraded. I made some test and for now i changed to 1250 and it works well to that limit, i dont want change it up of that just in case. If some one try to test more of 1250 and no issues appears, share your testings. Link to comment Share on other sites More sharing options...
Aleos Posted August 31, 2015 Group: Development Manager Topic Count: 56 Topics Per Day: 0.01 Content Count: 732 Reputation: 525 Joined: 12/13/11 Last Seen: August 14, 2023 Share Posted August 31, 2015 Completed in 6295c77. 1 Link to comment Share on other sites More sharing options...
Recommended Posts