Moriarty Posted June 7, 2015 Posted June 7, 2015 Common, Hercules did it more than year and a half ago, it's past time rAthena do it too.https://github.com/HerculesWS/Hercules/commit/82b583b5ef4e729ad2c3c74b26adce16a145605a
Stolao Posted June 7, 2015 Posted June 7, 2015 Common, Hercules did it more than year and a half ago, it's past time rAthena do it too. https://github.com/HerculesWS/Hercules/commit/82b583b5ef4e729ad2c3c74b26adce16a145605a honestly i would love this to be added as well, tired of having to compress or use dynamic arrays
nanakiwurtz Posted June 7, 2015 Posted June 7, 2015 honestly i would love this to be added as well, tired of having to compress or use dynamic arrays
Aleos Posted June 9, 2015 Posted June 9, 2015 I've been done with this for a few months and slowly fixing bugs, but it seems to be pretty much stable now. It's just been sitting on the back burner since I wanted some help to test it but everyone's been busy lately :\. I might create a PR/branch or just push to master very soon. 1
Cydh Posted June 10, 2015 Posted June 10, 2015 I've been done with this for a few months and slowly fixing bugs, but it seems to be pretty much stable now. It's just been sitting on the back burner since I wanted some help to test it but everyone's been busy lately :\. I might create a PR/branch or just push to master very soon.asking someone to test is almost impossible job. force push it, wait report
nanakiwurtz Posted June 10, 2015 Posted June 10, 2015 Does it affect the return value of query_sql as well
Aleos Posted June 11, 2015 Posted June 11, 2015 The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. 1
Zell Posted June 11, 2015 Posted June 11, 2015 The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. Thats is a big pull haha, Thanks!
samurai.rukasu Posted June 11, 2015 Posted June 11, 2015 With this update, max storage limit size can be updated more than 850???
Moriarty Posted June 12, 2015 Author Posted June 12, 2015 With this update, max storage limit size can be updated more than 850??? No The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. I know that there is a ShowWarning if query_sql is to return more than 128 results, I don't see you removing it on your pull. I'll test it soon, thanks a lot for the pull
nanakiwurtz Posted June 12, 2015 Posted June 12, 2015 @@Moriarty, maybe what Aleos means is the array which holds the query_sql result will be able to hold up to 2 billion, but the result of query_sql itself still won't exceed 128.
Aleos Posted June 12, 2015 Posted June 12, 2015 With this update, max storage limit size can be updated more than 850??? No, not item storage. I meant the overall size/storage that variables take up in memory. Technically, right now, from what I've tested before is that rAthena supports a little over 1000 for player storage sizes (pertaining to your actual question). The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch. Here you all go: Pull: 457. Give it a test and tell me if you find any issues. I know that there is a ShowWarning if query_sql is to return more than 128 results, I don't see you removing it on your pull. I'll test it soon, thanks a lot for the pull That check is limited by this: #define SCRIPT_MAX_ARRAYSIZE (UINT_MAX - 1)
samurai.rukasu Posted June 12, 2015 Posted June 12, 2015 With this update, max storage limit size can be updated more than 850??? No, not item storage. I meant the overall size/storage that variables take up in memory. Technically, right now, from what I've tested before is that rAthena supports a little over 1000 for player storage sizes (pertaining to your actual question). Thats is great! I never test it up of 850 since i was config to that limit almost year ago when the item limit was downgraded. I made some test and for now i changed to 1250 and it works well to that limit, i dont want change it up of that just in case. If some one try to test more of 1250 and no issues appears, share your testings.
Recommended Posts