Jump to content

Recommended Posts

Posted

I've been done with this for a few months and slowly fixing bugs, but it seems to be pretty much stable now. It's just been sitting on the back burner since I wanted some help to test it but everyone's been busy lately :\. I might create a PR/branch or just push to master very soon.

  • Upvote 1
Posted

I've been done with this for a few months and slowly fixing bugs, but it seems to be pretty much stable now. It's just been sitting on the back burner since I wanted some help to test it but everyone's been busy lately :\. I might create a PR/branch or just push to master very soon.

asking someone to test is almost impossible job. /heh

force push it, wait report /gg

Posted

The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch.


Here you all go: Pull: 457. Give it a test and tell me if you find any issues.

  • Upvote 1
Posted

The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch.

Here you all go: Pull: 457. Give it a test and tell me if you find any issues.

 

Thats is a big pull haha, Thanks!

Posted

With this update, max storage limit size can be updated more than 850???

No

 

 

The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch.

Here you all go: Pull: 457. Give it a test and tell me if you find any issues.

I know that there is a ShowWarning if query_sql is to return more than 128 results, I don't see you removing it on your pull. 

I'll test it soon, thanks a lot for the pull :)

 

Posted

@@Moriarty, maybe what Aleos means is the array which holds the query_sql result will be able to hold up to 2 billion, but the result of query_sql itself still won't exceed 128.

Posted

With this update, max storage limit size can be updated more than 850???

No, not item storage. I meant the overall size/storage that variables take up in memory. Technically, right now, from what I've tested before is that rAthena supports a little over 1000 for player storage sizes (pertaining to your actual question).

 

 

The script command 'query_sql' isn't going to be affected/changed. The array variable that it saves to though is what is affected from this patch.

Here you all go: Pull: 457. Give it a test and tell me if you find any issues.

I know that there is a ShowWarning if query_sql is to return more than 128 results, I don't see you removing it on your pull. 

I'll test it soon, thanks a lot for the pull :)

 

That check is limited by this:

#define SCRIPT_MAX_ARRAYSIZE (UINT_MAX - 1)
Posted

 

With this update, max storage limit size can be updated more than 850???

No, not item storage. I meant the overall size/storage that variables take up in memory. Technically, right now, from what I've tested before is that rAthena supports a little over 1000 for player storage sizes (pertaining to your actual question).

 

 

Thats is great! I never test it up of 850 since i was config to that limit almost year ago when the item limit was downgraded.

 

I made some test and for now i changed to 1250 and it works well to that limit, i dont want change it up of that just in case.

 

If some one try to test more of 1250 and no issues appears, share your testings.

  • 2 months later...
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...