Scroll of SProtect ported to Ragnarok (from Flyff)

[Limestone]

yes it is present..

[Limestone]

bump clydelion, it still doesn't work on my server

[malufett]

@rage

did you recompile?

[Limestone]

yes.. i recompile

[XeroBall]

i'm use item. it's "[Error]: status_change_start: invalid status change (517)!" on map screen. help me plz.

[Limestone]

same problem as XeroBall.

[Boy]

Hi

Can u post the source at diff.patch it easy we try it.

thanks.

[solid2005]

ep variable error!.

[simplexjay2]

i got this error

status.c: In function ‘status_change_start’:

status.c:7294: error: ‘SC_SPROTECT’ undeclared (first use in this function)

status.c:7294: error: (Each undeclared identifier is reported only once

status.c:7294: error: for each function it appears in.)

status.c: In function ‘status_change_clear’:

status.c:8714: error: ‘SC_SPROTECT’ undeclared (first use in this function)

status.c: In function ‘status_change_clear_buffs’:

status.c:10397: error: ‘SC_SPROTECT’ undeclared (first use in this function)

make[1]: *** [obj_sql/status.o] Error 1

[clydelion]

Re-check diffing.

If anyone's interested, here's a TGA for this mod.

Screenshot:

SPRO.zip

[Limestone]

Re-check diffing.

If anyone's interested, here's a TGA for this mod.

Screenshot:

Still not working on the latest rev Clydelion

[Jhedzkie]

Re-check diffing.

If anyone's interested, here's a TGA for this mod.

Screenshot:

mind sharing what client you used here? and how you did it?

PS: that .tga is not ro-ish. this one would work.

spro.zip

[clydelion]

Yeah. I just tried making one, plus I don't have a talent for this kind of work(design).

Anyway, I used 20120410. It should work on newer clients though.

[Jhedzkie]

about adding the .tga to the client, how did you do it? did you replaced an existing status?

[clydelion]

http://upaste.me/raw/f4df50853aca4039

[Jhedzkie]

oh. you just replaced an existing status.

Edited January 17, 2013 by Jhedzkie

[clydelion]

i did not. o.o how do you say so?

[Jhedzkie]

well, not working for me. my client not displaying the icon. using 2012-04-10. did what you indicated in your patch.

[clydelion]

make sure the icon id match..

in my case, sprotect icon is 676..

status.h

   SI_FLOWER_LEAF = 675,
+    SI_SPRO = 676,
   SI_MAX,

status.c

   //Status that don't have a skill associated.
+    StatusIconChangeTable[sC_SPROTECT] = SI_SPRO;
   StatusIconChangeTable[sC_WEIGHT50] = SI_WEIGHT50;

efstids.lua

 EFST_HAT_EFFECT = 674,
 EFST_FLOWER_LEAF = 675,
+ EFST_SPRO = 676,
 __newindex = function()   error("unknown state") end
}

[Jhedzkie]

make sure the icon id match..

in my case, sprotect icon is 676..

status.h

SI_FLOWER_LEAF = 675,
+	SI_SPRO = 676,
SI_MAX,

status.c

//Status that don't have a skill associated.
+	StatusIconChangeTable[sC_SPROTECT] = SI_SPRO;
StatusIconChangeTable[sC_WEIGHT50] = SI_WEIGHT50;

efstids.lua

 EFST_HAT_EFFECT = 674,
 EFST_FLOWER_LEAF = 675,
+ EFST_SPRO = 676,
 __newindex = function()   error("unknown state") end
}

there it is. StatusIcon 676 in my svn is

SI_RAY_OF_PROTECTION = 676,

which is why i was thinking that you have only overridden an existing status icon, and yeah, you did.

Edit2: tried creating using ID 710 right after last entry in SI

  SI_QUEST_BUFF3 = 707,
  SI_REUSE_LIMIT_RECALL = 708,
  SI_SAVEPOSITION = 709,
+ SI_SPRO = 710,
  SI_MAX,
};

// JOINTBEAT stackable ailments
enum e_joint_break

and still, icon doesn't display.

Note: I just updated my svn to the latest before commenting this.

Edited January 19, 2013 by Jhedzkie

[Limestone]

just a quick solution..

skill.c

   pc_addfame(sd,25); // Success to refine to +10 a lv2 weapon you forged = +25 fame point
   break;
  case 3:
   pc_addfame(sd,1000); // Success to refine to +10 a lv3 weapon you forged = +1000 fame point
   break;
 }
}
  } else {
+ if(sd->sc.data[sC_SPROTECT])
+ {
+  status_change_end(&sd->bl, SC_SPROTECT, INVALID_TIMER);
+  clif_refine(sd->fd,1,idx,item->refine);
+  clif_displaymessage(sd->fd,"[ SProtect is no longer in effect ]");
+
+ } else {
item->refine = 0;
if(item->equip)
 pc_unequipitem(sd,idx,3);
clif_refine(sd->fd,1,idx,item->refine);
pc_delitem(sd,idx,1,0,2, LOG_TYPE_OTHER);
clif_misceffect(&sd->bl,2);
clif_emotion(&sd->bl, E_OMG);
+	}
  }
 }
}

please tell if it works.

Hi Clydelion, i have problem in this src mod, when i use the sprotect scroll, then the item failed, the remaining items that you refine increased refining chance.