Cash Shop Bug

SlashGeeGee · May 12, 2012

Hello rA

don't know where to post this so please transfer me if im in the wrong section

when i purchase an item in my cash shop it doesnt get the item and the cash point still remains and my character freezes and nothing to do but alt+f4 to exit

see screenshot :

1st i purchase an item and click buy then ok .

Reveal hidden contents

2nd nothing happens

Reveal hidden contents

3rd i tried returning the item to the shop and this is what it looks like

Reveal hidden contents

SVN : rAthena

Client : 2010-05-11

Badly Needed your Help

~ SlashGeeGee

GM Takumirai · May 12, 2012

- 1st post your script

- 2nd post this in script section

this is the example

Quote
prontera,155,170,5 cashshop normalcash_shop 83,502:5,503:1

SlashGeeGee · May 12, 2012

My Cash Shop Scripts :

//-- Cash Shops
new_1-2,93,99,4<tab>cashshop<tab>WoE Supplies<tab>1907,14287:100,14288:100
new_1-2,78,101,5<tab>cashshop<tab>Cash Shop Usables<tab>951,12920:100,12921:100,12186:100,13696:100,14158:100,14168:100,13601:100,13500:100,13749:100,13746:50,13755:100,13752:50
new_1-2,121,101,3<tab>cashshop<tab>Cash Shop Items<tab>899,5529:800,5453:500,5495:800,5512:700,5545:700,5569:700,5514:700,5549:700,5325:500,5377:500,13412:1000,13413:1000

Edited May 12, 2012 by SlashGeeGee

GM Takumirai · May 12, 2012

wait

On npc.c add:

Quote

/*==========================================

* Cash Shop Buy List

*------------------------------------------*/

int npc_cashshop_buylist(struct map_session_data *sd, int points, int count, unsigned short* item_list)

{

int i, j, nameid, amount, new_, w, vt;

struct npc_data *nd = (struct npc_data *)map_id2bl(sd->npc_shopid);

if( !nd || nd->subtype != CASHSHOP )

return 1;

if( sd->state.trading )

return 4;

new_ = 0;

w = 0;

vt = 0; // Global Value

// Validating Process ----------------------------------------------------

for( i = 0; i < count; i++ )

{

nameid = item_list[i*2+1];

amount = item_list[i*2+0];

if( !itemdb_exists(nameid) || amount <= 0 )

return 5;

ARR_FIND(0,nd->u.shop.count,j,nd->u.shop.shop_item[j].nameid == nameid);

if( j == nd->u.shop.count || nd->u.shop.shop_item[j].value <= 0 )

return 5;

if( !itemdb_isstackable(nameid) && amount > 1 )

{

ShowWarning("Player %s (%d:%d) sent a hexed packet trying to buy %d of nonstackable item %d!n", sd->status.name, sd->status.account_id, sd->status.char_id, amount, nameid);

amount = item_list[i*2+0] = 1;

}

switch( pc_checkadditem(sd,nameid,amount) )

{

case ADDITEM_NEW:

new_++;

break;

case ADDITEM_OVERAMOUNT:

return 3;

}

vt += nd->u.shop.shop_item[j].value * amount;

w += itemdb_weight(nameid) * amount;

}

if( w + sd->weight > sd->max_weight )

return 3;

if( pc_inventoryblank(sd) < new_ )

return 3;

if( points > vt ) points = vt;

// Payment Process ----------------------------------------------------

if( sd->kafraPoints < points || sd->cashPoints < (vt - points) )

return 6;

pc_paycash(sd,vt,points);

// Delivery Process ----------------------------------------------------

for( i = 0; i < count; i++ )

{

struct item item_tmp;

nameid = item_list[i*2+1];

amount = item_list[i*2+0];

memset(&item_tmp,0,sizeof(item_tmp));

if( !pet_create_egg(sd,nameid) )

{

item_tmp.nameid = nameid;

item_tmp.identify = 1;

pc_additem(sd,&item_tmp,amount);

}

if( log_config.enable_logs&0x20 )

log_pick_pc(sd, "S", nameid, amount, NULL);

}

return 0;

}

On npc.h add:

Quote
int npc_cashshop_buylist(struct map_session_data *sd, int points, int count, unsigned short* item_list);

on clic.c replace with:

Quote

void clif_parse_cashshop_buy(int fd, struct map_session_data *sd)

{

int fail = 0;

struct npc_data *nd;

nullpo_retv(sd);

if( sd->state.trading || !sd->npc_shopid )

fail = 1;

else

{

#if PACKETVER < 20101116

short nameid = RFIFOW(fd,2);

short amount = RFIFOW(fd,4);

int points = RFIFOL(fd,6);

fail = npc_cashshop_buy(sd, nameid, amount, points);

#else

int len = RFIFOW(fd,2);

int points = RFIFOL(fd,4);

int count = RFIFOW(fd,8);

unsigned short* item_list = (unsigned short*)RFIFOP(fd,10);

if( len < 10 || len != 10 + count * 4)

{

ShowWarning("Player %u sent incorrect cash shop buy packet (len %u:%u)!n", sd->status.char_id, len, 10 + count * 4);

return;

}

fail = npc_cashshop_buylist(sd,points,count,item_list);

#endif

}

clif_cashshop_ack(sd,fail);

}

And by last, on packet_db.txt

//2010-11-24aRagexeRE

packet_ver: 26

+0x0288,-1,cashshopbuy,4:8

0x0436,19,wanttoconnection,2:6:10:14:18

- copy right: zephyrus_cr

- i don't know if this is going to work but the said fix is for client 2010

compile your server

cd /home/ra

make clean

make all

done~

Edited May 12, 2012 by GM Takumirai

SlashGeeGee · May 12, 2012

On 5/12/2012 at 12:51 PM, GM Takumirai said:

wait

On npc.c add:

Quote

/*==========================================

* Cash Shop Buy List

*------------------------------------------*/

int npc_cashshop_buylist(struct map_session_data *sd, int points, int count, unsigned short* item_list)

{

int i, j, nameid, amount, new_, w, vt;

struct npc_data *nd = (struct npc_data *)map_id2bl(sd->npc_shopid);

if( !nd || nd->subtype != CASHSHOP )

return 1;

if( sd->state.trading )

return 4;

new_ = 0;

w = 0;

vt = 0; // Global Value

// Validating Process ----------------------------------------------------

for( i = 0; i < count; i++ )

{

nameid = item_list[i*2+1];

amount = item_list[i*2+0];

if( !itemdb_exists(nameid) || amount <= 0 )

return 5;

ARR_FIND(0,nd->u.shop.count,j,nd->u.shop.shop_item[j].nameid == nameid);

if( j == nd->u.shop.count || nd->u.shop.shop_item[j].value <= 0 )

return 5;

if( !itemdb_isstackable(nameid) && amount > 1 )

{

ShowWarning("Player %s (%d:%d) sent a hexed packet trying to buy %d of nonstackable item %d!n", sd->status.name, sd->status.account_id, sd->status.char_id, amount, nameid);

amount = item_list[i*2+0] = 1;

}

switch( pc_checkadditem(sd,nameid,amount) )

{

case ADDITEM_NEW:

new_++;

break;

case ADDITEM_OVERAMOUNT:

return 3;

}

vt += nd->u.shop.shop_item[j].value * amount;

w += itemdb_weight(nameid) * amount;

}

if( w + sd->weight > sd->max_weight )

return 3;

if( pc_inventoryblank(sd) < new_ )

return 3;

if( points > vt ) points = vt;

// Payment Process ----------------------------------------------------

if( sd->kafraPoints < points || sd->cashPoints < (vt - points) )

return 6;

pc_paycash(sd,vt,points);

// Delivery Process ----------------------------------------------------

for( i = 0; i < count; i++ )

{

struct item item_tmp;

nameid = item_list[i*2+1];

amount = item_list[i*2+0];

memset(&item_tmp,0,sizeof(item_tmp));

if( !pet_create_egg(sd,nameid) )

{

item_tmp.nameid = nameid;

item_tmp.identify = 1;

pc_additem(sd,&item_tmp,amount);

}

if( log_config.enable_logs&0x20 )

log_pick_pc(sd, "S", nameid, amount, NULL);

}

return 0;

}

On npc.h add:

Quote
int npc_cashshop_buylist(struct map_session_data *sd, int points, int count, unsigned short* item_list);

on clic.c replace with:

Quote

void clif_parse_cashshop_buy(int fd, struct map_session_data *sd)

{

int fail = 0;

struct npc_data *nd;

nullpo_retv(sd);

if( sd->state.trading || !sd->npc_shopid )

fail = 1;

else

{

#if PACKETVER < 20101116

short nameid = RFIFOW(fd,2);

short amount = RFIFOW(fd,4);

int points = RFIFOL(fd,6);

fail = npc_cashshop_buy(sd, nameid, amount, points);

#else

int len = RFIFOW(fd,2);

int points = RFIFOL(fd,4);

int count = RFIFOW(fd,8);

unsigned short* item_list = (unsigned short*)RFIFOP(fd,10);

if( len < 10 || len != 10 + count * 4)

{

ShowWarning("Player %u sent incorrect cash shop buy packet (len %u:%u)!n", sd->status.char_id, len, 10 + count * 4);

return;

}

fail = npc_cashshop_buylist(sd,points,count,item_list);

#endif

}

clif_cashshop_ack(sd,fail);

}

And by last, on packet_db.txt

//2010-11-24aRagexeRE

packet_ver: 26

+0x0288,-1,cashshopbuy,4:8

0x0436,19,wanttoconnection,2:6:10:14:18

- copy right: zephyrus_cr

- i don't know if this is going to work but the said fix is for client 2010

compile your server

cd /home/ra

make clean

make all

done~

i searched all the lines in the source and packet_db.txt rA already has it but my client date is 2010-05-11 that is for 2010-11-24 is there anyway to change that to my clients date ?

Judas · May 12, 2012

to my knowledge cash shop should work fine before 2010-11-24, there shouldn't be any error.

you're using the msgstringtable for your client date right?

SlashGeeGee · May 12, 2012

this is my msgstringtable judas

http://svn6.assembla.com/svn/ClientSide/Translation_Project/data/msgstringtable%202011-02-08%20below.txt

Judas · May 12, 2012

i'll post back soon, I'll checkout the latest rA, and use the client you have and see what i get

SlashGeeGee · May 12, 2012

On 5/12/2012 at 1:26 PM, Judas said:

i'll post back soon, I'll checkout the latest rA, and use the client you have and see what i get

thanks

btw : im using default in packet_db

Edited May 12, 2012 by SlashGeeGee

Judas · May 12, 2012

works fine,

you can try this if you want

http://www.sendspace.com/file/ltihet

1) Used your script, custom/cashshop.txt

2) checked out latest rA

3) mmo.h set to 20100511 and recompiled fully

4) packet_db set to 25

SlashGeeGee · May 12, 2012

i need to renew my server files ? the server's already running

is there any other way ?

what did you use in the packet_db ?

Thanks Judas , GM Takumirai for the Help

i used packet_db ver : 25

Solved Problems

Golem1988 · August 14, 2012

where can I set cashpoints or currency items which, will be equal to caspoints?

Mystery · August 14, 2012

On 8/14/2012 at 11:15 AM, Golem1988 said:

where can I set cashpoints or currency items which, will be equal to caspoints?

In order to use the cashshop, you would need to first have cashpoints. You can either get cashpoints by using @cash command or using #CASHPOINTS variable.

Blaze · August 19, 2012

hello, please show me the new structure for cash shop items (txt)

sabile145 · September 3, 2012

i have error this my rathena server how to fix this to my own server same problem

Emistry · September 3, 2012

what your error...show it ....

sabile145 · September 6, 2012

my error is npc.c and warning to clif.c if compiling

how to solve this

sabile145 · January 24, 2013

1>c:\documents and settings\bozed\my documents\downloads\rathena svn\src\map\npc.c(1350) : error C2143: syntax error : missing '{' before ':'

1>c:\documents and settings\bozed\my documents\downloads\rathena svn\src\map\npc.c(1350) : error C2059: syntax error : ':'

1>c:\documents and settings\bozed\my documents\downloads\rathena svn\src\map\npc.c(1350) : error C2017: illegal escape sequence

1>c:\documents and settings\bozed\my documents\downloads\rathena svn\src\map\npc.c(1534) : warning C4013: 'npc_buylist_sub' undefined; assuming extern returning inthow to fix this error

1>c:\documents and settings\bozed\my documents\downloads\rathena svn\src\map\clif.c(14405) : warning C4101: 'nd' : unreferenced local variable

imajhaynation · August 8, 2013

ive got the same problem can somebody help me ? im using client 20100730

Sign In

Cash Shop Bug

Question

Link to comment

Share on other sites

18 answers to this question

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Recently Browsing 0 members