2012-03-28 Cart Issue

[Mystery]

There seems to be a problem with renting a cart with this client.. Renting falcons and Pecos work 100% but when it comes to renting a Cart, you can't see it.

Basically, I went to a Kafra, rented a cart and I looked at my char and didn't see a a Cart. When I do alt w, I dont get my inventory either. When I go back to the Kafra to rent another cart, she says I have one already when I don't. I did alt+q too and there's no Off button either.

Using SVN rAthena 15994

[Judas]

Did you apply the sc cart patch

[Mystery]

Im guessing it might be this.. http://www.mediafire.com/?lujf7nbv7bic6oa

Even with it, I get an error in my clif.. undefined reference to `clif_statuschange_single'

if( tsd->sc.count && tsd->sc.data[sC_ON_PUSH_CART] )

clif_statuschange_single(&sd->bl,&tsd->bl,SI_ON_PUSH_CART,1,9999,9,0,0);

//This diff support one cart style only, change the style here. By default 9.

[Judas]

_ after status, it was a typo

[Mystery]

Alright thanks!

[Quicksilver]

So it was a typo I was banging my head for a couple of hours there...

I've applied the patch and corrected this error also but I am having issues with compiling like this also

trunksrcmapstatus.c(7821): warning C4002: too many actual parameters for macro 'pc_isriding'

The compiling succeeded but in game, I cannot remove carts. Any solution on this?

[Judas]

you're using rAthena right? Not any other svn

[Quicksilver]

yes i am using rAthena only

Edited May 5, 2012 by Quicksilver

[msanders1020]

Hello, I am use rathena svn r15996 and I have a few problems with this cart patch.

I had to comment out the code below to get the patch to work but when doing so, I can not take off cart and can not change cart look. Any help would be greatful! Thanks in advance.

  if( tsd->sc.count && tsd->sc.data[sC_ON_PUSH_CART] )
   clif_statuschange_single(&sd->bl,&tsd->bl,SI_ON_PUSH_CART,1,9999,9,0,0);

also this

 case SC_ON_PUSH_CART:
  if ( sc->data[sC_ON_PUSH_CART] )
  {
   status_change_end(bl, SC_ON_PUSH_CART, -1);
   return 0;
  }
  //if (pc_isriding(sd,OPTION_RIDING|OPTION_RIDING_DRAGON|OPTION_MADOGEAR|OPTION_RIDING_WUG|))
  // return 0;

These are the errors I would get if I did not comment them out:

status.c:7816:92: error: macro "pc_isriding" passed 2 arguments, but takes just 1
status.c: In function ?status_change_start?:
status.c:7816: error: ?pc_isriding? undeclared (first use in this function)
status.c:7816: error: (Each undeclared identifier is reported only once
status.c:7816: error: for each function it appears in.)

[Emistry]

erm.....i am using this diff too..

but i have several problems...

when my char die....the cart is removed, and i have to talk to npc again to take the cart.

and

if Player A taken the Cart, and at the same time Player B was there,...Player B will be able to view the Cart

but...

if Player B is then move to another Map, then come back, and he didnt saw the Cart for Player A...

do you know which part of code dealing with this ?

sorry i cant figure out which part of the code to update the info / view of the Cart ?

beside...

sometime character login ..... server will crash..randomly ?

i not really how to detect which part caused this...

[Meister]

1>d:\rathena\src\map\status.c(7981) : warning C4002: too many actual parameters for macro 'pc_isriding'

1>d:\rathena\src\map\clif.c(4057) : warning C4013: 'clif_status_change_single' undefined; assuming extern returning int

@judas. I have an error about this using 2012-04-10

[Judas]

support for carts is a little down the road, I'm having Ind helping me implement them into rAthena. This should cut down a lot of the problems people been having.

[Mystery]

You used this patch?.. http://mysterious-project.googlecode.com/svn/trunk/2012%20Cart%20Patch.patch

[Jhosef]

^ is this already worked?