Problem with skill_db import file

[kalabasa]

All skills that i will put on the import file will automatically gray-out and unusable

after i initiate the @reloadskilldb. i dont have latest rathena mine was last downloaded december 2020

if there's someone know if there's a PR that has been made or might related to fix the issue

will pretty much appreciated.

 

 

 

 

[Start_]

Hi this is how fo fix.

 

You need to increase MAX_SKILL in src.

 

--------------------------

 

\db\import\skill_db.yml

Header:
  Type: SKILL_DB
  Version: 3

Body:
  - Id: 5000
    Name: SM_SWORD_CUSTOM
    Description: Sword Mastery Custom
    MaxLevel: 10
    Type: Weapon

\db\import\skill_tree.yml

Header:
  Type: SKILL_TREE_DB
  Version: 1

Body:
  - Job: Novice
    Tree:
      - Name: SM_SWORD_CUSTOM
        MaxLevel: 9

\src\map\skill.hpp

    SM_SWORD_CUSTOM = 5000,

    
\src\common\mmo.hpp

#define MAX_SKILL 1455 ///Maximum skill can be hold by Player, Homunculus, & Mercenary (skill list) AND skill_db limit

\data\luafiles514\lua files\skillinfoz\skilldescript.lub

[SKID.SM_SWORD_CUSTOM] = {
        "Hello World"
    },

\data\luafiles514\lua files\skillinfoz\skillid.lub

    SM_SWORD_CUSTOM = 5000,

\data\luafiles514\lua files\skillinfoz\skillinfolist.lub

    [SKID.SM_SWORD_CUSTOM] = {
        "SM_SWORD",
        SkillName = "Sword Mastery Custom",
        MaxLv = 10,
        SpAmount = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
        bSeperateLv = false,
        AttackRange = { 1, 1, 1, 1, 1, 1, 1, 1, 1, 1 }
    },

\data\luafiles514\lua files\skillinfoz\skilltreeview.lub

    [JOBID.JT_NOVICE] = {
        [0] = SKID.NV_BASIC,
        [1] = SKID.SM_SWORD_CUSTOM,
        [7] = SKID.NV_FIRSTAID,
        [14] = SKID.NV_TRICKDEAD
    },

\data\luafiles514\lua files\skillinfoz\skilltreeview_web.lub

    NOVICE = {
        [0] = SKID.NV_BASIC,
        [1] = SKID.SM_SWORD_CUSTOM,
        [7] = SKID.NV_FIRSTAID,
        [14] = SKID.NV_TRICKDEAD
    },

 

[Start_]

Have you upgrade your import files to YAML?

[kalabasa]

No, the import folder already exist on my files. and my skill_db is already YAML

Edited May 26, 2022 by kalabasa

[Start_]

Any error appear on log, char, map server?

[kalabasa]

no error, i cant really pinpoint

[Start_]

Then re-check just 1 skill on skill_tree and skill_db for 1 class that had custom skill try to made it usable.

If it work then you can apply to another.

[kalabasa]

So, after @reloadskilldb the skills will gray-out what i did next was making it a item bonus and gives me error

pc_skill: skill with id 0 does not exist in the skill database

[Start_]

1.) If you close and restart server this issue will not be happen.

2.) Using @ reloadskilldb will cause skill missing.

Am I correct?

Edited May 27, 2022 by Start_

[kalabasa]

Yes, you are correct.

[Start_]

Work fine for me.

 

Import/ skill_tree.yml

# This file is a part of rAthena.
#   Copyright(C) 2021 rAthena Development Team
#   https://rathena.org - https://github.com/rathena
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
###########################################################################
# Skill Tree Database
###########################################################################
#
# Skill Tree Settings
#
###########################################################################
# - Job                   Job name.
#   Inherit               Map of job name from which Job will inherit the skill tree. (Default: null)
#                         Note that Job doesn't inherit the child skills, it only inherits the skills defined in Tree of the given job name.
#   Tree:                 List of skills available for the job. (Default: null)
#     - Name              Skill name.
#       MaxLevel          Max level of the skill. Set to 0 to remove the skill.
#       Exclude           Whether the skill is excluded from being inherited. (Default: false)
#       BaseLevel         Minimum base level required to unlock the skill. (Default: 0)
#       JobLevel          Minimum job level required to unlock the skill. (Default: 0)
#       Requires:         List of skills required to unlock the skill. (Default: null)
#         - Name          Skill name.
#           Level         Skill level required. Set to 0 to remove the skill.
###########################################################################

Header:
  Type: SKILL_TREE_DB
  Version: 1
  
Body:
  - Job: Novice
    Tree:
      - Name: SM_BASH
        MaxLevel: 10

 

data/lua/skill/ skilltreeview.lub

[JOBID.JT_NOVICE] = {
		[0] = SKID.NV_BASIC,
		[7] = SKID.NV_FIRSTAID,
		[3] = SKID.SM_BASH,
		[14] = SKID.NV_TRICKDEAD
	},

 

 

 

[kalabasa]

i think we got some misunderstanding here. 

I,m getting problems with

https://github.com/rathena/rathena/blob/master/db/import-tmpl/skill_db.yml

not this

https://github.com/rathena/rathena/blob/master/db/import-tmpl/skill_tree.yml

[Start_]

Ah I see, I will testing that too.

[Start_]

Confirmed. It's happened on my end too.

Please create issue here https://github.com/rathena/rathena/issues and let developer check it.

 

 

 

[Gidz Cross]

Or for temporary fix. When you put skills into import folder. you have to comment out the skills in the pre re or re folder.

[Start_]

9 hours ago, Gidz Cross said:

Or for temporary fix. When you put skills into import folder. you have to comment out the skills in the pre re or re folder.

It's custom skill. Can't comment it because it doesn't had.

[Gidz Cross]

12 hours ago, Start_ said:

It's custom skill. Can't comment it because it doesn't had.

I didnt see any custom skill mentioned above.

[Start_]

10 hours ago, Gidz Cross said:

I didnt see any custom skill mentioned above.

Mine was Sword Mastery 2.

But for Kalabasa I didn't know.

[Gidz Cross]

On 5/29/2022 at 1:56 AM, Gidz Cross said:

Or for temporary fix. When you put skills into import folder. you have to comment out the skills in the pre re or re folder.

Well this works in my case. For example Desperado skill. No matter what you edit in that skill and decided to put it into import. It will not work.

[kartethe31]

No, the import folder already exist on my files. and my skill_db is already YAML

get-mobdro.com
 

 

Edited June 1, 2022 by kartethe31

[kalabasa]

On 5/29/2022 at 1:56 AM, Gidz Cross said:

Or for temporary fix. When you put skills into import folder. you have to comment out the skills in the pre re or re folder.

will try this one.

[kalabasa]

This are the list of skills that wont work on my test

All ensemble skills

parrying

brandish spear

grand cross

Asura Strike

Land Pro

other skills are fixed with this one https://github.com/rathena/rathena/pull/6262