Thara frog is like GTB

[razermantis]

how could thara frog can reduce magic damage? im just only a begginer kindly give me a idea .. that only thara frog card can reduce physical not magical ? 

[Athan17]

from what i research so far, thara frog card DO affect magic damage. but if you really want ALL magical damages to ignore race calculation, here's a solution:
src/battle.c
 

int battle_calc_cardfix(int attack_type, struct block_list *src, struct block_list *target, int nk, int rh_ele, int lh_ele, int64 damage, int left, int flag){
.....
#define APPLY_CARDFIX(damage, fix) { (damage) = (damage) - (int64)(((damage) * (1000 - (fix))) / 1000); }

	switch( attack_type ) {
		case BF_MAGIC:
........
				cardfix = cardfix * (100 - tsd->subsize[sstatus->size] - tsd->subsize[SZ_ALL]) / 100;
				cardfix = cardfix * (100 - tsd->subrace2[s_race2]) / 100;
				cardfix = cardfix * (100 - tsd->subrace[sstatus->race] - tsd->subrace[RC_ALL]) / 100;
				cardfix = cardfix * (100 - tsd->subclass[sstatus->class_] - tsd->subclass[CLASS_ALL]) / 100;


comment out the tsd->subrace

				cardfix = cardfix * (100 - tsd->subsize[sstatus->size] - tsd->subsize[SZ_ALL]) / 100;
				cardfix = cardfix * (100 - tsd->subrace2[s_race2]) / 100;
				//cardfix = cardfix * (100 - tsd->subrace[sstatus->race] - tsd->subrace[RC_ALL]) / 100;
				cardfix = cardfix * (100 - tsd->subclass[sstatus->class_] - tsd->subclass[CLASS_ALL]) / 100;

not yet tested

Edited December 23, 2016 by Athan17

[Playtester]

Racial reductions always worked for magical damage too. Some skills ignore it, though.

[Playtester]

Right now there is no bonus to only reduce physical damage from a race. If a server had that they must have solved that by changing the source code. I've never seen a server like that, though.

If you want that too you'd need to learn how to code yourself. Or ask those servers for a diff.

https://raw.githubusercontent.com/rathena/rathena/master/src/map/battle.c

The function you are looking for is:

int battle_calc_cardfix(int attack_type, struct block_list *src, struct block_list *target, int nk, int rh_ele, int lh_ele, int64 damage, int left, int flag){

[Bringer]

8 hours ago, razermantis said:

how could thara frog can reduce magic damage? im just only a begginer kindly give me a idea .. that only thara frog card can reduce physical not magical ? 

Reduce damage from DemiHuman monster by 30%.
Item Script    
{ bonus2 bSubRace,RC_DemiHuman,30; bonus2 bSubRace,RC_Player,30; },{},{}

Gtb Effect

{ bonus bNoMagicDamage,100; bonus bUseSPrate,100; },{},{}

bonus bNoMagicDamage,100 = 100% all magic miss reduce the like 60

[razermantis]

how could that. happen that thara frog card can reduce Magic skill Damage like Firebolt // Storm gust // all i know thara can only reduce physical attacks not a magic.. im so noob at this

 

[razermantis]

i,ve tried it also nothing happen db/re/item_db.txt .. ill try to remove it but nothing happen

 

  {  bonus2 bSubRace,RC_DemiHuman,30;  },{},{}  >>> Nothing happen


{   bonus2 bSubRace,RC_DemiHuman,30; bonus2 bSubRace,RC_DemiHuman,30; },{},{} >> it works on other skills but ( Cart Termination.. Sacri dont effect why?)

 

[Stolao]

Sir RC_Player

 

Not RC_demihuman

 

Players are their own race

[razermantis]

4058,Thara_Frog_Card,Thara Frog Card,6,20,,10,,,,,,,,32,,,,,{ bonus2 bSubRace,RC_DemiHuman,30; bonus2 bSubRace,RC_Player,30; },{},{} << Original Effect <<

Why this card keep reducing all magic skills? beacase of this >>> bonus2 bSubRace,RC_Player,30??? 

what should i do .. to stop reducing magic damage? all i want that this thara frog card will only reduce physical attacks not magical 

Thank you for your reply.. just want to fixed this problem cuz it takes almost 10 hours O_O but nothing happen

Edited December 21, 2016 by razermantis

[razermantis]

But in other RO like Vanro Etc.. Thara frog dont reduce Magic Skill Damage like " FIREBOLT // STORM GUST// JUPITEL // ETC. all i know is just for melee attacks sorry for being noob and asking so many questions

[razermantis]

when i tried to remove  bonus2 bSubRace,RC_Player,30 some other melee skill will not be reduce

[razermantis]

so if the reduction of thara frog can reduce all magic skills and physicall .. GTB would no longer be use..

[razermantis]

Thank you so much Athna.. you help me :* <3 <3

by the way advance merry christmas send me ur email

[Scylla]

2 hours ago, razermantis said:

how could that. happen that thara frog card can reduce Magic skill Damage like Firebolt // Storm gust // all i know thara can only reduce physical attacks not a magic.. im so noob at this

 

Because RC_Player means everything about the player. You should try removing the  bonus2 bSubRace,RC_Player,30; and test if it works for physical only.

Edited December 21, 2016 by Scylla