skyleo

Please post you're edited script. EDIT: yeah, I made a little mistake: if(countitem(25003) && getgmlevel() < 99) { mes "You don't have a GM Allowance."; close; }this is wrong change it to this:if(!countitem(25003) && getgmlevel() < 99) { mes "You don't have a GM Allowance."; close; }And here the final menu line:switch(select( (getgmlevel() != 99 "I have a GM's Approval Card" : "") +(getgmlevel() < 99 ? "" : ":Guild List") )) {

Are you sure that you're syntax of your for()-loop is right?

Just add this before the switch: if(countitem(25003) && getgmlevel() < 99) { mes "You don't have a GM Allowance."; close; } This counts for all people who have a lesser gm level then 99. Also I made a little mistake at this part: switch(select( ((countitem(25003) || getgmlevel() == 99 ) ?"I have a GM's Approval Card":"") + ":Guild List")) { This would mean that if he has the allowance card it would show "I have a GM's Approval Card" or if he is GM Level 99, but you wanted it to be not shown for GMs level 99, so it should be like this: switch(select( ((countitem(25003) && getgmlevel() != 99 ) ?"I have a GM's Approval Card":"") + ":Guild List")) { Since you want that a GM Level 99 can see only the Guild List.

nope, "status ->def2 +=" means that the following value is being added to the def. so adding the value of your vit multiplied with 2 means that you have 1 vit = 2 def, you have to devide it, just like in the renewal formula.

So you want that players can't access the NPC completely if they don't have any GM allowance?

it's in src/map/status.csearch for this line: status->def2 += (int)(((float)level + status->vit)/2 + ((float)status->agi/5)); //base level + (every 2 vit = +1 def) + (every 5 agi = +1 def) just edit the status->vit)/2 you can just use normal mathematic operators (+, * , / and -) And don't forget to consider the brackets, I find it weird that the comment says that def = level + vit/2 + agi/5 since the value is written like this: def = (level + vit)/2 + agi/5 It also applies only to renewal and be sure that changing it can imbalance your server. (not from code but from playstyle) If you wanted to change the value for pre-renewal it's just a few lines later, this line: status->def2 += status->vit; just multiply it with 2 after the vit.

If the quest is not working caused by a script error it might be line 49: if(countitem(7226) < 8 || countitem(1061) < 100 || countitem(7188) < 1000 || countitem(4299) < 2000 || countitem(7036) < 10 || countitem(7450) < 3 || countitem(7300) < 10 || countitem(2507) < 15 || countitem(1614) < 1 || countitem(1737) < 1 || ) goto L_noItems; Try to remove the last or-operator (yes, the ||) since there's no statement after it. The rest should be fine, as far as I can see. Maybe you should try to leave that label-coding and script a bit more with select and switches instead of menu, it's more well-arranged and others can read your script better. Also: Please write more about the problem, if the NPC isn't working, if the mapserver gives you an error message or if the NPC isn't doing what you expect/want him to be doing.

Please take your time, when you're writing a post to get help on this section. I'm not a native speaker, just like you (hopefuly), yet I take my time to explain my problem better and I'm choosing my topictitle a bit more careful, nobody wants to help you unless he's really bored(like me). You just have to edit this line: switch(select( (countitem(25003)?"I have a GM's Approval Card":"") + ":Guild List")) { and replace it with this: switch(select( ((countitem(25003) || getgmlevel() == 99 ) ?"I have a GM's Approval Card":"") + ":Guild List")) { This will show "Guild List" directly for a GM, the rest of your desires are already fulfilled in this script.

We could help you better, if you'd give us a bigger snippet of your code, since you only gave us the SQL query content we can't say if there's something wrong with your syntax. I'd say it could work if you'd replace .CharLevel$ with "+.CharLevel$+" .

... It's your script shouldn't you be able to find a part where you can just include this code? Didn't I explain it enough?

Sorry but you can't understand this because it's bad explained. Take your time while typing and explaining and you will get your codesnippet faster. EDIT: I won't answer till I can't understand what you mean. And it's still really bad, you might take a friend to help you who can speak good english.

I think it won't reach this part, because the content in the called ( of callsub ) will have a close;. To test this you can just write a mes "I want to know if the script reachs this part"; before the setting. Do it since we're debugging

But there's one thing I don't like at this script, maybe one could help us. I save the returned value of the command in @success, but this is unneccesary because there is a var which is fixed and has the last value an command returned. But unfortunately I forgot his name ...

It's temporary, but you don't have to save it, since you can just create this variable exactly at the point where you're deleting the [HC]. As I said in my post, it's a loss of ressources when you save things like that.

Maybe the Script doesn't get as far to set variable. When there was a close at the labels called with callsub it will be skipped. So just put the set bincat_quel, bincat_quel^1; before the } else { at the beginning of the quest in the labels. Okay? (Don't forget Category 1 = set bincat_quel, bincat_quel^1; Category 2: set bincat_quel, bincat_quel^1;)