Jump to content

latios

Members
  • Content Count

    16
  • Avg. Content Per Day

    0
  • Joined

  • Last visited

Community Reputation

4 Neutral

About latios

  • Rank
    Poring

Profile Information

  • Gender
    Male
  • Location
    Sydney
  • Server
    ChocobotRO
  • Github
    latiosu

Contact Methods

  • Discord
    Eric#7958

Recent Profile Visitors

214 profile views
  1. latios

    ChocobotRO

    I think ChocobotRO is a server worth trying! Anyone playing from the Asia-Pacific region will generally find good latency as server is based in Sydney, Australia.
  2. @ahloi007 The first issue is saying that "j" hasn't been defined on line 2705 in file pc.cpp. You'll want to look around the code there and try to figure out why the definition (e.g. "int j;") is missing. For example, in this part of the diff there is an "int j;" at the top, but isn't there for some reason in your code. @@ -2627,7 +2638,7 @@ void pc_exeautobonus(struct map_session_data *sd, std::vector<s_autobonus> *bonu int j; unsigned int equip_pos_idx = 0; //Create a list of all equipped positions to see if all items needed for the autobonus are still present [Playtester] - for(j = 0; j < EQI_MAX; j++) { + for(j = 0; j < EQI_MAX_BONUS; j++) { if(sd->equip_index[j] >= 0) equip_pos_idx |= sd->inventory.u.items_inventory[sd->equip_index[j]].equip; } The second issue is saying that the constant "EQI_MAX_BONUS" isn't found anywhere in the pc.cpp or pc.hpp files. In the diff, there is a section which indicates it should be added to pc.hpp. You'll want to check if it's there and if it is, figure out why it might not be found in pc.cpp. Here is the part of the diff where it gets added: diff --git a/src/map/pc.hpp b/src/map/pc.hpp index b52784b..23d1a85 100644 --- a/src/map/pc.hpp +++ b/src/map/pc.hpp @@ -84,7 +84,8 @@ enum equip_index { EQI_SHADOW_SHOES, EQI_SHADOW_ACC_R, EQI_SHADOW_ACC_L, - EQI_MAX + EQI_MAX, + EQI_MAX_BONUS = 10 };
  3. latios

    ChocobotRO

    A new Sydney-based low-rate Renewal server that aims to support all Official content from kRO (plus some iRO). Opened March 2020 Episode 16.1 - Banquet for Heroes Doram, Soul Reaper, Star Emperor available Quest-focused (no Job Changer NPC) Party-play encouraged (+20% EXP, 30-level range) Hourly and Daily Rewards Fixed Cast time disabled Renewal Drop table disabled Up-to-date rAthena with 2018 Client Maintained by an active developer and rAthena contributor Open-source server modifications: https://github.com/Latiosu/rathena Discord: https://discord.gg/zNYTw2N Wiki: https://wiki.chocobot.cloud/
  4. What is the best way to help approved pull requests (not on hold) get merged? For example this filtered list of pull requests: https://github.com/rathena/rathena/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved+-label%3Astatus%3Aonhold Would adding things such as screenshots or a video of testing help? I suppose I'm wondering how to help aspiring contributors understand what work is remaining on a PR before it gets merged. It'd be helpful to know if we can do anything else to assist devs for a given PR.
  5. I have also been wondering why Dancer/Bard songs aren't showing skill effects. I'm looking through the commit to see if I can spot anything that might have caused it. @CyberDevil Are you able to confirm that the Dancer/Bard skills work again when you deploy the previous commit 850904a?
  6. Apologies, I may not be able to fix it such that it works with "git apply" for some time. It will have to be a manual process for now.
  7. @ahloi007 Ah apologies, I think I've made a mistake in the uploaded diff. I'll post a fixed version soon, one that works when you run: git apply "Costume System v2.diff"
  8. Thanks @Emistry, that makes sense. Although if I wanted to create a Pull Request to amend values in mob_db.txt based on values in the kRO database on Divine-Pride (e.g. Combat Basilisk Base & Job EXP https://www.divine-pride.net/database/monster/3503/combat-basilisk) would that be rejected since it's not 100% proof direct from kRO (like in-game screenshots)? I suppose I could also just create the PR and see if it's rejected or not. Basically, I'm wondering what alternative sources (besides AEGIS conversion or direct from kRO) I could use to assist with updating rAthena DBs.
  9. Hi there fellow rAthenians (is that right?), I've loved playing RO since I was rather young (back in 2004) and have played it on and off since. I have many fond memories of the original servers and various private servers when I discovered them many years later. I've recently setup my own private server based in Sydney using rAthena and it's been a blast. I'm really loving all the wonderful contributions and content the community here has made. I'm planning to keep an eye out on how I can give back to rAthena for the many joys it has enabled me to have. Hello again and thanks to everyone here in advance! - Latios
  10. Would anyone here happen to know what rAthena uses as a reference or source of truth for correcting mistakes in mob_db.txt? In other words, how would someone know whether a line in mob_db.txt has a mistake in it or not? I have done some digging around the forums and previous GitHub commits but haven't found that states where the values come from or what process to use to confirm correctness. I personally have been using a combination of Divine-Pride, RMS Mob DB and iRO Wiki DB and seeing which has most realistic values and correlating with similar mobs.
  11. @Amir Azman Nyliar's script for Charleston Crisis still works for the rAthena: rAthena Script: https://github.com/Nyliar/RagnarokContent/tree/master/Instance/Officials/Rathena/CharlestonCrisis Client & Server files (in case you are missing them): https://github.com/Nyliar/RagnarokContent/tree/master/Instance/Officials/Common Files/CharlestonCrisis Also remember to update the following line in your "db/re/instance_db.txt" (example diff below): -// 30,Charleston in Distress,3600,300,[email protected],127,282 +30,Charleston Crisis,3600,300,[email protected],127,282 I also replaced Nyliar's merchant with CrazyArashi's merchants since I liked the layout much more. Here is how it looks on my server:
  12. @Captain Oh I see what you mean. There is a nice example of how to remove this limitation in this thread: Hopefully that meets your needs.
  13. Hi all, I've modified secret's script to service third jobs only with the jRO costume. This was to get around the confusing issues that appear with skills when switching base classes. For those who were still wondering how to fix the issue where costume doesn't stay after player reconnects, you'll need to turn on "save_body_style" in your battle config. Here's what rathena's doc/script_commands.txt says: Only the look data for hairstyle, hair color and clothes color are saved to the char server's database and will persist. Body style will also persist if 'save_body_style' configuration is enabled in '/conf/battle/client.conf'. Screenshot of modified script (and NPC sprite): DressRoom_ThirdOnly.txt
  14. @Captain Yes, that's correct. Although a way around this is to "costume" the item on another character who can wear it and then put it in storage to transfer back to your other character to wear. I don't believe the item permissions (storage/trade/drop/etc ...) are modified, so if you could trade it before you can still trade it after "costuming" the item.
  15. Hi all, I've taken the time to update this script and tested it on my server running latest version of rAthena (version at the time of writing Git Hash: f8d5d45). Additional Changes NPC name can now be easily customised by replacing 2nd argument in the function call at the bottom of npc/custom/etc/costume.txt NPC checks whether the user already has the same item being restored equipped or in inventory and will prevent restoring. Fixed/tweaked some typos and grammar for the NPC dialogue and atcommand messages. costume.txt has been included inside the diff Screenshot Costume_System_v2.diff Edit: I actually just discovered that the wonderful secretdataz had already updated the diff to work with newer versions of rAthena here (https://github.com/secretdataz/rathena/pull/8/files). The main differences to my edit is secret's also handles costuming garments and there is atcommand documentation. The diff I have uploaded comes with an updated NPC script.
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use and Privacy Policy.