Playtester

I assume this "Shadow Cross" is a new 4th job class? Your file doesn't contain this class at all, so it uses the official values from the emulator. You will need to expand your job_status.yml with the new jobs.

It's a small error in the rework on the Stone SC. In status.cpp this part: case SC_STONE: case SC_FREEZE: // Undead are immune to Freeze/Stone if (undead_flag && !(flag&SCSTART_NOAVOID)) return 0; break; Needs to be changes to: case SC_STONE: case SC_STONEWAIT: case SC_FREEZE: // Undead are immune to Freeze/Stone if (undead_flag && !(flag&SCSTART_NOAVOID)) return 0; break; I'll forward this to Aleos so he can fix this directly on the emulator.

Lemongrass already fixed this here: https://github.com/rathena/rathena/commit/aae930198d1bf1c491444a55bb028af2a147ad41 Just update rAthena to latest and it should be fixed.

@funtwocrasher I strongly recommend that you set up your server in a way you can always update rAthena without merging trouble. That way you can always stay up-to-date on all the fixes without much effort. For conf/db changes, you only need to make sure to use the import folder for your changes instead of the files themselves. Those folders are set to be ignored by git so your changes are safe there. SRC/NPC changes are part of the git repository, it's a bit more tricky there, it depends a little bit on how you apply your customization. If you are like me and just edit the files directly, but not check them in at all, not even locally (kinda risky), then you need to call "Stash changes" (I'm using Tortoise Git) first, this will remove all your custom changes temporarily and put them into a stash. Then you can just call "Pull" which will update your base files to the latest rAthena (assuming you are still on the master branch). Afterwards just call "Stash pop" that puts your custom changes back in. Sometimes if you changed something that was also updated on rAthena you will have to do a merge and decide what changes to keep / adjust. If you commit your changes into your local respository then as far as I know you can just call Pull directly and it will automatically merge it. If you have your own branch you need to select yourself that you want to merge master into your branch. Not too familiar with that process though. If are really scared of losing your changes, you could also just copy your whole rathena folder as a backup before you pull. Then you can restore lost changes by moving files from the backup back into the main folder. Or to keep a better overview, just backup the files you actually changed. Hope this helps.

You already asked about this here: No need to have two topics about the same thing, especially since you already got an answer.

There is no conversion, just apply the changes you want to the new file or via the import folder as usual.

Ah you define PC_PERM_MAX in the enum (first one is 0, second is 1, third is 2, etc.). You will have to put it last so that it works.

It's not hard to find that out yourself. If you use visual studio Ctrl+F then select to search the whole project and then just enter PC_PERM_MAX and search where it's defined.

You probably need to increase PC_PERM_MAX by 2 then.

Should be fixed now: https://github.com/rathena/rathena/commit/aae930198d1bf1c491444a55bb028af2a147ad41

There was an update to system and it now uses groups.yml instead of groups.conf, might be related to your issue. If you had customized the original source file you might have a merge error? The code you quoted doesn't even include "const s_pcg_permission_name". From the error message I'd say you have the same const in the array appear twice. Look for this code: static const struct s_pcg_permission_name { const char *name; enum e_pc_permission permission; } pc_g_permission_name[PC_PERM_MAX] = { { "can_trade", PC_PERM_TRADE }, { "can_party", PC_PERM_PARTY }, { "all_skill", PC_PERM_ALL_SKILL }, { "all_equipment", PC_PERM_USE_ALL_EQUIPMENT }, { "skill_unconditional", PC_PERM_SKILL_UNCONDITIONAL }, { "join_chat", PC_PERM_JOIN_ALL_CHAT }, { "kick_chat", PC_PERM_NO_CHAT_KICK }, { "hide_session", PC_PERM_HIDE_SESSION }, { "who_display_aid", PC_PERM_WHO_DISPLAY_AID }, { "hack_info", PC_PERM_RECEIVE_HACK_INFO }, { "any_warp", PC_PERM_WARP_ANYWHERE }, { "view_hpmeter", PC_PERM_VIEW_HPMETER }, { "view_equipment", PC_PERM_VIEW_EQUIPMENT }, { "use_check", PC_PERM_USE_CHECK }, { "use_changemaptype", PC_PERM_USE_CHANGEMAPTYPE }, { "all_commands", PC_PERM_USE_ALL_COMMANDS }, { "receive_requests", PC_PERM_RECEIVE_REQUESTS }, { "show_bossmobs", PC_PERM_SHOW_BOSS }, { "disable_pvm", PC_PERM_DISABLE_PVM }, { "disable_pvp", PC_PERM_DISABLE_PVP }, { "disable_commands_when_dead", PC_PERM_DISABLE_CMD_DEAD }, { "channel_admin", PC_PERM_CHANNEL_ADMIN }, { "can_trade_bounded", PC_PERM_TRADE_BOUNDED }, { "item_unconditional", PC_PERM_ITEM_UNCONDITIONAL }, { "command_enable",PC_PERM_ENABLE_COMMAND }, { "bypass_stat_onclone",PC_PERM_BYPASS_STAT_ONCLONE }, { "bypass_max_stat",PC_PERM_BYPASS_MAX_STAT }, { "attendance",PC_PERM_ATTENDANCE }, };

groups.conf is no longer used, it was converted to YAML format: https://github.com/rathena/rathena/blob/master/conf/groups.yml If you had manual modifications to the group rights, you will have to do them again in the new file.

There seems to be an issue with the SQL version right now, I forwarded it to Lemongrass, he'll work on a fix.

Hmm there seems to be an issue with the SQL version right now, I forwarded it to Lemongrass, he'll work on a fix.

Hmm, maybe try a vanilla rAthena without modifications first. Your first goal should be to have no warnings at map-server start. Check if everything is working then. If you want to to add episode 17 stuff, just do it one-by-one and check if it still works. That way you can find out what change breaks the equipment system.

Do you get any errors starting map-server? Looks like maybe the item db file is in wrong format and unable to read the job requirements properly.

Hmm, it's definitely not finding Windows SDK 10.0 even though it looks you have it installed going by the screenshot (you made sure to update after selecting those I hope)? Maybe try installing Visual Studio 2022. That's what I did.

What even is a "correct" formula when you customize max level and stats? You could just put any required exp values you think look cool and are balanced if you want. Gravity didn't do it much differently in the old days.

The way I'd go about it is use the existing Cooldown functionality. The Cooldown is stored per skill, but you could just make Skill B and Skill C also store their cooldown as "Skill A". And then just block Skill B and Skill C when there's a Cooldown for "Skill A". All the code you need would be in skill.cpp. You could for example take a look at WL_RELEASE because that actually fetches the Cooldown from another skill (the preserved skill) and applies it.

You will need to edit the source code. Open skill.cpp and search for SC_COMBO, then you find all parts with combo checks. For example: case MO_CHAINCOMBO: if(!sc) return false; if(sc->data[SC_BLADESTOP]) break; if(sc->data[SC_COMBO] && sc->data[SC_COMBO]->val1 == MO_TRIPLEATTACK) break; return false; This says you can use MO_CHAINCOMBO only if you have the status change SC_BLADESTOP or when you are in combo state (SC_COMBO) and the last skill was MO_TRIPLEATTACK. ("break;" here basically means it works, if you return false, it's blocked.)

This is already working in current rAthena master. It's defined via status.yml now: - Status: Reflectshield Icon: EFST_REFLECTSHIELD DurationLookup: CR_REFLECTSHIELD Flags: NoClearance: true RequireShield: true End: Reflectdamage: true

Technically that makes you load renewal items, but you should put /re/ before /pre-re/, otherwise all pre-renewal items will be overwritten by renewal stats which would be really bad. Also, you will need to edit most of the items in the files first. For example you need to recalculate the DEF, change weapon level 5 to a different weapon level, etc. It's honestly cleaner to go step-by-step and copy a few renewal items into import/item_db.yml and adjust them so they fit pre-renewal.

If you want status resistance of GTB still work as normal, then there's a battle config for it: items.conf Be careful because it will also affect other cards that grant bNoMagicDamage of similar or higher power. If you only want Lex Aeteran and Decrease Agi to be blocked but nothing else then you'll need to edit the source code: status.cpp -> status_get_sc_def

If you have an NVidia graphic card there is no easy way to fix this. You could remove the /lightmap and it fixes most of the issues, but then you won't have any shadows. I personally upgraded to the currently recommended 2021-11-03 client. The graphic glitch caused by NVidia is strongly reduced there.

In case someone else runs into it: This updates makes VS require Windows 10 SDK to compile. If you are still running Windows 8.1 like me, it could be that you can't compile rAthena anymore. But! You can just install Windows 10 SDK on Windows 8.1. It will tell you that the OS is not supported during installation, but it works anyway.