Prompt script command won't return 255 on cancel

[Myskelz]

Hello,
 
I'm using an up-to-date rAthena version and I encountered an odd bug from the prompt script command. When a player clicks on "Cancel", it closes the window and ends the script immediatly.
 
Here is my source code for prompt command:
 
/src/map/script.c (begin from line 4856)

 else if( sd->npc_menu == 0xff )
 {// Cancel was pressed
  sd->state.menu_or_input = 0;
  pc_setreg(sd, add_str("@menu"), 0xff);
  script_pushint(st, 0xff);
  st->state = END;
 }

So, it does effectively return the value "255" with this script (and set the @menu variable to 255 too) but it ends the script after doing that : (st->state = END;).
 
Here is my test script used if you'd like to try to reproduce this problem:
 

sec_in02,141,176,5 script TestPrompt#sec_in02 56,{
 mes "[TestPrompt]";
 mes "@menu = " + @menu;
 mes "Hey.";
 @result = prompt("#1", "#2", "#3");
 
 mes "[TestPrompt]";
 mes "Result : " + @result;
 close;
}

sec_in02,143,176,5 script TestPrompt2#sec_in02 56,{
 mes "[TestPrompt]";
 mes "Hey.";
 
 switch(prompt("#1", "#2", "#3")) {
  case 1:
   mes "#1";
   break;
  case 2:
   mes "#2";
   break;
  case 3:
   mes "#3";
   break;
  case 255:
   mes "SELECT CATCHED";
   break;
 }
 close;
}

So I changed the last line, from st->state = END; to st->state = RUN;
 
src/map/script.c (begin from line 4856)

 else if( sd->npc_menu == 0xff )
 {// Cancel was pressed
  sd->state.menu_or_input = 0;
  pc_setreg(sd, add_str("@menu"), 0xff);
  script_pushint(st, 0xff);
  st->state = RUN; // [Lyyn] Don't end the script plz.
  //st->state = END;
 }

And it works quite fine. I then encountered another bug ; if you add a next to the first NPC after the line "@result = prompt [...]", it will throw a blank window with a next and, if you click on the next button, you'll just get a blank window that will stuck your character (ALT+F4 needed).
 
I would like to know whether my "fix" is fine or if I'm totally wrong. And in this case, it'll be great to tell me what to do in order to get a functionnal prompt command.
 
Thanks in advance!

 

Edit :

Okay, I used grep to check where prompt was used within the npc folder. Result ; nowhere, excepted custom scripts. 

Anyway, I think my fix is kinda good, what do you think about it?

Edited July 6, 2014 by Myskelz

[klesler]

Still ?

I tried and it seems the same yet.

[Stolao]

On 7/7/2014 at 3:31 AM, Myskelz said:

Perhaps I'm the only one in this world who uses this command 

 

Thanks Euphy! 

why necro this? also I use it from time to time

[Hiero]

This change is 6 mounths old (r17699)

 

> http://trac.rathena.org/changeset/17699/rathena/trunk/src/map/script.c

 

But I don't know why it was fixed like that, there is no log about this file. Interesting... Anyone?

[Myskelz]

The source of the commit comes from here : http://rathena.org/board/tracker/issue-7932-prompts-feature-to-return-255-when-you-cancel-a-prompt-seems-to-cause-the-script-engine-not-to-continue-when-you-put-a-close-right-after-it/?gopid=21532#entry21532

 

The prompt command was made for NOT STOPPING the execution of the script after pressing cancel, it was EXPECTED. So, WHY this commit has been accepted?! Why no one has reported this bug?!

 

The commit: https://github.com/rathena/rathena/commit/7a9aa7f

[Euphy]

It was probably a misunderstanding on Aleos' part. We haven't caught it because, as you've noted, this isn't used in any of the official scripts. Please file a bug report and wait for a developer to get to it--thanks!

[Myskelz]

Perhaps I'm the only one in this world who uses this command 

 

Thanks Euphy!