Gidz Cross Posted May 23, 2014 Posted May 23, 2014 This is Suggestions thread right? So here it goes.You might wanna know that hercules improve their item_db. I would suggest that, do not implement that kind of innovation here in rathena. Let the old db as it is.The reason im wring this is because maybe some of the core developers are thinking or have planned to do that in the future. Just dont.Thank you. Quote
Aleos Posted May 23, 2014 Posted May 23, 2014 To my knowledge this isn't on anyone's plate for the foreseeable future. 1 Quote
nanakiwurtz Posted May 23, 2014 Posted May 23, 2014 What do you mean by 'improve their db'?Adding more items? Making the item_db to be more readable? Making the item_db to be looks like LUA file? Quote
Cydh Posted May 23, 2014 Posted May 23, 2014 @gidzdlcrz, for now, I agree for leaving it just like this, CSV. For future, idk my future. @nanakiwurtz, yes, their 'new' .conf format 1 Quote
nanakiwurtz Posted May 23, 2014 Posted May 23, 2014 Haven't visit their forum, I barely visited this forum too Too busy with work.. I guess I'll take a look around again Quote
Gidz Cross Posted May 23, 2014 Author Posted May 23, 2014 Haven't visit their forum, I barely visited this forum too Too busy with work.. I guess I'll take a look around again Well to fill you in here's what their item_db format Hmmm lets say Valkyrie Armor { Id: 2357 AegisName: "Valkyrie_Armor" Name: "Valkyrian Armor" Type: 5 Buy: 0 Weight: 2800 Def: 6 Slots: 1 Job: 0xFFFFFFFE Upper: 2 Loc: 16 EquipLv: 1 Script: <" bonus bAllStats,1; bonus bUnbreakableArmor,0; if(BaseClass==Job_Mage||BaseClass==Job_Archer||BaseClass==Job_Acolyte) bonus2 bResEff,Eff_Silence,5000; else if(BaseClass==Job_Swordman||BaseClass==Job_Merchant||BaseClass==Job_Thief) bonus2 bResEff,Eff_Stun,5000; "> }, While on rathena 2357,Valkyrie_Armor,Valkyrian Armor,4,0,,2800,,6,,1,0xFFFFFFFE,2,2,16,,1,1,0,{ bonus bAllStats,1; bonus bUnbreakableArmor,0; if(BaseClass==Job_Mage||BaseClass==Job_Archer||BaseClass==Job_Acolyte) bonus2 bResEff,Eff_Silence,5000; else if(BaseClass==Job_Swordman||BaseClass==Job_Merchant||BaseClass==Job_Thief) bonus2 bResEff,Eff_Stun,5000; },{},{} Maybe you're thinking a WOW innovation from hercules. @topic Well anyways i meant this topic in a good way. Hehehe. Or if "some" devs planning to make our item_db like theirs, please do set an option weather to use that kind of format or to use the old one. Hehehe. item_db.txt <~> item_db.conf To my knowledge this isn't on anyone's plate for the foreseeable future. Hehe. Im seeing a lot of things lately. My imagination is getting wild. Sorry about that. 1 Quote
Lighta Posted May 23, 2014 Posted May 23, 2014 it not on our current plan no, we might extend or add some db to offert you guys more configuration possibility and allow for us to add content without hardcoding them but nothing like reformat those to LUA like. From Herc they claim 2 point : -readibility : ok ye sure for 1 item but for many boarf, (just because you don't always know wich column is what in our format but you can insert it in any tabler like excel say csv and poof all good. -faster : yeah, well this is mainly due to libconfig, when you parse with it you have to specify what kind of type is each field. Since parsing bool or int is faster then parsing string then it's normal. -inherit : use definition of another item and add stuff to it, (well @override mostly), not that used but this could be usefull ye why not, but we just need to add a column to this to our current format. 1 Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.