Jump to content

New permission to pc_groups


EvilPuncker

Recommended Posts


  • Group:  Members
  • Topic Count:  19
  • Topics Per Day:  0.00
  • Content Count:  713
  • Reputation:   70
  • Joined:  11/08/11
  • Last Seen:  

I'd like to suggest the addition of a new permission to disable monster drops for that group.

bonus permissions xD \/

  • Cannot pickup items
  • Cannot buy/sell items at npc (opening the trade windows is okay tho)
  • Do not gain experience
  • Ignore logout delay

Edited by EvilPuncker
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  647
  • Reputation:   16
  • Joined:  11/21/11
  • Last Seen:  

EvilPuncker, please add this too! Disabled Monster Drop and Attack for Anti Corruption :)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  19
  • Topics Per Day:  0.00
  • Content Count:  713
  • Reputation:   70
  • Joined:  11/08/11
  • Last Seen:  

there is already to disable monster atack "disable_pvm: true"

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  17
  • Topics Per Day:  0.00
  • Content Count:  754
  • Reputation:   186
  • Joined:  05/22/12
  • Last Seen:  

Hi, this diff adds 3 new pemissions

disable_pickup: true
disable_exp: true
disable_store: true

I've tried doing the logout delay part, but the client thinks that the character is still logged in (its either too fast or i'm missing something)

additional_permissions.diff

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  19
  • Topics Per Day:  0.00
  • Content Count:  713
  • Reputation:   70
  • Joined:  11/08/11
  • Last Seen:  

Hi, this diff adds 3 new pemissions

disable_pickup: true
disable_exp: true
disable_store: true

I've tried doing the logout delay part, but the client thinks that the character is still logged in (its either too fast or i'm missing something)

thanks alot! btw I've just noticed that the logout delay bypass is kinda useless :P so I'll remove it from the list, now just missing the permission to disable monster drops

Edited by EvilPuncker
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  17
  • Topics Per Day:  0.00
  • Content Count:  754
  • Reputation:   186
  • Joined:  05/22/12
  • Last Seen:  

Disabling monster drops would be useless, it can be bypassed by doing the following:

1. GM attacks the monsters until it is about to die.

2. A normal player will be the one to last hit the monster.

3. Viola, bypassed the restriction.

It is better to disable pvm all the way, thus using 'disable_pvm'.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  92
  • Topics Per Day:  0.02
  • Content Count:  354
  • Reputation:   22
  • Joined:  11/17/11
  • Last Seen:  

suggesting to disable gm buffing.

eg.

a gm will buff a normal character

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  19
  • Topics Per Day:  0.00
  • Content Count:  713
  • Reputation:   70
  • Joined:  11/08/11
  • Last Seen:  

Disabling monster drops would be useless, it can be bypassed by doing the following:

1. GM attacks the monsters until it is about to die.

2. A normal player will be the one to last hit the monster.

3. Viola, bypassed the restriction.

It is better to disable pvm all the way, thus using 'disable_pvm'.

Well, I was thinking about monsters killed by GM summons/homunculus, right click on monster etc

suggesting to disable gm buffing.

eg.

a gm will buff a normal character

I think its better to have something like "can_use_skills_on_players" xD

  • Upvote 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  92
  • Topics Per Day:  0.02
  • Content Count:  354
  • Reputation:   22
  • Joined:  11/17/11
  • Last Seen:  

yup, its much better. sry, i just woke up when i posted that :)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  17
  • Topics Per Day:  0.00
  • Content Count:  754
  • Reputation:   186
  • Joined:  05/22/12
  • Last Seen:  

Yes, I've updated my copy to be able to use the following settings

 disable_pickup: true
 disable_exp: true
 disable_store: true
 disable_skill_usage: true
 disable_drops: true

If you'd like more, please reply with what you'd like to be added. That way, I don't have to upload a new diff everytime a new option is added.

  • Upvote 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  19
  • Topics Per Day:  0.00
  • Content Count:  713
  • Reputation:   70
  • Joined:  11/08/11
  • Last Seen:  

Yes, I've updated my copy to be able to use the following settings

 disable_pickup: true
 disable_exp: true
 disable_store: true
 disable_skill_usage: true
 disable_drops: true

If you'd like more, please reply with what you'd like to be added. That way, I don't have to upload a new diff everytime a new option is added.

that is cool already, just need any admin to approve this idea :D

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  92
  • Topics Per Day:  0.02
  • Content Count:  354
  • Reputation:   22
  • Joined:  11/17/11
  • Last Seen:  

Updates for this please :)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  92
  • Topics Per Day:  0.02
  • Content Count:  354
  • Reputation:   22
  • Joined:  11/17/11
  • Last Seen:  

@@clydelion could you upload the ones with these

disable_pickup: true

disable_exp: true

disable_store: true

disable_skill_usage: true

disable_drops: true

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  19
  • Topics Per Day:  0.00
  • Content Count:  713
  • Reputation:   70
  • Joined:  11/08/11
  • Last Seen:  

Yes, I've updated my copy to be able to use the following settings

 disable_pickup: true
 disable_exp: true
 disable_store: true
 disable_skill_usage: true
 disable_drops: true

If you'd like more, please reply with what you'd like to be added. That way, I don't have to upload a new diff everytime a new option is added.

when will you upload the new diff? :D

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  17
  • Topics Per Day:  0.00
  • Content Count:  754
  • Reputation:   186
  • Joined:  05/22/12
  • Last Seen:  

okay, here.

let me know if something's amiss.

extended_perm.patch

  • Upvote 1
Link to comment
Share on other sites

  • 1 month later...

  • Group:  Members
  • Topic Count:  19
  • Topics Per Day:  0.00
  • Content Count:  713
  • Reputation:   70
  • Joined:  11/08/11
  • Last Seen:  

okay, here.

let me know if something's amiss.

thanks, I hope it got added to rA

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  164
  • Reputation:   12
  • Joined:  03/08/12
  • Last Seen:  

Disabling monster drops would be useless, it can be bypassed by doing the following:

1. GM attacks the monsters until it is about to die.

2. A normal player will be the one to last hit the monster.

3. Viola, bypassed the restriction.

It is better to disable pvm all the way, thus using 'disable_pvm'.

Well, I was thinking about monsters killed by GM summons/homunculus, right click on monster etc

suggesting to disable gm buffing.

eg.

a gm will buff a normal character

I think its better to have something like "can_use_skills_on_players" xD

+1 :) other GM used "Iduns of apple" to player, Player got to high HP and use Gate of Hell and other skills (abuse) :(

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  92
  • Topics Per Day:  0.02
  • Content Count:  354
  • Reputation:   22
  • Joined:  11/17/11
  • Last Seen:  

would be nice if Game Masters can not also use their storage and guild storage, :) ( they will not be able to put items into storage )

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  69
  • Topics Per Day:  0.02
  • Content Count:  1315
  • Reputation:   372
  • Joined:  12/10/11
  • Last Seen:  

Would using @mail be covered under the can_trade permission? If not, then a permission to disable mail would be nice.

Thinking of some new system that can be made for RO that utilizes these permissions and not being to use the mail would be an awesome addition.

And clydelion, why not have these permissions added in official to the SVN? I don't see the harm in adding more settings to the permission systems. I can actually add your work in myself, if you can give me permission to do.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  53
  • Reputation:   4
  • Joined:  02/08/12
  • Last Seen:  

sorry a bit off topic

how about making this setting :

exp_multiplier : 1000

will multiply all exp earning (mob,quest) 10*current rate

Edited by serakh00
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  17
  • Topics Per Day:  0.00
  • Content Count:  754
  • Reputation:   186
  • Joined:  05/22/12
  • Last Seen:  

Would using @mail be covered under the can_trade permission? If not, then a permission to disable mail would be nice.

Yes it is covered. I also propose changing it to can_give instead of can_trade.

And clydelion, why not have these permissions added in official to the SVN? I don't see the harm in adding more settings to the permission systems. I can actually add your work in myself, if you can give me permission to do.

Yes, please. :D

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  11
  • Topics Per Day:  0.00
  • Content Count:  427
  • Reputation:   123
  • Joined:  11/17/11
  • Last Seen:  

Some small notes on the patch to consider before it is commited:

Naming like: pc_has_permission(sd,PC_PERM_DISABLE_STORE), is a bit confusing I think. So, has permission to not to have permission to open store, or something like that. I think it is better to avoid unnecessary negations. In my opinion permissions like: pickup, exp, store etc are more expressive than the disable_ prefixed counterparts.

The default settings should almost always preserve the original behavior. For instance, if gm's were able to pick up items until now, the default for disable_pickup should be false in groups.conf.

And finaly, if you increased the number of digits of an enum, append the additional 0's to the beginning of the other constants to match the style.

Other than that, it looks ok for me, nice work :)

Edit: just noticed, there are already some other disable_ prefixed permissions, however I still do not think, those are the right way to handle them. Alway better to keep it simple.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  69
  • Topics Per Day:  0.02
  • Content Count:  1315
  • Reputation:   372
  • Joined:  12/10/11
  • Last Seen:  

Some small notes on the patch to consider before it is commited:

Naming like: pc_has_permission(sd,PC_PERM_DISABLE_STORE), is a bit confusing I think. So, has permission to not to have permission to open store, or something like that. I think it is better to avoid unnecessary negations. In my opinion permissions like: pickup, exp, store etc are more expressive than the disable_ prefixed counterparts.

The default settings should almost always preserve the original behavior. For instance, if gm's were able to pick up items until now, the default for disable_pickup should be false in groups.conf.

And finaly, if you increased the number of digits of an enum, append the additional 0's to the beginning of the other constants to match the style.

Other than that, it looks ok for me, nice work :)

Edit: just noticed, there are already some other disable_ prefixed permissions, however I still do not think, those are the right way to handle them. Alway better to keep it simple.

I checked with Ind on this but turns out I not allowed to commit them cause my SVN access is only for documentation changes. =/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...