Lighta Posted June 16, 2012 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted June 16, 2012 So here a basic suggestion, back on r16025 I[nd] inserted [Dekamaster/Nightroad] the @accinfo with geoip thing. may we had a #ifdef GEOIP or something similar to choose wheter to activate this or not ? I have no doubt it may be a great tool but I'm not interested and it's harder to see what's needed for this mod or not wihout. 1 Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted June 17, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Share Posted June 17, 2012 Indeed, they should add a #ifdef Quote Link to comment Share on other sites More sharing options...
MarkZD Posted July 2, 2012 Group: Members Topic Count: 6 Topics Per Day: 0.00 Content Count: 134 Reputation: 35 Joined: 02/27/12 Last Seen: April 5, 2022 Share Posted July 2, 2012 (edited) It'd be better if it was specified in groups permission, because there may be people which don't want part of staff to see such privates things. Edited July 2, 2012 by MarkZD Quote Link to comment Share on other sites More sharing options...
Emistry Posted July 2, 2012 Group: Forum Moderator Topic Count: 93 Topics Per Day: 0.02 Content Count: 10015 Reputation: 2348 Joined: 10/28/11 Last Seen: 3 hours ago Share Posted July 2, 2012 It'd be better if it was specified in groups permission, because there may be people which don't want part of staff too see such privates things. you mean this ?? to Disable accinfo: false to Enable accinfo: true Quote Link to comment Share on other sites More sharing options...
MarkZD Posted July 2, 2012 Group: Members Topic Count: 6 Topics Per Day: 0.00 Content Count: 134 Reputation: 35 Joined: 02/27/12 Last Seen: April 5, 2022 Share Posted July 2, 2012 The other information are provided by the user and are account pertinent information. GeoIP is a personal information, with no relation to account in true, it's a private thing as your home address, and has almost or no use to the major staff. What I said is just an incrementation to set who can see IP/GeoIP. Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 5, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Share Posted July 5, 2012 bump! add a poll please Quote Link to comment Share on other sites More sharing options...
Mystery Posted July 6, 2012 Group: Members Topic Count: 94 Topics Per Day: 0.02 Content Count: 2192 Reputation: 252 Joined: 11/11/11 Last Seen: June 24, 2020 Share Posted July 6, 2012 I rather not. As what emistry said, just disabled it like that. There's no point adding more information/kb into the source files just to disable something so simple and a good tool to use. SO, if you do dislike.. don't know why you would.. just disable it his way. Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 6, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Share Posted July 6, 2012 the POINT here is to have less code compiled by adding some #ifdef and not disabling it for some groupid... btw, want to know why I want it disabled? since my server is just for one country, why the f*ck would I need to know from where is player1 or player9999? remember that the topic is about GEOIP Quote Link to comment Share on other sites More sharing options...
Mystery Posted July 6, 2012 Group: Members Topic Count: 94 Topics Per Day: 0.02 Content Count: 2192 Reputation: 252 Joined: 11/11/11 Last Seen: June 24, 2020 Share Posted July 6, 2012 the POINT here is to have less code compiled by adding some #ifdef and not disabling it for some groupid... btw, want to know why I want it disabled? since my server is just for one country, why the f*ck would I need to know from where is player1 or player9999? remember that the topic is about GEOIP How are you saving less code if you're adding more to the code in the first place? It doesn't make sense. if you want your GMs not even use the damn command, disable it. Okay.. since your server is just for one country.. then I see why you don't need it. But, you're not saving more "Code" if you're going to add #indef to the source code. By adding the #indef in, you're using more lines in the source. Also, half the stuff in your settings, the /battle folder, I bet you have things stated under the "No" or "0" statements. Guess what? The code is still inside the sources but it isn't being read. Now, for GEO, just disable the command and you're fine. Plus, don't get all stingy and upset when I PUT MY OWN OPINION INTO THE TOPIC. If you don't like it, don't get rude and start cussing because of my opinion. Learn to be respectful of other people's opinions. You've added yours and so did others, so I've decided to add mine. 1 Quote Link to comment Share on other sites More sharing options...
EvilPuncker Posted July 6, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 70 Joined: 11/08/11 Last Seen: April 9, 2023 Share Posted July 6, 2012 u seems a bit upset, no? xd the point I made is that we are talking about the geoip thing, not about the @accinfo like you and emistry talked about, you guys know that even with it disabled, the server still load geoip.dat... and I'll not argue about the #ifdef thing that you said because you don't seem to know what you are talking about, no offense. peace guys /gawi 1 Quote Link to comment Share on other sites More sharing options...
Mystery Posted July 6, 2012 Group: Members Topic Count: 94 Topics Per Day: 0.02 Content Count: 2192 Reputation: 252 Joined: 11/11/11 Last Seen: June 24, 2020 Share Posted July 6, 2012 (edited) Since you're so uptight about removal or disabling Geo, do it yourself: http://trac.rathena....t/16025/rathena by reverting what has been changed or simply, remove the loading of the geo. And besides, I wasn't the one angry.. as you clearly seem to be interpreting: the POINT here is to have less code compiled by adding some #ifdef and not disabling it for some groupid... btw, want to know why I want it disabled? since my server is just for one country, why the f*ck would I need to know from where is player1 or player9999? Edited July 6, 2012 by Mysterious Quote Link to comment Share on other sites More sharing options...
Lighta Posted July 6, 2012 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Author Share Posted July 6, 2012 Mysterious #ifdef may add some code but it's faster on rumming time then checking for battle.conf each time so that why I wanted that way. You probably know but just a quick note for those who don't and explain my point, #ifdef is preprocessor configuration wich mean you're binary won't run this code (like it's not even exist) wheareas a battle.config cheking everytime to do it or not. So if you sure you wont use it there no point to have those check, the good point about them is that you can just enable or disable it without recompiling. (so no reboot). Now talking about you can take it out yourself or not is not that much relevant, I could and did with no worry but thinking this way is just ok I don't do suggestion anymore since I can do it my own... I just tough since we were aguing to not add thing not official to treat this like a proper module as it should be. Or in comparaison why don't we add irc mod too with just a battle config ? it's exactly the same for me... You could also take other exemple like : "OFFICIAL_WALKPATH" why not setting it as battle.conf so we can change it on flow etc.. I just think they choose to add some prepocessor configuration to optimise it. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.