MVP Ranker

[Hades03]

The MVP Ranker does't show the real name look @ 3, 4, 6, 7, 8, 9

http://pastebin.com/6sTs24L2

[Lilith]

You can optimize your script...

Just delete array .mobid

and change OnNPCKillEvent label to

OnNPCKillEvent: // Script execution
if(getmonsterinfo(killedrid,22))
set .@s, 1; // If a MvP
...

Type 22 is MvP Exp. See changeset 15872

EDIT:

nevermind

Edited April 30, 2012 by Lilith

[Brian]

Might be easier to write a new script

Here's one that runs off the SQL logs table. First enable the mvplog in trunk/conf/log_athena.conf

// Use MySQL Logs? [sql Version Only] (Note 1)
sql_logs: yes

// Log MVP Monster Drops (Note 1)
// Outdated. Use Pick_Log instead. But this log could be useful to keep track slayed MVPs
log_mvpdrop: yes

Then the NPC script:

prontera,155,188,0	script	MVP Rank	910,{
// get database names, for join
query_sql    "SELECT DATABASE()", .@rag_db$;
query_logsql "SELECT DATABASE()", .@log_db$;

query_sql "SELECT `name`,COUNT(mvp_id) FROM "+.@log_db$+".mvplog " + 
          "LEFT JOIN "+.@rag_db$+".`char` ON mvplog.kill_char_id=`char`.char_id " + 
          "GROUP BY kill_char_id ORDER BY COUNT(mvp_id) DESC LIMIT 10", .@name$, .@kills;

mes "[MVP Rank Top 10]";
for (.@i=0; .@i<getarraysize(.@name$); .@i++) {
	mes "Top ^FF0000"+(.@i+1)+"^000000 "+.@name$[.@i]+" with ^FF0000"+.@kills[.@i]+"^000000 MVPs killed.";
}
close;
}

[Petey Pablo]

@Brian

error. im using eathena latest revision.

[Error]:  Loading NPC file: npc/test/MVP_Ranking.txt
script error on npc/heroinro/MVP_Ranking.txt line 11
parse_line: expect command, missing function name or calling undeclared func
tion
 6 :		query_sql "SELECT `name`,COUNT(mvp_id) FROM "+.@log_db$+".mvplog
" +
 7 :				  "LEFT JOIN "+.@rag_db$+".`char` ON mvplog.kill_char_id
=`char`.char_id " +
 8 :				  "GROUP BY kill_char_id ORDER BY COUNT(mvp_id) DESC LIM
IT 10", .@name$, .@kills;
 9 :
10 :		mes "[MVP Rank Top 10]";
*   11 :		for ('.'@i=0; .@i<getarraysize(.@name$); .@i++) {
12 :				mes "Top ^FF0000"+(.@i+1)+"^000000 "+.@name$[.@i]+" with
^FF0000"+.@kills[.@i]+"^000000 MVPs killed.";
13 :		}
14 :		close;
15 : }

how to fix that function?

Edited April 30, 2012 by Will Suranol

[Emistry]

change

for ('.'@i=0; .@i<getarraysize(.@name$); .@i++) {

to

for( set .@i,0; .@i<getarraysize(.@name$); set .@i,.@i + 1 ){

[Hades03]

im not using sql im using txt

[Brian]

@Will Suranol: oh, it's because direct variable assignment was just added 3 days ago.

r15982: Script Engine Update.

@Jam: sorry, thought you were using SQL because there's no more TXT in rAthena

[Hades03]

but can you make ma 1 via txt?

[iraciz]

fuuuck, we still fucking waiting that shit