simplify scripts who's online

[caspa]

hi this is part of the script that lets you see and display all online characters on the server right now

what i'm trying to do is if a character has a VIP ticket there would be a "(VIP)" next to his name.. so far i have done this... however is there a much more efficient?

mes "[ Control Panel ]";
mes "^ff0000Online Users^000000 :";
        //----------------------------------------------------------------------------------------------------------------
        set .@size, query_sql( "SELECT `name` FROM `char` WHERE `online` = 1 AND `account_id` NOT IN ( SELECT `account_id` FROM `login` WHERE `level` > 0 ) ORDER BY `name` DESC LIMIT 128", .@name$ );
        //-----------------------------------------------------------------------------------------------------------------
               for( set .@i,0; .@i < .@size; set .@i,.@i+1 ) {
        //---------------------------------------------------------------------------
        set .@cid, getcharid(0,.@name$[.@i]);
        set .@did, getcharid(0,.@name$[.@i]);
        set .@item1, 21026;
        set .@count1, countitem(21026);
        set .@item2, 21027;
        set .@count2, countitem(21027);
        //---------------------------------------------------------------------------
        query_sql("SELECT SUM(`amount`) FROM `inventory` WHERE `char_id` = "+.@cid+" AND `nameid` = "+.@item1,.@count1);    
        query_sql("SELECT SUM(`amount`) FROM `inventory` WHERE `char_id` = "+.@did+" AND `nameid` = "+.@item2,.@count2);
        //---------------------------------------------------------------------------
        mes "^0000ff"+( .@i+1 ) +".^000000 ^007700"+ .@name$[.@i] +" "+( .@count1 == 1 ? "(VIP)" : "" ) +""+( .@count2 == 1 ? "(VIP)" : "" ) +"^000000";
        }

[Emistry]

maybe something like this ?

prontera,155,181,5	script	Sample	4_F_KAFRA1,{
	.@current_aid = getcharid(3);
	.@sql$ = "SELECT c.`account_id`,c.`name`,c.`online`, SUM(ISNULL(i.`amount`, 0)) "
		+ "FROM `char` c "
		+ "INNER JOIN `inventory` i ON c.`char_id` = i.`char_id` AND i.`nameid` IN (21026, 210267) "
		+ "WHERE c.`account_id` IN (SELECT `account_id` FROM `login` WHERE `level` > 0) "
		// + "AND c.`online` = 1 "
		+ "GROUP BY i.`char_id` "
		+ "ORDER BY c.`name`";
	.@size = query_sql(.@sql$, .@aid, .@name$, .@online, .@count);
	mes "Found "+.@size+" Record(s)";
	for (.@i = 0; .@i < .@size; .@i++) {
		if (.@online[.@i]) {
			if (attachrid(.@aid[.@i]))
				.@count[.@i] = (countitem(21026) + countitem(210267));
			attachrid(.@current_aid);
		}
		mes "^0000FF"+(.@i+1) +". ^007700"+ .@name$[.@i] +" "+(.@count[.@i] ? "(VIP)" : "" )+" - ^007700"+(.@online[.@i] ? "Online":"Offline" )+"^000000";	
	}
	close;
}

it shall include offline players too.

[caspa]

15 hours ago, Emistry said:

maybe something like this ?

prontera,155,181,5	script	Sample	4_F_KAFRA1,{
	.@current_aid = getcharid(3);
	.@sql$ = "SELECT c.`account_id`,c.`name`,c.`online`, SUM(ISNULL(i.`amount`, 0)) "
		+ "FROM `char` c "
		+ "INNER JOIN `inventory` i ON c.`char_id` = i.`char_id` AND i.`nameid` IN (21026, 210267) "
		+ "WHERE c.`account_id` IN (SELECT `account_id` FROM `login` WHERE `level` > 0) "
		// + "AND c.`online` = 1 "
		+ "GROUP BY i.`char_id` "
		+ "ORDER BY c.`name`";
	.@size = query_sql(.@sql$, .@aid, .@name$, .@online, .@count);
	mes "Found "+.@size+" Record(s)";
	for (.@i = 0; .@i < .@size; .@i++) {
		if (.@online[.@i]) {
			if (attachrid(.@aid[.@i]))
				.@count[.@i] = (countitem(21026) + countitem(210267));
			attachrid(.@current_aid);
		}
		mes "^0000FF"+(.@i+1) +". ^007700"+ .@name$[.@i] +" "+(.@count[.@i] ? "(VIP)" : "" )+" - ^007700"+(.@online[.@i] ? "Online":"Offline" )+"^000000";	
	}
	close;
}

it shall include offline players too.

solved thank you

[PsyOps]

On 5/7/2019 at 8:54 AM, caspa said:

solved thank you

Can you please post how it was solved? thanks!